2009-05-28 16:07:05 +02:00
|
|
|
/*
|
|
|
|
* Block driver for the QCOW version 2 format
|
|
|
|
*
|
|
|
|
* Copyright (c) 2004-2006 Fabrice Bellard
|
|
|
|
*
|
|
|
|
* Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
|
|
* of this software and associated documentation files (the "Software"), to deal
|
|
|
|
* in the Software without restriction, including without limitation the rights
|
|
|
|
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
|
|
* copies of the Software, and to permit persons to whom the Software is
|
|
|
|
* furnished to do so, subject to the following conditions:
|
|
|
|
*
|
|
|
|
* The above copyright notice and this permission notice shall be included in
|
|
|
|
* all copies or substantial portions of the Software.
|
|
|
|
*
|
|
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
|
|
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
|
|
* THE SOFTWARE.
|
|
|
|
*/
|
|
|
|
|
2016-01-18 19:01:42 +01:00
|
|
|
#include "qemu/osdep.h"
|
2009-05-28 16:07:05 +02:00
|
|
|
#include <zlib.h>
|
|
|
|
|
2022-12-21 14:35:49 +01:00
|
|
|
#include "block/block-io.h"
|
2018-03-06 17:14:08 +01:00
|
|
|
#include "qapi/error.h"
|
2018-05-03 21:50:20 +02:00
|
|
|
#include "qcow2.h"
|
2016-03-15 17:22:36 +01:00
|
|
|
#include "qemu/bswap.h"
|
2022-02-26 19:07:23 +01:00
|
|
|
#include "qemu/memalign.h"
|
2012-03-01 18:36:21 +01:00
|
|
|
#include "trace.h"
|
2009-05-28 16:07:05 +02:00
|
|
|
|
2022-10-13 14:36:59 +02:00
|
|
|
int coroutine_fn qcow2_shrink_l1_table(BlockDriverState *bs,
|
|
|
|
uint64_t exact_size)
|
2017-09-18 14:42:29 +02:00
|
|
|
{
|
|
|
|
BDRVQcow2State *s = bs->opaque;
|
|
|
|
int new_l1_size, i, ret;
|
|
|
|
|
|
|
|
if (exact_size >= s->l1_size) {
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
new_l1_size = exact_size;
|
|
|
|
|
|
|
|
#ifdef DEBUG_ALLOC2
|
|
|
|
fprintf(stderr, "shrink l1_table from %d to %d\n", s->l1_size, new_l1_size);
|
|
|
|
#endif
|
|
|
|
|
2023-06-01 13:51:45 +02:00
|
|
|
BLKDBG_CO_EVENT(bs->file, BLKDBG_L1_SHRINK_WRITE_TABLE);
|
2022-10-13 14:37:06 +02:00
|
|
|
ret = bdrv_co_pwrite_zeroes(bs->file,
|
|
|
|
s->l1_table_offset + new_l1_size * L1E_SIZE,
|
|
|
|
(s->l1_size - new_l1_size) * L1E_SIZE, 0);
|
2017-09-18 14:42:29 +02:00
|
|
|
if (ret < 0) {
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
|
2022-10-13 14:37:06 +02:00
|
|
|
ret = bdrv_co_flush(bs->file->bs);
|
2017-09-18 14:42:29 +02:00
|
|
|
if (ret < 0) {
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
|
2023-06-01 13:51:45 +02:00
|
|
|
BLKDBG_CO_EVENT(bs->file, BLKDBG_L1_SHRINK_FREE_L2_CLUSTERS);
|
2017-09-18 14:42:29 +02:00
|
|
|
for (i = s->l1_size - 1; i > new_l1_size - 1; i--) {
|
|
|
|
if ((s->l1_table[i] & L1E_OFFSET_MASK) == 0) {
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
qcow2_free_clusters(bs, s->l1_table[i] & L1E_OFFSET_MASK,
|
|
|
|
s->cluster_size, QCOW2_DISCARD_ALWAYS);
|
|
|
|
s->l1_table[i] = 0;
|
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
fail:
|
|
|
|
/*
|
|
|
|
* If the write in the l1_table failed the image may contain a partially
|
|
|
|
* overwritten l1_table. In this case it would be better to clear the
|
|
|
|
* l1_table in memory to avoid possible image corruption.
|
|
|
|
*/
|
|
|
|
memset(s->l1_table + new_l1_size, 0,
|
2020-08-28 13:08:28 +02:00
|
|
|
(s->l1_size - new_l1_size) * L1E_SIZE);
|
2017-09-18 14:42:29 +02:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2013-05-14 16:14:33 +02:00
|
|
|
int qcow2_grow_l1_table(BlockDriverState *bs, uint64_t min_size,
|
|
|
|
bool exact_size)
|
2009-05-28 16:07:05 +02:00
|
|
|
{
|
2015-09-07 17:12:56 +02:00
|
|
|
BDRVQcow2State *s = bs->opaque;
|
2013-05-14 16:14:33 +02:00
|
|
|
int new_l1_size2, ret, i;
|
2009-05-28 16:07:05 +02:00
|
|
|
uint64_t *new_l1_table;
|
2013-09-30 17:57:21 +02:00
|
|
|
int64_t old_l1_table_offset, old_l1_size;
|
2013-05-14 16:14:33 +02:00
|
|
|
int64_t new_l1_table_offset, new_l1_size;
|
2009-05-28 16:07:05 +02:00
|
|
|
uint8_t data[12];
|
|
|
|
|
2010-10-18 17:53:53 +02:00
|
|
|
if (min_size <= s->l1_size)
|
2009-05-28 16:07:05 +02:00
|
|
|
return 0;
|
2010-10-18 17:53:53 +02:00
|
|
|
|
qcow2: Check min_size in qcow2_grow_l1_table()
First, new_l1_size is an int64_t, whereas min_size is a uint64_t.
Therefore, during the loop which adjusts new_l1_size until it equals or
exceeds min_size, new_l1_size might overflow and become negative. The
comparison in the loop condition however will take it as an unsigned
value (because min_size is unsigned) and therefore recognize it as
exceeding min_size. Therefore, the loop is left with a negative
new_l1_size, which is not correct. This could be fixed by making
new_l1_size uint64_t.
On the other hand, however, by doing this, the while loop may take
forever. If min_size is e.g. UINT64_MAX, it will take new_l1_size
probably multiple overflows to reach the exact same value (if it reaches
it at all). Then, right after the loop, new_l1_size will be recognized
as being too big anyway.
Both problems require a ridiculously high min_size value, which is very
unlikely to occur; but both problems are also simply avoided by checking
whether min_size is sane before calculating new_l1_size (which should
still be checked separately, though).
Signed-off-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2014-04-29 19:03:14 +02:00
|
|
|
/* Do a sanity check on min_size before trying to calculate new_l1_size
|
|
|
|
* (this prevents overflows during the while loop for the calculation of
|
|
|
|
* new_l1_size) */
|
2020-08-28 13:08:28 +02:00
|
|
|
if (min_size > INT_MAX / L1E_SIZE) {
|
qcow2: Check min_size in qcow2_grow_l1_table()
First, new_l1_size is an int64_t, whereas min_size is a uint64_t.
Therefore, during the loop which adjusts new_l1_size until it equals or
exceeds min_size, new_l1_size might overflow and become negative. The
comparison in the loop condition however will take it as an unsigned
value (because min_size is unsigned) and therefore recognize it as
exceeding min_size. Therefore, the loop is left with a negative
new_l1_size, which is not correct. This could be fixed by making
new_l1_size uint64_t.
On the other hand, however, by doing this, the while loop may take
forever. If min_size is e.g. UINT64_MAX, it will take new_l1_size
probably multiple overflows to reach the exact same value (if it reaches
it at all). Then, right after the loop, new_l1_size will be recognized
as being too big anyway.
Both problems require a ridiculously high min_size value, which is very
unlikely to occur; but both problems are also simply avoided by checking
whether min_size is sane before calculating new_l1_size (which should
still be checked separately, though).
Signed-off-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2014-04-29 19:03:14 +02:00
|
|
|
return -EFBIG;
|
|
|
|
}
|
|
|
|
|
2010-10-18 17:53:53 +02:00
|
|
|
if (exact_size) {
|
|
|
|
new_l1_size = min_size;
|
|
|
|
} else {
|
|
|
|
/* Bump size up to reduce the number of times we have to grow */
|
|
|
|
new_l1_size = s->l1_size;
|
|
|
|
if (new_l1_size == 0) {
|
|
|
|
new_l1_size = 1;
|
|
|
|
}
|
|
|
|
while (min_size > new_l1_size) {
|
2017-06-22 13:04:16 +02:00
|
|
|
new_l1_size = DIV_ROUND_UP(new_l1_size * 3, 2);
|
2010-10-18 17:53:53 +02:00
|
|
|
}
|
2009-05-28 16:07:05 +02:00
|
|
|
}
|
2010-10-18 17:53:53 +02:00
|
|
|
|
2016-06-15 17:36:30 +02:00
|
|
|
QEMU_BUILD_BUG_ON(QCOW_MAX_L1_SIZE > INT_MAX);
|
2020-08-28 13:08:28 +02:00
|
|
|
if (new_l1_size > QCOW_MAX_L1_SIZE / L1E_SIZE) {
|
2013-05-14 16:14:33 +02:00
|
|
|
return -EFBIG;
|
|
|
|
}
|
|
|
|
|
2009-05-28 16:07:05 +02:00
|
|
|
#ifdef DEBUG_ALLOC2
|
2013-05-14 16:14:33 +02:00
|
|
|
fprintf(stderr, "grow l1_table from %d to %" PRId64 "\n",
|
|
|
|
s->l1_size, new_l1_size);
|
2009-05-28 16:07:05 +02:00
|
|
|
#endif
|
|
|
|
|
2020-08-28 13:08:28 +02:00
|
|
|
new_l1_size2 = L1E_SIZE * new_l1_size;
|
2020-01-18 20:09:26 +01:00
|
|
|
new_l1_table = qemu_try_blockalign(bs->file->bs, new_l1_size2);
|
2014-05-20 17:12:47 +02:00
|
|
|
if (new_l1_table == NULL) {
|
|
|
|
return -ENOMEM;
|
|
|
|
}
|
2020-01-18 20:09:26 +01:00
|
|
|
memset(new_l1_table, 0, new_l1_size2);
|
2014-05-20 17:12:47 +02:00
|
|
|
|
2016-09-13 10:56:27 +02:00
|
|
|
if (s->l1_size) {
|
2020-08-28 13:08:28 +02:00
|
|
|
memcpy(new_l1_table, s->l1_table, s->l1_size * L1E_SIZE);
|
2016-09-13 10:56:27 +02:00
|
|
|
}
|
2009-05-28 16:07:05 +02:00
|
|
|
|
|
|
|
/* write new table (align to cluster) */
|
2010-04-14 14:17:38 +02:00
|
|
|
BLKDBG_EVENT(bs->file, BLKDBG_L1_GROW_ALLOC_TABLE);
|
2009-05-28 16:07:07 +02:00
|
|
|
new_l1_table_offset = qcow2_alloc_clusters(bs, new_l1_size2);
|
2010-01-20 15:04:01 +01:00
|
|
|
if (new_l1_table_offset < 0) {
|
2014-05-20 17:12:47 +02:00
|
|
|
qemu_vfree(new_l1_table);
|
2010-01-20 15:04:01 +01:00
|
|
|
return new_l1_table_offset;
|
|
|
|
}
|
2011-01-10 17:17:28 +01:00
|
|
|
|
|
|
|
ret = qcow2_cache_flush(bs, s->refcount_block_cache);
|
|
|
|
if (ret < 0) {
|
2011-06-01 10:50:00 +02:00
|
|
|
goto fail;
|
2011-01-10 17:17:28 +01:00
|
|
|
}
|
2009-05-28 16:07:05 +02:00
|
|
|
|
2013-08-30 14:34:26 +02:00
|
|
|
/* the L1 position has not yet been updated, so these clusters must
|
|
|
|
* indeed be completely free */
|
2013-10-10 11:09:23 +02:00
|
|
|
ret = qcow2_pre_write_overlap_check(bs, 0, new_l1_table_offset,
|
2019-01-15 20:39:06 +01:00
|
|
|
new_l1_size2, false);
|
2013-08-30 14:34:26 +02:00
|
|
|
if (ret < 0) {
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
|
2010-04-14 14:17:38 +02:00
|
|
|
BLKDBG_EVENT(bs->file, BLKDBG_L1_GROW_WRITE_TABLE);
|
2009-05-28 16:07:05 +02:00
|
|
|
for(i = 0; i < s->l1_size; i++)
|
|
|
|
new_l1_table[i] = cpu_to_be64(new_l1_table[i]);
|
block: Change bdrv_{pread,pwrite,pwrite_sync}() param order
Swap 'buf' and 'bytes' around for consistency with
bdrv_co_{pread,pwrite}(), and in preparation to implement these
functions using generated_co_wrapper.
Callers were updated using this Coccinelle script:
@@ expression child, offset, buf, bytes, flags; @@
- bdrv_pread(child, offset, buf, bytes, flags)
+ bdrv_pread(child, offset, bytes, buf, flags)
@@ expression child, offset, buf, bytes, flags; @@
- bdrv_pwrite(child, offset, buf, bytes, flags)
+ bdrv_pwrite(child, offset, bytes, buf, flags)
@@ expression child, offset, buf, bytes, flags; @@
- bdrv_pwrite_sync(child, offset, buf, bytes, flags)
+ bdrv_pwrite_sync(child, offset, bytes, buf, flags)
Resulting overly-long lines were then fixed by hand.
Signed-off-by: Alberto Faria <afaria@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Message-Id: <20220609152744.3891847-3-afaria@redhat.com>
Reviewed-by: Hanna Reitz <hreitz@redhat.com>
Signed-off-by: Hanna Reitz <hreitz@redhat.com>
2022-06-09 17:27:36 +02:00
|
|
|
ret = bdrv_pwrite_sync(bs->file, new_l1_table_offset, new_l1_size2,
|
|
|
|
new_l1_table, 0);
|
2010-06-16 17:44:35 +02:00
|
|
|
if (ret < 0)
|
2009-05-28 16:07:05 +02:00
|
|
|
goto fail;
|
|
|
|
for(i = 0; i < s->l1_size; i++)
|
|
|
|
new_l1_table[i] = be64_to_cpu(new_l1_table[i]);
|
|
|
|
|
|
|
|
/* set new table */
|
2010-04-14 14:17:38 +02:00
|
|
|
BLKDBG_EVENT(bs->file, BLKDBG_L1_GROW_ACTIVATE_TABLE);
|
2016-06-16 18:06:17 +02:00
|
|
|
stl_be_p(data, new_l1_size);
|
2013-11-05 17:38:36 +01:00
|
|
|
stq_be_p(data + 4, new_l1_table_offset);
|
block: Change bdrv_{pread,pwrite,pwrite_sync}() param order
Swap 'buf' and 'bytes' around for consistency with
bdrv_co_{pread,pwrite}(), and in preparation to implement these
functions using generated_co_wrapper.
Callers were updated using this Coccinelle script:
@@ expression child, offset, buf, bytes, flags; @@
- bdrv_pread(child, offset, buf, bytes, flags)
+ bdrv_pread(child, offset, bytes, buf, flags)
@@ expression child, offset, buf, bytes, flags; @@
- bdrv_pwrite(child, offset, buf, bytes, flags)
+ bdrv_pwrite(child, offset, bytes, buf, flags)
@@ expression child, offset, buf, bytes, flags; @@
- bdrv_pwrite_sync(child, offset, buf, bytes, flags)
+ bdrv_pwrite_sync(child, offset, bytes, buf, flags)
Resulting overly-long lines were then fixed by hand.
Signed-off-by: Alberto Faria <afaria@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Message-Id: <20220609152744.3891847-3-afaria@redhat.com>
Reviewed-by: Hanna Reitz <hreitz@redhat.com>
Signed-off-by: Hanna Reitz <hreitz@redhat.com>
2022-06-09 17:27:36 +02:00
|
|
|
ret = bdrv_pwrite_sync(bs->file, offsetof(QCowHeader, l1_size),
|
|
|
|
sizeof(data), data, 0);
|
2010-06-16 17:44:35 +02:00
|
|
|
if (ret < 0) {
|
2009-05-28 16:07:05 +02:00
|
|
|
goto fail;
|
2010-01-20 15:02:58 +01:00
|
|
|
}
|
2014-05-20 17:12:47 +02:00
|
|
|
qemu_vfree(s->l1_table);
|
2013-09-30 17:57:21 +02:00
|
|
|
old_l1_table_offset = s->l1_table_offset;
|
2009-05-28 16:07:05 +02:00
|
|
|
s->l1_table_offset = new_l1_table_offset;
|
|
|
|
s->l1_table = new_l1_table;
|
2013-09-30 17:57:21 +02:00
|
|
|
old_l1_size = s->l1_size;
|
2009-05-28 16:07:05 +02:00
|
|
|
s->l1_size = new_l1_size;
|
2020-08-28 13:08:28 +02:00
|
|
|
qcow2_free_clusters(bs, old_l1_table_offset, old_l1_size * L1E_SIZE,
|
2013-09-30 17:57:21 +02:00
|
|
|
QCOW2_DISCARD_OTHER);
|
2009-05-28 16:07:05 +02:00
|
|
|
return 0;
|
|
|
|
fail:
|
2014-05-20 17:12:47 +02:00
|
|
|
qemu_vfree(new_l1_table);
|
2013-06-19 13:44:18 +02:00
|
|
|
qcow2_free_clusters(bs, new_l1_table_offset, new_l1_size2,
|
|
|
|
QCOW2_DISCARD_OTHER);
|
2010-06-16 17:44:35 +02:00
|
|
|
return ret;
|
2009-05-28 16:07:05 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* l2_load
|
|
|
|
*
|
2018-02-05 15:33:15 +01:00
|
|
|
* @bs: The BlockDriverState
|
|
|
|
* @offset: A guest offset, used to calculate what slice of the L2
|
|
|
|
* table to load.
|
|
|
|
* @l2_offset: Offset to the L2 table in the image file.
|
|
|
|
* @l2_slice: Location to store the pointer to the L2 slice.
|
2009-05-28 16:07:05 +02:00
|
|
|
*
|
2018-02-05 15:33:15 +01:00
|
|
|
* Loads a L2 slice into memory (L2 slices are the parts of L2 tables
|
|
|
|
* that are loaded by the qcow2 cache). If the slice is in the cache,
|
|
|
|
* the cache is used; otherwise the L2 slice is loaded from the image
|
|
|
|
* file.
|
2009-05-28 16:07:05 +02:00
|
|
|
*/
|
2023-09-29 16:51:49 +02:00
|
|
|
static int GRAPH_RDLOCK
|
|
|
|
l2_load(BlockDriverState *bs, uint64_t offset,
|
|
|
|
uint64_t l2_offset, uint64_t **l2_slice)
|
2009-05-28 16:07:05 +02:00
|
|
|
{
|
2015-09-07 17:12:56 +02:00
|
|
|
BDRVQcow2State *s = bs->opaque;
|
2020-07-10 18:12:54 +02:00
|
|
|
int start_of_slice = l2_entry_size(s) *
|
2018-02-05 15:33:15 +01:00
|
|
|
(offset_to_l2_index(s, offset) - offset_to_l2_slice_index(s, offset));
|
2009-05-28 16:07:05 +02:00
|
|
|
|
2018-02-05 15:33:15 +01:00
|
|
|
return qcow2_cache_get(bs, s->l2_table_cache, l2_offset + start_of_slice,
|
|
|
|
(void **)l2_slice);
|
2009-05-28 16:07:05 +02:00
|
|
|
}
|
|
|
|
|
2009-06-16 11:31:28 +02:00
|
|
|
/*
|
2020-01-18 20:09:28 +01:00
|
|
|
* Writes an L1 entry to disk (note that depending on the alignment
|
|
|
|
* requirements this function may write more that just one entry in
|
|
|
|
* order to prevent bdrv_pwrite from performing a read-modify-write)
|
2009-06-16 11:31:28 +02:00
|
|
|
*/
|
2013-08-30 14:34:28 +02:00
|
|
|
int qcow2_write_l1_entry(BlockDriverState *bs, int l1_index)
|
2009-06-16 11:31:28 +02:00
|
|
|
{
|
2015-09-07 17:12:56 +02:00
|
|
|
BDRVQcow2State *s = bs->opaque;
|
2009-06-16 11:31:28 +02:00
|
|
|
int l1_start_index;
|
2010-03-23 17:28:22 +01:00
|
|
|
int i, ret;
|
2020-08-28 13:08:28 +02:00
|
|
|
int bufsize = MAX(L1E_SIZE,
|
2020-01-18 20:09:28 +01:00
|
|
|
MIN(bs->file->bs->bl.request_alignment, s->cluster_size));
|
2020-08-28 13:08:28 +02:00
|
|
|
int nentries = bufsize / L1E_SIZE;
|
2020-01-18 20:09:28 +01:00
|
|
|
g_autofree uint64_t *buf = g_try_new0(uint64_t, nentries);
|
2009-06-16 11:31:28 +02:00
|
|
|
|
2020-01-18 20:09:28 +01:00
|
|
|
if (buf == NULL) {
|
|
|
|
return -ENOMEM;
|
|
|
|
}
|
|
|
|
|
|
|
|
l1_start_index = QEMU_ALIGN_DOWN(l1_index, nentries);
|
|
|
|
for (i = 0; i < MIN(nentries, s->l1_size - l1_start_index); i++) {
|
2009-06-16 11:31:28 +02:00
|
|
|
buf[i] = cpu_to_be64(s->l1_table[l1_start_index + i]);
|
|
|
|
}
|
|
|
|
|
2013-10-10 11:09:23 +02:00
|
|
|
ret = qcow2_pre_write_overlap_check(bs, QCOW2_OL_ACTIVE_L1,
|
2020-09-28 18:23:33 +02:00
|
|
|
s->l1_table_offset + L1E_SIZE * l1_start_index, bufsize, false);
|
2013-08-30 14:34:26 +02:00
|
|
|
if (ret < 0) {
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2010-04-14 14:17:38 +02:00
|
|
|
BLKDBG_EVENT(bs->file, BLKDBG_L1_UPDATE);
|
2016-06-20 20:09:15 +02:00
|
|
|
ret = bdrv_pwrite_sync(bs->file,
|
2020-09-28 18:23:33 +02:00
|
|
|
s->l1_table_offset + L1E_SIZE * l1_start_index,
|
block: Change bdrv_{pread,pwrite,pwrite_sync}() param order
Swap 'buf' and 'bytes' around for consistency with
bdrv_co_{pread,pwrite}(), and in preparation to implement these
functions using generated_co_wrapper.
Callers were updated using this Coccinelle script:
@@ expression child, offset, buf, bytes, flags; @@
- bdrv_pread(child, offset, buf, bytes, flags)
+ bdrv_pread(child, offset, bytes, buf, flags)
@@ expression child, offset, buf, bytes, flags; @@
- bdrv_pwrite(child, offset, buf, bytes, flags)
+ bdrv_pwrite(child, offset, bytes, buf, flags)
@@ expression child, offset, buf, bytes, flags; @@
- bdrv_pwrite_sync(child, offset, buf, bytes, flags)
+ bdrv_pwrite_sync(child, offset, bytes, buf, flags)
Resulting overly-long lines were then fixed by hand.
Signed-off-by: Alberto Faria <afaria@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Message-Id: <20220609152744.3891847-3-afaria@redhat.com>
Reviewed-by: Hanna Reitz <hreitz@redhat.com>
Signed-off-by: Hanna Reitz <hreitz@redhat.com>
2022-06-09 17:27:36 +02:00
|
|
|
bufsize, buf, 0);
|
2010-03-23 17:28:22 +01:00
|
|
|
if (ret < 0) {
|
|
|
|
return ret;
|
2009-06-16 11:31:28 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2009-05-28 16:07:05 +02:00
|
|
|
/*
|
|
|
|
* l2_allocate
|
|
|
|
*
|
|
|
|
* Allocate a new l2 entry in the file. If l1_index points to an already
|
|
|
|
* used entry in the L2 table (i.e. we are doing a copy on write for the L2
|
|
|
|
* table) copy the contents of the old L2 table into the newly allocated one.
|
|
|
|
* Otherwise the new table is initialized with zeros.
|
|
|
|
*
|
|
|
|
*/
|
|
|
|
|
2023-09-29 16:51:49 +02:00
|
|
|
static int GRAPH_RDLOCK l2_allocate(BlockDriverState *bs, int l1_index)
|
2009-05-28 16:07:05 +02:00
|
|
|
{
|
2015-09-07 17:12:56 +02:00
|
|
|
BDRVQcow2State *s = bs->opaque;
|
2009-06-16 11:31:28 +02:00
|
|
|
uint64_t old_l2_offset;
|
2018-02-05 15:33:17 +01:00
|
|
|
uint64_t *l2_slice = NULL;
|
|
|
|
unsigned slice, slice_size2, n_slices;
|
2010-02-02 15:20:57 +01:00
|
|
|
int64_t l2_offset;
|
2010-03-23 17:41:24 +01:00
|
|
|
int ret;
|
2009-05-28 16:07:05 +02:00
|
|
|
|
|
|
|
old_l2_offset = s->l1_table[l1_index];
|
|
|
|
|
2012-03-01 18:36:21 +01:00
|
|
|
trace_qcow2_l2_allocate(bs, l1_index);
|
|
|
|
|
2009-05-28 16:07:05 +02:00
|
|
|
/* allocate a new l2 entry */
|
|
|
|
|
2020-07-10 18:12:54 +02:00
|
|
|
l2_offset = qcow2_alloc_clusters(bs, s->l2_size * l2_entry_size(s));
|
2010-01-20 15:04:01 +01:00
|
|
|
if (l2_offset < 0) {
|
2013-09-25 16:37:20 +02:00
|
|
|
ret = l2_offset;
|
|
|
|
goto fail;
|
2010-01-20 15:04:01 +01:00
|
|
|
}
|
2011-01-10 17:17:28 +01:00
|
|
|
|
2019-02-08 16:44:53 +01:00
|
|
|
/* The offset must fit in the offset field of the L1 table entry */
|
|
|
|
assert((l2_offset & L1E_OFFSET_MASK) == l2_offset);
|
|
|
|
|
2017-11-03 15:18:51 +01:00
|
|
|
/* If we're allocating the table at offset 0 then something is wrong */
|
|
|
|
if (l2_offset == 0) {
|
|
|
|
qcow2_signal_corruption(bs, true, -1, -1, "Preventing invalid "
|
|
|
|
"allocation of L2 table at offset 0");
|
|
|
|
ret = -EIO;
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
|
2011-01-10 17:17:28 +01:00
|
|
|
ret = qcow2_cache_flush(bs, s->refcount_block_cache);
|
|
|
|
if (ret < 0) {
|
|
|
|
goto fail;
|
|
|
|
}
|
2009-05-28 16:07:05 +02:00
|
|
|
|
|
|
|
/* allocate a new entry in the l2 cache */
|
|
|
|
|
2020-07-10 18:12:54 +02:00
|
|
|
slice_size2 = s->l2_slice_size * l2_entry_size(s);
|
2018-02-05 15:33:17 +01:00
|
|
|
n_slices = s->cluster_size / slice_size2;
|
|
|
|
|
2012-03-01 18:36:21 +01:00
|
|
|
trace_qcow2_l2_allocate_get_empty(bs, l1_index);
|
2018-02-05 15:33:17 +01:00
|
|
|
for (slice = 0; slice < n_slices; slice++) {
|
2018-02-05 15:33:16 +01:00
|
|
|
ret = qcow2_cache_get_empty(bs, s->l2_table_cache,
|
2018-02-05 15:33:17 +01:00
|
|
|
l2_offset + slice * slice_size2,
|
|
|
|
(void **) &l2_slice);
|
2018-02-05 15:33:16 +01:00
|
|
|
if (ret < 0) {
|
|
|
|
goto fail;
|
|
|
|
}
|
2011-01-10 17:17:28 +01:00
|
|
|
|
2018-02-05 15:33:16 +01:00
|
|
|
if ((old_l2_offset & L1E_OFFSET_MASK) == 0) {
|
2018-02-05 15:33:17 +01:00
|
|
|
/* if there was no old l2 table, clear the new slice */
|
|
|
|
memset(l2_slice, 0, slice_size2);
|
2018-02-05 15:33:16 +01:00
|
|
|
} else {
|
2018-02-05 15:33:17 +01:00
|
|
|
uint64_t *old_slice;
|
|
|
|
uint64_t old_l2_slice_offset =
|
|
|
|
(old_l2_offset & L1E_OFFSET_MASK) + slice * slice_size2;
|
2011-01-10 17:17:28 +01:00
|
|
|
|
2018-02-05 15:33:17 +01:00
|
|
|
/* if there was an old l2 table, read a slice from the disk */
|
2018-02-05 15:33:16 +01:00
|
|
|
BLKDBG_EVENT(bs->file, BLKDBG_L2_ALLOC_COW_READ);
|
2018-02-05 15:33:17 +01:00
|
|
|
ret = qcow2_cache_get(bs, s->l2_table_cache, old_l2_slice_offset,
|
|
|
|
(void **) &old_slice);
|
2018-02-05 15:33:16 +01:00
|
|
|
if (ret < 0) {
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
|
2018-02-05 15:33:17 +01:00
|
|
|
memcpy(l2_slice, old_slice, slice_size2);
|
2018-02-05 15:33:16 +01:00
|
|
|
|
2018-02-05 15:33:17 +01:00
|
|
|
qcow2_cache_put(s->l2_table_cache, (void **) &old_slice);
|
2011-01-10 17:17:28 +01:00
|
|
|
}
|
|
|
|
|
2018-02-05 15:33:17 +01:00
|
|
|
/* write the l2 slice to the file */
|
2018-02-05 15:33:16 +01:00
|
|
|
BLKDBG_EVENT(bs->file, BLKDBG_L2_ALLOC_WRITE);
|
2011-01-10 17:17:28 +01:00
|
|
|
|
2018-02-05 15:33:16 +01:00
|
|
|
trace_qcow2_l2_allocate_write_l2(bs, l1_index);
|
2018-02-05 15:33:17 +01:00
|
|
|
qcow2_cache_entry_mark_dirty(s->l2_table_cache, l2_slice);
|
|
|
|
qcow2_cache_put(s->l2_table_cache, (void **) &l2_slice);
|
2009-05-28 16:07:05 +02:00
|
|
|
}
|
2011-01-10 17:17:28 +01:00
|
|
|
|
|
|
|
ret = qcow2_cache_flush(bs, s->l2_table_cache);
|
2010-03-23 17:41:24 +01:00
|
|
|
if (ret < 0) {
|
2010-05-12 16:23:26 +02:00
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* update the L1 entry */
|
2012-03-01 18:36:21 +01:00
|
|
|
trace_qcow2_l2_allocate_write_l1(bs, l1_index);
|
2010-05-12 16:23:26 +02:00
|
|
|
s->l1_table[l1_index] = l2_offset | QCOW_OFLAG_COPIED;
|
2013-08-30 14:34:28 +02:00
|
|
|
ret = qcow2_write_l1_entry(bs, l1_index);
|
2010-05-12 16:23:26 +02:00
|
|
|
if (ret < 0) {
|
|
|
|
goto fail;
|
2010-03-23 17:41:24 +01:00
|
|
|
}
|
2009-05-28 16:07:05 +02:00
|
|
|
|
2012-03-01 18:36:21 +01:00
|
|
|
trace_qcow2_l2_allocate_done(bs, l1_index, 0);
|
2010-03-23 17:41:24 +01:00
|
|
|
return 0;
|
2010-05-12 16:23:26 +02:00
|
|
|
|
|
|
|
fail:
|
2012-03-01 18:36:21 +01:00
|
|
|
trace_qcow2_l2_allocate_done(bs, l1_index, ret);
|
2018-02-05 15:33:17 +01:00
|
|
|
if (l2_slice != NULL) {
|
|
|
|
qcow2_cache_put(s->l2_table_cache, (void **) &l2_slice);
|
2013-09-25 16:37:18 +02:00
|
|
|
}
|
2010-06-07 16:43:22 +02:00
|
|
|
s->l1_table[l1_index] = old_l2_offset;
|
2013-09-25 16:37:19 +02:00
|
|
|
if (l2_offset > 0) {
|
2020-07-10 18:12:54 +02:00
|
|
|
qcow2_free_clusters(bs, l2_offset, s->l2_size * l2_entry_size(s),
|
2013-09-25 16:37:19 +02:00
|
|
|
QCOW2_DISCARD_ALWAYS);
|
|
|
|
}
|
2010-05-12 16:23:26 +02:00
|
|
|
return ret;
|
2009-05-28 16:07:05 +02:00
|
|
|
}
|
|
|
|
|
2020-07-10 18:12:57 +02:00
|
|
|
/*
|
|
|
|
* For a given L2 entry, count the number of contiguous subclusters of
|
|
|
|
* the same type starting from @sc_from. Compressed clusters are
|
|
|
|
* treated as if they were divided into subclusters of size
|
|
|
|
* s->subcluster_size.
|
|
|
|
*
|
|
|
|
* Return the number of contiguous subclusters and set @type to the
|
|
|
|
* subcluster type.
|
|
|
|
*
|
|
|
|
* If the L2 entry is invalid return -errno and set @type to
|
|
|
|
* QCOW2_SUBCLUSTER_INVALID.
|
|
|
|
*/
|
2023-10-27 17:53:30 +02:00
|
|
|
static int GRAPH_RDLOCK
|
|
|
|
qcow2_get_subcluster_range_type(BlockDriverState *bs, uint64_t l2_entry,
|
|
|
|
uint64_t l2_bitmap, unsigned sc_from,
|
|
|
|
QCow2SubclusterType *type)
|
2020-07-10 18:12:57 +02:00
|
|
|
{
|
|
|
|
BDRVQcow2State *s = bs->opaque;
|
|
|
|
uint32_t val;
|
|
|
|
|
|
|
|
*type = qcow2_get_subcluster_type(bs, l2_entry, l2_bitmap, sc_from);
|
|
|
|
|
|
|
|
if (*type == QCOW2_SUBCLUSTER_INVALID) {
|
|
|
|
return -EINVAL;
|
|
|
|
} else if (!has_subclusters(s) || *type == QCOW2_SUBCLUSTER_COMPRESSED) {
|
|
|
|
return s->subclusters_per_cluster - sc_from;
|
|
|
|
}
|
|
|
|
|
|
|
|
switch (*type) {
|
|
|
|
case QCOW2_SUBCLUSTER_NORMAL:
|
|
|
|
val = l2_bitmap | QCOW_OFLAG_SUB_ALLOC_RANGE(0, sc_from);
|
|
|
|
return cto32(val) - sc_from;
|
|
|
|
|
|
|
|
case QCOW2_SUBCLUSTER_ZERO_PLAIN:
|
|
|
|
case QCOW2_SUBCLUSTER_ZERO_ALLOC:
|
|
|
|
val = (l2_bitmap | QCOW_OFLAG_SUB_ZERO_RANGE(0, sc_from)) >> 32;
|
|
|
|
return cto32(val) - sc_from;
|
|
|
|
|
|
|
|
case QCOW2_SUBCLUSTER_UNALLOCATED_PLAIN:
|
|
|
|
case QCOW2_SUBCLUSTER_UNALLOCATED_ALLOC:
|
|
|
|
val = ((l2_bitmap >> 32) | l2_bitmap)
|
|
|
|
& ~QCOW_OFLAG_SUB_ALLOC_RANGE(0, sc_from);
|
|
|
|
return ctz32(val) - sc_from;
|
|
|
|
|
|
|
|
default:
|
|
|
|
g_assert_not_reached();
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2012-03-15 16:37:40 +01:00
|
|
|
/*
|
2020-07-10 18:13:03 +02:00
|
|
|
* Return the number of contiguous subclusters of the exact same type
|
|
|
|
* in a given L2 slice, starting from cluster @l2_index, subcluster
|
|
|
|
* @sc_index. Allocated subclusters are required to be contiguous in
|
|
|
|
* the image file.
|
|
|
|
* At most @nb_clusters are checked (note that this means clusters,
|
|
|
|
* not subclusters).
|
|
|
|
* Compressed clusters are always processed one by one but for the
|
|
|
|
* purpose of this count they are treated as if they were divided into
|
|
|
|
* subclusters of size s->subcluster_size.
|
|
|
|
* On failure return -errno and update @l2_index to point to the
|
|
|
|
* invalid entry.
|
2012-03-15 16:37:40 +01:00
|
|
|
*/
|
2023-10-27 17:53:30 +02:00
|
|
|
static int GRAPH_RDLOCK
|
|
|
|
count_contiguous_subclusters(BlockDriverState *bs, int nb_clusters,
|
|
|
|
unsigned sc_index, uint64_t *l2_slice,
|
|
|
|
unsigned *l2_index)
|
2009-05-28 16:07:05 +02:00
|
|
|
{
|
2020-07-10 18:12:48 +02:00
|
|
|
BDRVQcow2State *s = bs->opaque;
|
2020-07-10 18:13:03 +02:00
|
|
|
int i, count = 0;
|
|
|
|
bool check_offset = false;
|
|
|
|
uint64_t expected_offset = 0;
|
|
|
|
QCow2SubclusterType expected_type = QCOW2_SUBCLUSTER_NORMAL, type;
|
2009-05-28 16:07:05 +02:00
|
|
|
|
2020-07-10 18:13:03 +02:00
|
|
|
assert(*l2_index + nb_clusters <= s->l2_slice_size);
|
2013-09-27 12:14:15 +02:00
|
|
|
|
2013-09-27 13:36:11 +02:00
|
|
|
for (i = 0; i < nb_clusters; i++) {
|
2020-07-10 18:13:03 +02:00
|
|
|
unsigned first_sc = (i == 0) ? sc_index : 0;
|
|
|
|
uint64_t l2_entry = get_l2_entry(s, l2_slice, *l2_index + i);
|
|
|
|
uint64_t l2_bitmap = get_l2_bitmap(s, l2_slice, *l2_index + i);
|
|
|
|
int ret = qcow2_get_subcluster_range_type(bs, l2_entry, l2_bitmap,
|
|
|
|
first_sc, &type);
|
|
|
|
if (ret < 0) {
|
|
|
|
*l2_index += i; /* Point to the invalid entry */
|
|
|
|
return -EIO;
|
|
|
|
}
|
|
|
|
if (i == 0) {
|
|
|
|
if (type == QCOW2_SUBCLUSTER_COMPRESSED) {
|
|
|
|
/* Compressed clusters are always processed one by one */
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
expected_type = type;
|
|
|
|
expected_offset = l2_entry & L2E_OFFSET_MASK;
|
|
|
|
check_offset = (type == QCOW2_SUBCLUSTER_NORMAL ||
|
|
|
|
type == QCOW2_SUBCLUSTER_ZERO_ALLOC ||
|
|
|
|
type == QCOW2_SUBCLUSTER_UNALLOCATED_ALLOC);
|
|
|
|
} else if (type != expected_type) {
|
2009-05-28 16:07:05 +02:00
|
|
|
break;
|
2020-07-10 18:13:03 +02:00
|
|
|
} else if (check_offset) {
|
|
|
|
expected_offset += s->cluster_size;
|
|
|
|
if (expected_offset != (l2_entry & L2E_OFFSET_MASK)) {
|
|
|
|
break;
|
|
|
|
}
|
2012-03-15 16:37:40 +01:00
|
|
|
}
|
2020-07-10 18:13:03 +02:00
|
|
|
count += ret;
|
|
|
|
/* Stop if there are type changes before the end of the cluster */
|
|
|
|
if (first_sc + ret < s->subclusters_per_cluster) {
|
2012-03-15 16:37:40 +01:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
2009-05-28 16:07:05 +02:00
|
|
|
|
2020-07-10 18:13:03 +02:00
|
|
|
return count;
|
2009-05-28 16:07:05 +02:00
|
|
|
}
|
|
|
|
|
2023-02-03 16:21:49 +01:00
|
|
|
static int coroutine_fn GRAPH_RDLOCK
|
|
|
|
do_perform_cow_read(BlockDriverState *bs, uint64_t src_cluster_offset,
|
|
|
|
unsigned offset_in_cluster, QEMUIOVector *qiov)
|
2009-05-28 16:07:05 +02:00
|
|
|
{
|
2016-06-01 15:21:05 +02:00
|
|
|
int ret;
|
2011-09-19 11:26:48 +02:00
|
|
|
|
2017-06-19 15:40:07 +02:00
|
|
|
if (qiov->size == 0) {
|
2017-06-19 15:40:04 +02:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2023-06-01 13:51:45 +02:00
|
|
|
BLKDBG_CO_EVENT(bs->file, BLKDBG_COW_READ);
|
2011-11-30 13:23:41 +01:00
|
|
|
|
2014-03-10 23:44:07 +01:00
|
|
|
if (!bs->drv) {
|
2017-06-19 15:40:05 +02:00
|
|
|
return -ENOMEDIUM;
|
2014-03-10 23:44:07 +01:00
|
|
|
}
|
|
|
|
|
block: use int64_t instead of uint64_t in driver read handlers
We are generally moving to int64_t for both offset and bytes parameters
on all io paths.
Main motivation is realization of 64-bit write_zeroes operation for
fast zeroing large disk chunks, up to the whole disk.
We chose signed type, to be consistent with off_t (which is signed) and
with possibility for signed return type (where negative value means
error).
So, convert driver read handlers parameters which are already 64bit to
signed type.
While being here, convert also flags parameter to be BdrvRequestFlags.
Now let's consider all callers. Simple
git grep '\->bdrv_\(aio\|co\)_preadv\(_part\)\?'
shows that's there three callers of driver function:
bdrv_driver_preadv() in block/io.c, passes int64_t, checked by
bdrv_check_qiov_request() to be non-negative.
qcow2_load_vmstate() does bdrv_check_qiov_request().
do_perform_cow_read() has uint64_t argument. And a lot of things in
qcow2 driver are uint64_t, so converting it is big job. But we must
not work with requests that don't satisfy bdrv_check_qiov_request(),
so let's just assert it here.
Still, the functions may be called directly, not only by drv->...
Let's check:
git grep '\.bdrv_\(aio\|co\)_preadv\(_part\)\?\s*=' | \
awk '{print $4}' | sed 's/,//' | sed 's/&//' | sort | uniq | \
while read func; do git grep "$func(" | \
grep -v "$func(BlockDriverState"; done
The only one such caller:
QEMUIOVector qiov = QEMU_IOVEC_INIT_BUF(qiov, &data, 1);
...
ret = bdrv_replace_test_co_preadv(bs, 0, 1, &qiov, 0);
in tests/unit/test-bdrv-drain.c, and it's OK obviously.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20210903102807.27127-4-vsementsov@virtuozzo.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
[eblake: fix typos]
Signed-off-by: Eric Blake <eblake@redhat.com>
2021-09-03 12:27:59 +02:00
|
|
|
/*
|
|
|
|
* We never deal with requests that don't satisfy
|
|
|
|
* bdrv_check_qiov_request(), and aligning requests to clusters never
|
|
|
|
* breaks this condition. So, do some assertions before calling
|
|
|
|
* bs->drv->bdrv_co_preadv_part() which has int64_t arguments.
|
|
|
|
*/
|
|
|
|
assert(src_cluster_offset <= INT64_MAX);
|
|
|
|
assert(src_cluster_offset + offset_in_cluster <= INT64_MAX);
|
2021-10-11 17:50:31 +02:00
|
|
|
/* Cast qiov->size to uint64_t to silence a compiler warning on -m32 */
|
|
|
|
assert((uint64_t)qiov->size <= INT64_MAX);
|
block: use int64_t instead of uint64_t in driver read handlers
We are generally moving to int64_t for both offset and bytes parameters
on all io paths.
Main motivation is realization of 64-bit write_zeroes operation for
fast zeroing large disk chunks, up to the whole disk.
We chose signed type, to be consistent with off_t (which is signed) and
with possibility for signed return type (where negative value means
error).
So, convert driver read handlers parameters which are already 64bit to
signed type.
While being here, convert also flags parameter to be BdrvRequestFlags.
Now let's consider all callers. Simple
git grep '\->bdrv_\(aio\|co\)_preadv\(_part\)\?'
shows that's there three callers of driver function:
bdrv_driver_preadv() in block/io.c, passes int64_t, checked by
bdrv_check_qiov_request() to be non-negative.
qcow2_load_vmstate() does bdrv_check_qiov_request().
do_perform_cow_read() has uint64_t argument. And a lot of things in
qcow2 driver are uint64_t, so converting it is big job. But we must
not work with requests that don't satisfy bdrv_check_qiov_request(),
so let's just assert it here.
Still, the functions may be called directly, not only by drv->...
Let's check:
git grep '\.bdrv_\(aio\|co\)_preadv\(_part\)\?\s*=' | \
awk '{print $4}' | sed 's/,//' | sed 's/&//' | sort | uniq | \
while read func; do git grep "$func(" | \
grep -v "$func(BlockDriverState"; done
The only one such caller:
QEMUIOVector qiov = QEMU_IOVEC_INIT_BUF(qiov, &data, 1);
...
ret = bdrv_replace_test_co_preadv(bs, 0, 1, &qiov, 0);
in tests/unit/test-bdrv-drain.c, and it's OK obviously.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20210903102807.27127-4-vsementsov@virtuozzo.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
[eblake: fix typos]
Signed-off-by: Eric Blake <eblake@redhat.com>
2021-09-03 12:27:59 +02:00
|
|
|
bdrv_check_qiov_request(src_cluster_offset + offset_in_cluster, qiov->size,
|
|
|
|
qiov, 0, &error_abort);
|
|
|
|
/*
|
|
|
|
* Call .bdrv_co_readv() directly instead of using the public block-layer
|
2011-11-30 13:23:41 +01:00
|
|
|
* interface. This avoids double I/O throttling and request tracking,
|
|
|
|
* which can lead to deadlock when block layer copy-on-read is enabled.
|
|
|
|
*/
|
2019-06-04 18:15:13 +02:00
|
|
|
ret = bs->drv->bdrv_co_preadv_part(bs,
|
|
|
|
src_cluster_offset + offset_in_cluster,
|
|
|
|
qiov->size, qiov, 0, 0);
|
2011-09-19 11:26:48 +02:00
|
|
|
if (ret < 0) {
|
2017-06-19 15:40:05 +02:00
|
|
|
return ret;
|
2011-09-19 11:26:48 +02:00
|
|
|
}
|
|
|
|
|
2017-06-19 15:40:05 +02:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2023-02-03 16:21:50 +01:00
|
|
|
static int coroutine_fn GRAPH_RDLOCK
|
|
|
|
do_perform_cow_write(BlockDriverState *bs, uint64_t cluster_offset,
|
|
|
|
unsigned offset_in_cluster, QEMUIOVector *qiov)
|
2017-06-19 15:40:05 +02:00
|
|
|
{
|
2019-01-15 20:39:06 +01:00
|
|
|
BDRVQcow2State *s = bs->opaque;
|
2017-06-19 15:40:05 +02:00
|
|
|
int ret;
|
|
|
|
|
2017-06-19 15:40:07 +02:00
|
|
|
if (qiov->size == 0) {
|
2017-06-19 15:40:05 +02:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2013-10-10 11:09:23 +02:00
|
|
|
ret = qcow2_pre_write_overlap_check(bs, 0,
|
2019-01-15 20:39:06 +01:00
|
|
|
cluster_offset + offset_in_cluster, qiov->size, true);
|
2013-08-30 14:34:26 +02:00
|
|
|
if (ret < 0) {
|
2017-06-19 15:40:05 +02:00
|
|
|
return ret;
|
2013-08-30 14:34:26 +02:00
|
|
|
}
|
|
|
|
|
2023-06-01 13:51:45 +02:00
|
|
|
BLKDBG_CO_EVENT(bs->file, BLKDBG_COW_WRITE);
|
2019-01-15 20:39:06 +01:00
|
|
|
ret = bdrv_co_pwritev(s->data_file, cluster_offset + offset_in_cluster,
|
2017-06-19 15:40:07 +02:00
|
|
|
qiov->size, qiov, 0);
|
2011-09-19 11:26:48 +02:00
|
|
|
if (ret < 0) {
|
2017-06-19 15:40:05 +02:00
|
|
|
return ret;
|
2011-09-19 11:26:48 +02:00
|
|
|
}
|
|
|
|
|
2017-06-19 15:40:05 +02:00
|
|
|
return 0;
|
2009-05-28 16:07:05 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
/*
|
2020-07-10 18:12:44 +02:00
|
|
|
* get_host_offset
|
2009-05-28 16:07:05 +02:00
|
|
|
*
|
2020-07-10 18:12:44 +02:00
|
|
|
* For a given offset of the virtual disk find the equivalent host
|
|
|
|
* offset in the qcow2 file and store it in *host_offset. Neither
|
|
|
|
* offset needs to be aligned to a cluster boundary.
|
|
|
|
*
|
|
|
|
* If the cluster is unallocated then *host_offset will be 0.
|
2021-09-14 14:24:46 +02:00
|
|
|
* If the cluster is compressed then *host_offset will contain the l2 entry.
|
2009-05-28 16:07:05 +02:00
|
|
|
*
|
2016-05-31 16:13:07 +02:00
|
|
|
* On entry, *bytes is the maximum number of contiguous bytes starting at
|
|
|
|
* offset that we are interested in.
|
2009-05-28 16:07:05 +02:00
|
|
|
*
|
2016-05-31 16:13:07 +02:00
|
|
|
* On exit, *bytes is the number of bytes starting at offset that have the same
|
2020-07-10 18:13:00 +02:00
|
|
|
* subcluster type and (if applicable) are stored contiguously in the image
|
|
|
|
* file. The subcluster type is stored in *subcluster_type.
|
|
|
|
* Compressed clusters are always processed one by one.
|
2009-05-28 16:07:05 +02:00
|
|
|
*
|
2020-07-10 18:12:59 +02:00
|
|
|
* Returns 0 on success, -errno in error cases.
|
2009-05-28 16:07:05 +02:00
|
|
|
*/
|
2020-07-10 18:12:44 +02:00
|
|
|
int qcow2_get_host_offset(BlockDriverState *bs, uint64_t offset,
|
2020-07-10 18:12:59 +02:00
|
|
|
unsigned int *bytes, uint64_t *host_offset,
|
2020-07-10 18:13:00 +02:00
|
|
|
QCow2SubclusterType *subcluster_type)
|
2009-05-28 16:07:05 +02:00
|
|
|
{
|
2015-09-07 17:12:56 +02:00
|
|
|
BDRVQcow2State *s = bs->opaque;
|
2020-07-10 18:13:03 +02:00
|
|
|
unsigned int l2_index, sc_index;
|
|
|
|
uint64_t l1_index, l2_offset, *l2_slice, l2_entry, l2_bitmap;
|
|
|
|
int sc;
|
2016-06-20 16:26:23 +02:00
|
|
|
unsigned int offset_in_cluster;
|
|
|
|
uint64_t bytes_available, bytes_needed, nb_clusters;
|
2020-07-10 18:13:03 +02:00
|
|
|
QCow2SubclusterType type;
|
2010-05-21 18:25:20 +02:00
|
|
|
int ret;
|
2009-05-28 16:07:05 +02:00
|
|
|
|
2016-05-31 16:41:09 +02:00
|
|
|
offset_in_cluster = offset_into_cluster(s, offset);
|
2016-05-31 16:13:07 +02:00
|
|
|
bytes_needed = (uint64_t) *bytes + offset_in_cluster;
|
2009-05-28 16:07:05 +02:00
|
|
|
|
2016-05-31 16:41:09 +02:00
|
|
|
/* compute how many bytes there are between the start of the cluster
|
2018-02-05 15:33:20 +01:00
|
|
|
* containing offset and the end of the l2 slice that contains
|
|
|
|
* the entry pointing to it */
|
|
|
|
bytes_available =
|
|
|
|
((uint64_t) (s->l2_slice_size - offset_to_l2_slice_index(s, offset)))
|
|
|
|
<< s->cluster_bits;
|
2009-05-28 16:07:05 +02:00
|
|
|
|
2016-05-31 16:41:09 +02:00
|
|
|
if (bytes_needed > bytes_available) {
|
|
|
|
bytes_needed = bytes_available;
|
2009-05-28 16:07:05 +02:00
|
|
|
}
|
|
|
|
|
2020-07-10 18:12:44 +02:00
|
|
|
*host_offset = 0;
|
2009-05-28 16:07:05 +02:00
|
|
|
|
2015-08-26 13:17:13 +02:00
|
|
|
/* seek to the l2 offset in the l1 table */
|
2009-05-28 16:07:05 +02:00
|
|
|
|
2018-02-05 15:33:12 +01:00
|
|
|
l1_index = offset_to_l1_index(s, offset);
|
2012-03-14 19:15:03 +01:00
|
|
|
if (l1_index >= s->l1_size) {
|
2020-07-10 18:13:03 +02:00
|
|
|
type = QCOW2_SUBCLUSTER_UNALLOCATED_PLAIN;
|
2009-05-28 16:07:05 +02:00
|
|
|
goto out;
|
2012-03-14 19:15:03 +01:00
|
|
|
}
|
2009-05-28 16:07:05 +02:00
|
|
|
|
2012-03-14 19:15:03 +01:00
|
|
|
l2_offset = s->l1_table[l1_index] & L1E_OFFSET_MASK;
|
|
|
|
if (!l2_offset) {
|
2020-07-10 18:13:03 +02:00
|
|
|
type = QCOW2_SUBCLUSTER_UNALLOCATED_PLAIN;
|
2009-05-28 16:07:05 +02:00
|
|
|
goto out;
|
2012-03-14 19:15:03 +01:00
|
|
|
}
|
2009-05-28 16:07:05 +02:00
|
|
|
|
2014-09-05 16:07:18 +02:00
|
|
|
if (offset_into_cluster(s, l2_offset)) {
|
|
|
|
qcow2_signal_corruption(bs, true, -1, -1, "L2 table offset %#" PRIx64
|
|
|
|
" unaligned (L1 index: %#" PRIx64 ")",
|
|
|
|
l2_offset, l1_index);
|
|
|
|
return -EIO;
|
|
|
|
}
|
|
|
|
|
2018-02-05 15:33:20 +01:00
|
|
|
/* load the l2 slice in memory */
|
2009-05-28 16:07:05 +02:00
|
|
|
|
2018-02-05 15:33:20 +01:00
|
|
|
ret = l2_load(bs, offset, l2_offset, &l2_slice);
|
2010-05-21 18:25:20 +02:00
|
|
|
if (ret < 0) {
|
|
|
|
return ret;
|
2010-05-21 17:59:36 +02:00
|
|
|
}
|
2009-05-28 16:07:05 +02:00
|
|
|
|
|
|
|
/* find the cluster offset for the given disk offset */
|
|
|
|
|
2018-02-05 15:33:20 +01:00
|
|
|
l2_index = offset_to_l2_slice_index(s, offset);
|
2020-07-10 18:13:03 +02:00
|
|
|
sc_index = offset_to_sc_index(s, offset);
|
2020-07-10 18:12:48 +02:00
|
|
|
l2_entry = get_l2_entry(s, l2_slice, l2_index);
|
2020-07-10 18:13:03 +02:00
|
|
|
l2_bitmap = get_l2_bitmap(s, l2_slice, l2_index);
|
2015-09-14 16:39:47 +02:00
|
|
|
|
2016-05-31 16:41:09 +02:00
|
|
|
nb_clusters = size_to_clusters(s, bytes_needed);
|
2016-06-20 16:26:23 +02:00
|
|
|
/* bytes_needed <= *bytes + offset_in_cluster, both of which are unsigned
|
|
|
|
* integers; the minimum cluster size is 512, so this assertion is always
|
|
|
|
* true */
|
|
|
|
assert(nb_clusters <= INT_MAX);
|
2009-05-28 16:07:05 +02:00
|
|
|
|
2020-07-10 18:13:03 +02:00
|
|
|
type = qcow2_get_subcluster_type(bs, l2_entry, l2_bitmap, sc_index);
|
|
|
|
if (s->qcow_version < 3 && (type == QCOW2_SUBCLUSTER_ZERO_PLAIN ||
|
|
|
|
type == QCOW2_SUBCLUSTER_ZERO_ALLOC)) {
|
2017-05-07 02:05:46 +02:00
|
|
|
qcow2_signal_corruption(bs, true, -1, -1, "Zero cluster entry found"
|
|
|
|
" in pre-v3 image (L2 offset: %#" PRIx64
|
|
|
|
", L2 index: %#x)", l2_offset, l2_index);
|
|
|
|
ret = -EIO;
|
|
|
|
goto fail;
|
|
|
|
}
|
2017-05-07 02:05:45 +02:00
|
|
|
switch (type) {
|
2020-07-10 18:13:03 +02:00
|
|
|
case QCOW2_SUBCLUSTER_INVALID:
|
|
|
|
break; /* This is handled by count_contiguous_subclusters() below */
|
|
|
|
case QCOW2_SUBCLUSTER_COMPRESSED:
|
2019-01-15 20:39:06 +01:00
|
|
|
if (has_data_file(bs)) {
|
|
|
|
qcow2_signal_corruption(bs, true, -1, -1, "Compressed cluster "
|
|
|
|
"entry found in image with external data "
|
|
|
|
"file (L2 offset: %#" PRIx64 ", L2 index: "
|
|
|
|
"%#x)", l2_offset, l2_index);
|
|
|
|
ret = -EIO;
|
|
|
|
goto fail;
|
|
|
|
}
|
2021-09-14 14:24:46 +02:00
|
|
|
*host_offset = l2_entry;
|
2012-03-14 19:15:03 +01:00
|
|
|
break;
|
2020-07-10 18:13:03 +02:00
|
|
|
case QCOW2_SUBCLUSTER_ZERO_PLAIN:
|
|
|
|
case QCOW2_SUBCLUSTER_UNALLOCATED_PLAIN:
|
2012-03-14 19:15:03 +01:00
|
|
|
break;
|
2020-07-10 18:13:03 +02:00
|
|
|
case QCOW2_SUBCLUSTER_ZERO_ALLOC:
|
|
|
|
case QCOW2_SUBCLUSTER_NORMAL:
|
|
|
|
case QCOW2_SUBCLUSTER_UNALLOCATED_ALLOC: {
|
2020-07-10 18:12:44 +02:00
|
|
|
uint64_t host_cluster_offset = l2_entry & L2E_OFFSET_MASK;
|
|
|
|
*host_offset = host_cluster_offset + offset_in_cluster;
|
|
|
|
if (offset_into_cluster(s, host_cluster_offset)) {
|
2017-05-07 02:05:46 +02:00
|
|
|
qcow2_signal_corruption(bs, true, -1, -1,
|
|
|
|
"Cluster allocation offset %#"
|
2014-09-05 16:07:18 +02:00
|
|
|
PRIx64 " unaligned (L2 offset: %#" PRIx64
|
2020-07-10 18:12:44 +02:00
|
|
|
", L2 index: %#x)", host_cluster_offset,
|
2014-09-05 16:07:18 +02:00
|
|
|
l2_offset, l2_index);
|
|
|
|
ret = -EIO;
|
|
|
|
goto fail;
|
|
|
|
}
|
2020-07-10 18:12:44 +02:00
|
|
|
if (has_data_file(bs) && *host_offset != offset) {
|
2019-01-15 20:39:06 +01:00
|
|
|
qcow2_signal_corruption(bs, true, -1, -1,
|
|
|
|
"External data file host cluster offset %#"
|
|
|
|
PRIx64 " does not match guest cluster "
|
|
|
|
"offset: %#" PRIx64
|
2020-07-10 18:12:44 +02:00
|
|
|
", L2 index: %#x)", host_cluster_offset,
|
2019-01-15 20:39:06 +01:00
|
|
|
offset - offset_in_cluster, l2_index);
|
|
|
|
ret = -EIO;
|
|
|
|
goto fail;
|
|
|
|
}
|
2012-03-14 19:15:03 +01:00
|
|
|
break;
|
2020-07-10 18:12:44 +02:00
|
|
|
}
|
2012-06-15 13:43:18 +02:00
|
|
|
default:
|
|
|
|
abort();
|
2009-05-28 16:07:05 +02:00
|
|
|
}
|
|
|
|
|
2020-07-10 18:13:03 +02:00
|
|
|
sc = count_contiguous_subclusters(bs, nb_clusters, sc_index,
|
|
|
|
l2_slice, &l2_index);
|
|
|
|
if (sc < 0) {
|
|
|
|
qcow2_signal_corruption(bs, true, -1, -1, "Invalid cluster entry found "
|
|
|
|
" (L2 offset: %#" PRIx64 ", L2 index: %#x)",
|
|
|
|
l2_offset, l2_index);
|
|
|
|
ret = -EIO;
|
|
|
|
goto fail;
|
|
|
|
}
|
2018-02-05 15:33:20 +01:00
|
|
|
qcow2_cache_put(s->l2_table_cache, (void **) &l2_slice);
|
2011-01-10 17:17:28 +01:00
|
|
|
|
2020-07-10 18:13:03 +02:00
|
|
|
bytes_available = ((int64_t)sc + sc_index) << s->subcluster_bits;
|
2012-03-14 19:15:03 +01:00
|
|
|
|
2009-05-28 16:07:05 +02:00
|
|
|
out:
|
2016-05-31 16:41:09 +02:00
|
|
|
if (bytes_available > bytes_needed) {
|
|
|
|
bytes_available = bytes_needed;
|
|
|
|
}
|
2009-05-28 16:07:05 +02:00
|
|
|
|
2016-06-20 16:26:23 +02:00
|
|
|
/* bytes_available <= bytes_needed <= *bytes + offset_in_cluster;
|
|
|
|
* subtracting offset_in_cluster will therefore definitely yield something
|
|
|
|
* not exceeding UINT_MAX */
|
|
|
|
assert(bytes_available - offset_in_cluster <= UINT_MAX);
|
2016-05-31 16:13:07 +02:00
|
|
|
*bytes = bytes_available - offset_in_cluster;
|
2009-05-28 16:07:05 +02:00
|
|
|
|
2020-07-10 18:13:03 +02:00
|
|
|
*subcluster_type = type;
|
2020-07-10 18:12:59 +02:00
|
|
|
|
|
|
|
return 0;
|
2014-09-05 16:07:18 +02:00
|
|
|
|
|
|
|
fail:
|
2018-02-05 15:33:20 +01:00
|
|
|
qcow2_cache_put(s->l2_table_cache, (void **)&l2_slice);
|
2014-09-05 16:07:18 +02:00
|
|
|
return ret;
|
2009-05-28 16:07:05 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* get_cluster_table
|
|
|
|
*
|
|
|
|
* for a given disk offset, load (and allocate if needed)
|
2018-02-05 15:33:19 +01:00
|
|
|
* the appropriate slice of its l2 table.
|
2009-05-28 16:07:05 +02:00
|
|
|
*
|
2018-02-05 15:33:19 +01:00
|
|
|
* the cluster index in the l2 slice is given to the caller.
|
2009-05-28 16:07:05 +02:00
|
|
|
*
|
2010-01-20 15:03:00 +01:00
|
|
|
* Returns 0 on success, -errno in failure case
|
2009-05-28 16:07:05 +02:00
|
|
|
*/
|
2023-09-29 16:51:49 +02:00
|
|
|
static int GRAPH_RDLOCK
|
|
|
|
get_cluster_table(BlockDriverState *bs, uint64_t offset,
|
|
|
|
uint64_t **new_l2_slice, int *new_l2_index)
|
2009-05-28 16:07:05 +02:00
|
|
|
{
|
2015-09-07 17:12:56 +02:00
|
|
|
BDRVQcow2State *s = bs->opaque;
|
2013-05-14 16:14:33 +02:00
|
|
|
unsigned int l2_index;
|
|
|
|
uint64_t l1_index, l2_offset;
|
2018-02-05 15:33:19 +01:00
|
|
|
uint64_t *l2_slice = NULL;
|
2009-09-15 12:30:43 +02:00
|
|
|
int ret;
|
2009-05-28 16:07:05 +02:00
|
|
|
|
2015-08-26 13:17:13 +02:00
|
|
|
/* seek to the l2 offset in the l1 table */
|
2009-05-28 16:07:05 +02:00
|
|
|
|
2018-02-05 15:33:12 +01:00
|
|
|
l1_index = offset_to_l1_index(s, offset);
|
2009-05-28 16:07:05 +02:00
|
|
|
if (l1_index >= s->l1_size) {
|
2010-10-18 17:53:53 +02:00
|
|
|
ret = qcow2_grow_l1_table(bs, l1_index + 1, false);
|
2010-01-20 15:03:00 +01:00
|
|
|
if (ret < 0) {
|
|
|
|
return ret;
|
|
|
|
}
|
2009-05-28 16:07:05 +02:00
|
|
|
}
|
2012-02-23 15:40:55 +01:00
|
|
|
|
2013-05-14 16:14:33 +02:00
|
|
|
assert(l1_index < s->l1_size);
|
2012-02-23 15:40:55 +01:00
|
|
|
l2_offset = s->l1_table[l1_index] & L1E_OFFSET_MASK;
|
2014-09-05 16:07:18 +02:00
|
|
|
if (offset_into_cluster(s, l2_offset)) {
|
|
|
|
qcow2_signal_corruption(bs, true, -1, -1, "L2 table offset %#" PRIx64
|
|
|
|
" unaligned (L1 index: %#" PRIx64 ")",
|
|
|
|
l2_offset, l1_index);
|
|
|
|
return -EIO;
|
|
|
|
}
|
2009-05-28 16:07:05 +02:00
|
|
|
|
2018-02-05 15:33:18 +01:00
|
|
|
if (!(s->l1_table[l1_index] & QCOW_OFLAG_COPIED)) {
|
2011-02-09 17:36:19 +01:00
|
|
|
/* First allocate a new L2 table (and do COW if needed) */
|
2018-02-05 15:33:17 +01:00
|
|
|
ret = l2_allocate(bs, l1_index);
|
2010-03-23 17:41:24 +01:00
|
|
|
if (ret < 0) {
|
|
|
|
return ret;
|
2010-01-20 15:03:00 +01:00
|
|
|
}
|
2011-02-09 17:36:19 +01:00
|
|
|
|
|
|
|
/* Then decrease the refcount of the old table */
|
|
|
|
if (l2_offset) {
|
2020-07-10 18:12:54 +02:00
|
|
|
qcow2_free_clusters(bs, l2_offset, s->l2_size * l2_entry_size(s),
|
2013-06-19 13:44:18 +02:00
|
|
|
QCOW2_DISCARD_OTHER);
|
2011-02-09 17:36:19 +01:00
|
|
|
}
|
2018-02-05 15:33:17 +01:00
|
|
|
|
|
|
|
/* Get the offset of the newly-allocated l2 table */
|
|
|
|
l2_offset = s->l1_table[l1_index] & L1E_OFFSET_MASK;
|
|
|
|
assert(offset_into_cluster(s, l2_offset) == 0);
|
2018-02-05 15:33:18 +01:00
|
|
|
}
|
|
|
|
|
2018-02-05 15:33:19 +01:00
|
|
|
/* load the l2 slice in memory */
|
|
|
|
ret = l2_load(bs, offset, l2_offset, &l2_slice);
|
2018-02-05 15:33:18 +01:00
|
|
|
if (ret < 0) {
|
|
|
|
return ret;
|
2009-05-28 16:07:05 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
/* find the cluster offset for the given disk offset */
|
|
|
|
|
2018-02-05 15:33:19 +01:00
|
|
|
l2_index = offset_to_l2_slice_index(s, offset);
|
2009-05-28 16:07:05 +02:00
|
|
|
|
2018-02-05 15:33:19 +01:00
|
|
|
*new_l2_slice = l2_slice;
|
2009-05-28 16:07:05 +02:00
|
|
|
*new_l2_index = l2_index;
|
|
|
|
|
2010-01-20 15:03:00 +01:00
|
|
|
return 0;
|
2009-05-28 16:07:05 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* alloc_compressed_cluster_offset
|
|
|
|
*
|
2019-02-27 10:26:24 +01:00
|
|
|
* For a given offset on the virtual disk, allocate a new compressed cluster
|
|
|
|
* and put the host offset of the cluster into *host_offset. If a cluster is
|
|
|
|
* already allocated at the offset, return an error.
|
2009-05-28 16:07:05 +02:00
|
|
|
*
|
2019-02-27 10:26:24 +01:00
|
|
|
* Return 0 on success and -errno in error cases
|
2009-05-28 16:07:05 +02:00
|
|
|
*/
|
2023-06-01 13:51:43 +02:00
|
|
|
int coroutine_fn GRAPH_RDLOCK
|
|
|
|
qcow2_alloc_compressed_cluster_offset(BlockDriverState *bs, uint64_t offset,
|
|
|
|
int compressed_size, uint64_t *host_offset)
|
2009-05-28 16:07:05 +02:00
|
|
|
{
|
2015-09-07 17:12:56 +02:00
|
|
|
BDRVQcow2State *s = bs->opaque;
|
2009-05-28 16:07:05 +02:00
|
|
|
int l2_index, ret;
|
2018-02-05 15:33:32 +01:00
|
|
|
uint64_t *l2_slice;
|
2010-02-02 15:20:57 +01:00
|
|
|
int64_t cluster_offset;
|
2009-05-28 16:07:05 +02:00
|
|
|
int nb_csectors;
|
|
|
|
|
2019-01-15 20:39:06 +01:00
|
|
|
if (has_data_file(bs)) {
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2018-02-05 15:33:32 +01:00
|
|
|
ret = get_cluster_table(bs, offset, &l2_slice, &l2_index);
|
2010-01-20 15:03:00 +01:00
|
|
|
if (ret < 0) {
|
2019-02-27 10:26:24 +01:00
|
|
|
return ret;
|
2010-01-20 15:03:00 +01:00
|
|
|
}
|
2009-05-28 16:07:05 +02:00
|
|
|
|
2012-03-15 17:20:11 +01:00
|
|
|
/* Compression can't overwrite anything. Fail if the cluster was already
|
|
|
|
* allocated. */
|
2020-07-10 18:12:48 +02:00
|
|
|
cluster_offset = get_l2_entry(s, l2_slice, l2_index);
|
2012-03-15 17:20:11 +01:00
|
|
|
if (cluster_offset & L2E_OFFSET_MASK) {
|
2018-02-05 15:33:32 +01:00
|
|
|
qcow2_cache_put(s->l2_table_cache, (void **) &l2_slice);
|
2019-02-27 10:26:24 +01:00
|
|
|
return -EIO;
|
2011-10-18 17:12:44 +02:00
|
|
|
}
|
2009-05-28 16:07:05 +02:00
|
|
|
|
2009-05-28 16:07:07 +02:00
|
|
|
cluster_offset = qcow2_alloc_bytes(bs, compressed_size);
|
2010-01-20 15:04:01 +01:00
|
|
|
if (cluster_offset < 0) {
|
2018-02-05 15:33:32 +01:00
|
|
|
qcow2_cache_put(s->l2_table_cache, (void **) &l2_slice);
|
2019-02-27 10:26:24 +01:00
|
|
|
return cluster_offset;
|
2010-01-20 15:04:01 +01:00
|
|
|
}
|
|
|
|
|
2019-05-10 18:22:54 +02:00
|
|
|
nb_csectors =
|
|
|
|
(cluster_offset + compressed_size - 1) / QCOW2_COMPRESSED_SECTOR_SIZE -
|
|
|
|
(cluster_offset / QCOW2_COMPRESSED_SECTOR_SIZE);
|
2009-05-28 16:07:05 +02:00
|
|
|
|
2020-01-13 17:11:46 +01:00
|
|
|
/* The offset and size must fit in their fields of the L2 table entry */
|
|
|
|
assert((cluster_offset & s->cluster_offset_mask) == cluster_offset);
|
|
|
|
assert((nb_csectors & s->csize_mask) == nb_csectors);
|
|
|
|
|
2009-05-28 16:07:05 +02:00
|
|
|
cluster_offset |= QCOW_OFLAG_COMPRESSED |
|
|
|
|
((uint64_t)nb_csectors << s->csize_shift);
|
|
|
|
|
|
|
|
/* update L2 table */
|
|
|
|
|
|
|
|
/* compressed clusters never have the copied flag */
|
|
|
|
|
2023-06-01 13:51:45 +02:00
|
|
|
BLKDBG_CO_EVENT(bs->file, BLKDBG_L2_UPDATE_COMPRESSED);
|
2018-02-05 15:33:32 +01:00
|
|
|
qcow2_cache_entry_mark_dirty(s->l2_table_cache, l2_slice);
|
2020-07-10 18:12:48 +02:00
|
|
|
set_l2_entry(s, l2_slice, l2_index, cluster_offset);
|
2020-07-10 18:13:08 +02:00
|
|
|
if (has_subclusters(s)) {
|
|
|
|
set_l2_bitmap(s, l2_slice, l2_index, 0);
|
|
|
|
}
|
2018-02-05 15:33:32 +01:00
|
|
|
qcow2_cache_put(s->l2_table_cache, (void **) &l2_slice);
|
2009-06-16 11:31:29 +02:00
|
|
|
|
2019-02-27 10:26:24 +01:00
|
|
|
*host_offset = cluster_offset & s->cluster_offset_mask;
|
|
|
|
return 0;
|
2009-06-16 11:31:29 +02:00
|
|
|
}
|
|
|
|
|
2023-02-03 16:21:49 +01:00
|
|
|
static int coroutine_fn GRAPH_RDLOCK
|
|
|
|
perform_cow(BlockDriverState *bs, QCowL2Meta *m)
|
2012-12-07 18:08:43 +01:00
|
|
|
{
|
2015-09-07 17:12:56 +02:00
|
|
|
BDRVQcow2State *s = bs->opaque;
|
2017-06-19 15:40:04 +02:00
|
|
|
Qcow2COWRegion *start = &m->cow_start;
|
|
|
|
Qcow2COWRegion *end = &m->cow_end;
|
2017-06-19 15:40:05 +02:00
|
|
|
unsigned buffer_size;
|
2017-06-19 15:40:06 +02:00
|
|
|
unsigned data_bytes = end->offset - (start->offset + start->nb_bytes);
|
|
|
|
bool merge_reads;
|
2017-06-19 15:40:05 +02:00
|
|
|
uint8_t *start_buffer, *end_buffer;
|
2017-06-19 15:40:07 +02:00
|
|
|
QEMUIOVector qiov;
|
2012-12-07 18:08:43 +01:00
|
|
|
int ret;
|
|
|
|
|
2017-06-19 15:40:05 +02:00
|
|
|
assert(start->nb_bytes <= UINT_MAX - end->nb_bytes);
|
2017-06-19 15:40:06 +02:00
|
|
|
assert(start->nb_bytes + end->nb_bytes <= UINT_MAX - data_bytes);
|
|
|
|
assert(start->offset + start->nb_bytes <= end->offset);
|
2017-06-19 15:40:05 +02:00
|
|
|
|
2019-05-16 16:27:49 +02:00
|
|
|
if ((start->nb_bytes == 0 && end->nb_bytes == 0) || m->skip_cow) {
|
2012-12-07 18:08:43 +01:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2017-06-19 15:40:06 +02:00
|
|
|
/* If we have to read both the start and end COW regions and the
|
|
|
|
* middle region is not too large then perform just one read
|
|
|
|
* operation */
|
|
|
|
merge_reads = start->nb_bytes && end->nb_bytes && data_bytes <= 16384;
|
|
|
|
if (merge_reads) {
|
|
|
|
buffer_size = start->nb_bytes + data_bytes + end->nb_bytes;
|
|
|
|
} else {
|
|
|
|
/* If we have to do two reads, add some padding in the middle
|
|
|
|
* if necessary to make sure that the end region is optimally
|
|
|
|
* aligned. */
|
|
|
|
size_t align = bdrv_opt_mem_align(bs);
|
|
|
|
assert(align > 0 && align <= UINT_MAX);
|
|
|
|
assert(QEMU_ALIGN_UP(start->nb_bytes, align) <=
|
|
|
|
UINT_MAX - end->nb_bytes);
|
|
|
|
buffer_size = QEMU_ALIGN_UP(start->nb_bytes, align) + end->nb_bytes;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Reserve a buffer large enough to store all the data that we're
|
|
|
|
* going to read */
|
2017-06-19 15:40:05 +02:00
|
|
|
start_buffer = qemu_try_blockalign(bs, buffer_size);
|
|
|
|
if (start_buffer == NULL) {
|
|
|
|
return -ENOMEM;
|
|
|
|
}
|
|
|
|
/* The part of the buffer where the end region is located */
|
|
|
|
end_buffer = start_buffer + buffer_size - end->nb_bytes;
|
|
|
|
|
2019-06-04 18:15:14 +02:00
|
|
|
qemu_iovec_init(&qiov, 2 + (m->data_qiov ?
|
|
|
|
qemu_iovec_subvec_niov(m->data_qiov,
|
|
|
|
m->data_qiov_offset,
|
|
|
|
data_bytes)
|
|
|
|
: 0));
|
2017-06-19 15:40:07 +02:00
|
|
|
|
2012-12-07 18:08:43 +01:00
|
|
|
qemu_co_mutex_unlock(&s->lock);
|
2017-06-19 15:40:06 +02:00
|
|
|
/* First we read the existing data from both COW regions. We
|
|
|
|
* either read the whole region in one go, or the start and end
|
|
|
|
* regions separately. */
|
|
|
|
if (merge_reads) {
|
2017-06-19 15:40:07 +02:00
|
|
|
qemu_iovec_add(&qiov, start_buffer, buffer_size);
|
|
|
|
ret = do_perform_cow_read(bs, m->offset, start->offset, &qiov);
|
2017-06-19 15:40:06 +02:00
|
|
|
} else {
|
2017-06-19 15:40:07 +02:00
|
|
|
qemu_iovec_add(&qiov, start_buffer, start->nb_bytes);
|
|
|
|
ret = do_perform_cow_read(bs, m->offset, start->offset, &qiov);
|
2017-06-19 15:40:06 +02:00
|
|
|
if (ret < 0) {
|
|
|
|
goto fail;
|
|
|
|
}
|
2017-06-19 15:40:05 +02:00
|
|
|
|
2017-06-19 15:40:07 +02:00
|
|
|
qemu_iovec_reset(&qiov);
|
|
|
|
qemu_iovec_add(&qiov, end_buffer, end->nb_bytes);
|
|
|
|
ret = do_perform_cow_read(bs, m->offset, end->offset, &qiov);
|
2017-06-19 15:40:06 +02:00
|
|
|
}
|
2012-12-07 18:08:43 +01:00
|
|
|
if (ret < 0) {
|
2017-06-19 15:40:04 +02:00
|
|
|
goto fail;
|
2012-12-07 18:08:43 +01:00
|
|
|
}
|
|
|
|
|
2017-06-19 15:40:05 +02:00
|
|
|
/* Encrypt the data if necessary before writing it */
|
|
|
|
if (bs->encrypted) {
|
2019-09-15 22:36:54 +02:00
|
|
|
ret = qcow2_co_encrypt(bs,
|
|
|
|
m->alloc_offset + start->offset,
|
|
|
|
m->offset + start->offset,
|
|
|
|
start_buffer, start->nb_bytes);
|
|
|
|
if (ret < 0) {
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
|
|
|
|
ret = qcow2_co_encrypt(bs,
|
|
|
|
m->alloc_offset + end->offset,
|
|
|
|
m->offset + end->offset,
|
|
|
|
end_buffer, end->nb_bytes);
|
|
|
|
if (ret < 0) {
|
2017-06-19 15:40:05 +02:00
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2017-06-19 15:40:08 +02:00
|
|
|
/* And now we can write everything. If we have the guest data we
|
|
|
|
* can write everything in one single operation */
|
|
|
|
if (m->data_qiov) {
|
|
|
|
qemu_iovec_reset(&qiov);
|
|
|
|
if (start->nb_bytes) {
|
|
|
|
qemu_iovec_add(&qiov, start_buffer, start->nb_bytes);
|
|
|
|
}
|
2019-06-04 18:15:14 +02:00
|
|
|
qemu_iovec_concat(&qiov, m->data_qiov, m->data_qiov_offset, data_bytes);
|
2017-06-19 15:40:08 +02:00
|
|
|
if (end->nb_bytes) {
|
|
|
|
qemu_iovec_add(&qiov, end_buffer, end->nb_bytes);
|
|
|
|
}
|
|
|
|
/* NOTE: we have a write_aio blkdebug event here followed by
|
|
|
|
* a cow_write one in do_perform_cow_write(), but there's only
|
|
|
|
* one single I/O operation */
|
2023-06-01 13:51:45 +02:00
|
|
|
BLKDBG_CO_EVENT(bs->file, BLKDBG_WRITE_AIO);
|
2017-06-19 15:40:08 +02:00
|
|
|
ret = do_perform_cow_write(bs, m->alloc_offset, start->offset, &qiov);
|
|
|
|
} else {
|
|
|
|
/* If there's no guest data then write both COW regions separately */
|
|
|
|
qemu_iovec_reset(&qiov);
|
|
|
|
qemu_iovec_add(&qiov, start_buffer, start->nb_bytes);
|
|
|
|
ret = do_perform_cow_write(bs, m->alloc_offset, start->offset, &qiov);
|
|
|
|
if (ret < 0) {
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
|
|
|
|
qemu_iovec_reset(&qiov);
|
|
|
|
qemu_iovec_add(&qiov, end_buffer, end->nb_bytes);
|
|
|
|
ret = do_perform_cow_write(bs, m->alloc_offset, end->offset, &qiov);
|
2017-06-19 15:40:05 +02:00
|
|
|
}
|
2017-06-19 15:40:04 +02:00
|
|
|
|
|
|
|
fail:
|
|
|
|
qemu_co_mutex_lock(&s->lock);
|
|
|
|
|
2012-12-07 18:08:43 +01:00
|
|
|
/*
|
|
|
|
* Before we update the L2 table to actually point to the new cluster, we
|
|
|
|
* need to be sure that the refcounts have been increased and COW was
|
|
|
|
* handled.
|
|
|
|
*/
|
2017-06-19 15:40:04 +02:00
|
|
|
if (ret == 0) {
|
|
|
|
qcow2_cache_depends_on_flush(s->l2_table_cache);
|
|
|
|
}
|
2012-12-07 18:08:43 +01:00
|
|
|
|
2017-06-19 15:40:05 +02:00
|
|
|
qemu_vfree(start_buffer);
|
2017-06-19 15:40:07 +02:00
|
|
|
qemu_iovec_destroy(&qiov);
|
2017-06-19 15:40:04 +02:00
|
|
|
return ret;
|
2012-12-07 18:08:43 +01:00
|
|
|
}
|
|
|
|
|
2022-09-22 10:49:12 +02:00
|
|
|
int coroutine_fn qcow2_alloc_cluster_link_l2(BlockDriverState *bs,
|
|
|
|
QCowL2Meta *m)
|
2009-05-28 16:07:05 +02:00
|
|
|
{
|
2015-09-07 17:12:56 +02:00
|
|
|
BDRVQcow2State *s = bs->opaque;
|
2009-05-28 16:07:05 +02:00
|
|
|
int i, j = 0, l2_index, ret;
|
2018-02-05 15:33:21 +01:00
|
|
|
uint64_t *old_cluster, *l2_slice;
|
2012-03-02 14:10:54 +01:00
|
|
|
uint64_t cluster_offset = m->alloc_offset;
|
2009-05-28 16:07:05 +02:00
|
|
|
|
2012-03-01 18:36:21 +01:00
|
|
|
trace_qcow2_cluster_link_l2(qemu_coroutine_self(), m->nb_clusters);
|
2012-12-07 18:08:46 +01:00
|
|
|
assert(m->nb_clusters > 0);
|
2009-05-28 16:07:05 +02:00
|
|
|
|
block: Use g_new() & friends where that makes obvious sense
g_new(T, n) is neater than g_malloc(sizeof(T) * n). It's also safer,
for two reasons. One, it catches multiplication overflowing size_t.
Two, it returns T * rather than void *, which lets the compiler catch
more type errors.
Patch created with Coccinelle, with two manual changes on top:
* Add const to bdrv_iterate_format() to keep the types straight
* Convert the allocation in bdrv_drop_intermediate(), which Coccinelle
inexplicably misses
Coccinelle semantic patch:
@@
type T;
@@
-g_malloc(sizeof(T))
+g_new(T, 1)
@@
type T;
@@
-g_try_malloc(sizeof(T))
+g_try_new(T, 1)
@@
type T;
@@
-g_malloc0(sizeof(T))
+g_new0(T, 1)
@@
type T;
@@
-g_try_malloc0(sizeof(T))
+g_try_new0(T, 1)
@@
type T;
expression n;
@@
-g_malloc(sizeof(T) * (n))
+g_new(T, n)
@@
type T;
expression n;
@@
-g_try_malloc(sizeof(T) * (n))
+g_try_new(T, n)
@@
type T;
expression n;
@@
-g_malloc0(sizeof(T) * (n))
+g_new0(T, n)
@@
type T;
expression n;
@@
-g_try_malloc0(sizeof(T) * (n))
+g_try_new0(T, n)
@@
type T;
expression p, n;
@@
-g_realloc(p, sizeof(T) * (n))
+g_renew(T, p, n)
@@
type T;
expression p, n;
@@
-g_try_realloc(p, sizeof(T) * (n))
+g_try_renew(T, p, n)
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Jeff Cody <jcody@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2014-08-19 10:31:08 +02:00
|
|
|
old_cluster = g_try_new(uint64_t, m->nb_clusters);
|
2014-05-20 17:12:47 +02:00
|
|
|
if (old_cluster == NULL) {
|
|
|
|
ret = -ENOMEM;
|
|
|
|
goto err;
|
|
|
|
}
|
2009-05-28 16:07:05 +02:00
|
|
|
|
|
|
|
/* copy content of unmodified sectors */
|
2017-06-19 15:40:04 +02:00
|
|
|
ret = perform_cow(bs, m);
|
2012-12-07 18:08:43 +01:00
|
|
|
if (ret < 0) {
|
|
|
|
goto err;
|
2011-01-10 17:17:28 +01:00
|
|
|
}
|
|
|
|
|
2012-12-07 18:08:43 +01:00
|
|
|
/* Update L2 table. */
|
2013-03-15 10:35:08 +01:00
|
|
|
if (s->use_lazy_refcounts) {
|
2012-12-07 18:08:47 +01:00
|
|
|
qcow2_mark_dirty(bs);
|
|
|
|
}
|
2012-07-27 10:05:22 +02:00
|
|
|
if (qcow2_need_accurate_refcounts(s)) {
|
|
|
|
qcow2_cache_set_dependency(bs, s->l2_table_cache,
|
|
|
|
s->refcount_block_cache);
|
|
|
|
}
|
2012-12-07 18:08:47 +01:00
|
|
|
|
2018-02-05 15:33:21 +01:00
|
|
|
ret = get_cluster_table(bs, m->offset, &l2_slice, &l2_index);
|
2010-01-20 15:03:00 +01:00
|
|
|
if (ret < 0) {
|
2009-05-28 16:07:05 +02:00
|
|
|
goto err;
|
2010-01-20 15:03:00 +01:00
|
|
|
}
|
2018-02-05 15:33:21 +01:00
|
|
|
qcow2_cache_entry_mark_dirty(s->l2_table_cache, l2_slice);
|
2009-05-28 16:07:05 +02:00
|
|
|
|
2018-02-05 15:33:21 +01:00
|
|
|
assert(l2_index + m->nb_clusters <= s->l2_slice_size);
|
2020-10-07 18:13:23 +02:00
|
|
|
assert(m->cow_end.offset + m->cow_end.nb_bytes <=
|
|
|
|
m->nb_clusters << s->cluster_bits);
|
2009-05-28 16:07:05 +02:00
|
|
|
for (i = 0; i < m->nb_clusters; i++) {
|
2020-08-05 11:22:58 +02:00
|
|
|
uint64_t offset = cluster_offset + ((uint64_t)i << s->cluster_bits);
|
2009-05-28 16:07:05 +02:00
|
|
|
/* if two concurrent writes happen to the same unallocated cluster
|
2016-06-01 15:21:05 +02:00
|
|
|
* each write allocates separate cluster and writes data concurrently.
|
|
|
|
* The first one to complete updates l2 table with pointer to its
|
|
|
|
* cluster the second one has to do RMW (which is done above by
|
|
|
|
* perform_cow()), update l2 table with its cluster pointer and free
|
|
|
|
* old cluster. This is what this loop does */
|
2020-07-10 18:12:48 +02:00
|
|
|
if (get_l2_entry(s, l2_slice, l2_index + i) != 0) {
|
|
|
|
old_cluster[j++] = get_l2_entry(s, l2_slice, l2_index + i);
|
2016-06-01 15:21:05 +02:00
|
|
|
}
|
2009-05-28 16:07:05 +02:00
|
|
|
|
2020-01-13 17:11:46 +01:00
|
|
|
/* The offset must fit in the offset field of the L2 table entry */
|
|
|
|
assert((offset & L2E_OFFSET_MASK) == offset);
|
|
|
|
|
2020-07-10 18:12:48 +02:00
|
|
|
set_l2_entry(s, l2_slice, l2_index + i, offset | QCOW_OFLAG_COPIED);
|
2020-07-10 18:13:07 +02:00
|
|
|
|
|
|
|
/* Update bitmap with the subclusters that were just written */
|
2020-07-10 18:13:12 +02:00
|
|
|
if (has_subclusters(s) && !m->prealloc) {
|
2020-07-10 18:13:07 +02:00
|
|
|
uint64_t l2_bitmap = get_l2_bitmap(s, l2_slice, l2_index + i);
|
|
|
|
unsigned written_from = m->cow_start.offset;
|
2020-10-07 18:13:23 +02:00
|
|
|
unsigned written_to = m->cow_end.offset + m->cow_end.nb_bytes;
|
2020-07-10 18:13:07 +02:00
|
|
|
int first_sc, last_sc;
|
|
|
|
/* Narrow written_from and written_to down to the current cluster */
|
|
|
|
written_from = MAX(written_from, i << s->cluster_bits);
|
|
|
|
written_to = MIN(written_to, (i + 1) << s->cluster_bits);
|
|
|
|
assert(written_from < written_to);
|
|
|
|
first_sc = offset_to_sc_index(s, written_from);
|
|
|
|
last_sc = offset_to_sc_index(s, written_to - 1);
|
|
|
|
l2_bitmap |= QCOW_OFLAG_SUB_ALLOC_RANGE(first_sc, last_sc + 1);
|
|
|
|
l2_bitmap &= ~QCOW_OFLAG_SUB_ZERO_RANGE(first_sc, last_sc + 1);
|
|
|
|
set_l2_bitmap(s, l2_slice, l2_index + i, l2_bitmap);
|
|
|
|
}
|
2009-05-28 16:07:05 +02:00
|
|
|
}
|
|
|
|
|
2010-09-17 17:02:09 +02:00
|
|
|
|
2018-02-05 15:33:21 +01:00
|
|
|
qcow2_cache_put(s->l2_table_cache, (void **) &l2_slice);
|
2009-05-28 16:07:05 +02:00
|
|
|
|
2010-09-01 12:40:52 +02:00
|
|
|
/*
|
|
|
|
* If this was a COW, we need to decrease the refcount of the old cluster.
|
2013-06-19 13:44:18 +02:00
|
|
|
*
|
|
|
|
* Don't discard clusters that reach a refcount of 0 (e.g. compressed
|
|
|
|
* clusters), the next write will reuse them anyway.
|
2010-09-01 12:40:52 +02:00
|
|
|
*/
|
2017-05-04 01:11:18 +02:00
|
|
|
if (!m->keep_old_clusters && j != 0) {
|
2010-09-01 12:40:52 +02:00
|
|
|
for (i = 0; i < j; i++) {
|
2020-09-08 16:08:28 +02:00
|
|
|
qcow2_free_any_cluster(bs, old_cluster[i], QCOW2_DISCARD_NEVER);
|
2010-09-01 12:40:52 +02:00
|
|
|
}
|
|
|
|
}
|
2009-05-28 16:07:05 +02:00
|
|
|
|
|
|
|
ret = 0;
|
|
|
|
err:
|
2011-08-21 05:09:37 +02:00
|
|
|
g_free(old_cluster);
|
2009-05-28 16:07:05 +02:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2018-06-28 17:05:45 +02:00
|
|
|
/**
|
|
|
|
* Frees the allocated clusters because the request failed and they won't
|
|
|
|
* actually be linked.
|
|
|
|
*/
|
2023-03-09 09:44:55 +01:00
|
|
|
void coroutine_fn qcow2_alloc_cluster_abort(BlockDriverState *bs, QCowL2Meta *m)
|
2018-06-28 17:05:45 +02:00
|
|
|
{
|
|
|
|
BDRVQcow2State *s = bs->opaque;
|
2020-02-25 15:31:28 +01:00
|
|
|
if (!has_data_file(bs) && !m->keep_old_clusters) {
|
2020-02-11 10:48:59 +01:00
|
|
|
qcow2_free_clusters(bs, m->alloc_offset,
|
|
|
|
m->nb_clusters << s->cluster_bits,
|
|
|
|
QCOW2_DISCARD_NEVER);
|
|
|
|
}
|
2018-06-28 17:05:45 +02:00
|
|
|
}
|
|
|
|
|
2020-07-10 18:12:45 +02:00
|
|
|
/*
|
|
|
|
* For a given write request, create a new QCowL2Meta structure, add
|
2020-07-10 18:12:47 +02:00
|
|
|
* it to @m and the BDRVQcow2State.cluster_allocs list. If the write
|
|
|
|
* request does not need copy-on-write or changes to the L2 metadata
|
|
|
|
* then this function does nothing.
|
2020-07-10 18:12:45 +02:00
|
|
|
*
|
|
|
|
* @host_cluster_offset points to the beginning of the first cluster.
|
|
|
|
*
|
|
|
|
* @guest_offset and @bytes indicate the offset and length of the
|
|
|
|
* request.
|
|
|
|
*
|
2020-07-10 18:12:47 +02:00
|
|
|
* @l2_slice contains the L2 entries of all clusters involved in this
|
|
|
|
* write request.
|
|
|
|
*
|
2020-07-10 18:12:45 +02:00
|
|
|
* If @keep_old is true it means that the clusters were already
|
|
|
|
* allocated and will be overwritten. If false then the clusters are
|
|
|
|
* new and we have to decrease the reference count of the old ones.
|
2020-07-10 18:13:02 +02:00
|
|
|
*
|
|
|
|
* Returns 0 on success, -errno on failure.
|
2020-07-10 18:12:45 +02:00
|
|
|
*/
|
2023-09-29 16:51:49 +02:00
|
|
|
static int coroutine_fn GRAPH_RDLOCK
|
|
|
|
calculate_l2_meta(BlockDriverState *bs, uint64_t host_cluster_offset,
|
|
|
|
uint64_t guest_offset, unsigned bytes, uint64_t *l2_slice,
|
|
|
|
QCowL2Meta **m, bool keep_old)
|
2020-07-10 18:12:45 +02:00
|
|
|
{
|
|
|
|
BDRVQcow2State *s = bs->opaque;
|
2020-07-10 18:13:02 +02:00
|
|
|
int sc_index, l2_index = offset_to_l2_slice_index(s, guest_offset);
|
|
|
|
uint64_t l2_entry, l2_bitmap;
|
2020-07-10 18:12:47 +02:00
|
|
|
unsigned cow_start_from, cow_end_to;
|
2020-07-10 18:12:45 +02:00
|
|
|
unsigned cow_start_to = offset_into_cluster(s, guest_offset);
|
|
|
|
unsigned cow_end_from = cow_start_to + bytes;
|
|
|
|
unsigned nb_clusters = size_to_clusters(s, cow_end_from);
|
|
|
|
QCowL2Meta *old_m = *m;
|
2020-07-10 18:13:02 +02:00
|
|
|
QCow2SubclusterType type;
|
|
|
|
int i;
|
|
|
|
bool skip_cow = keep_old;
|
2020-07-10 18:12:47 +02:00
|
|
|
|
|
|
|
assert(nb_clusters <= s->l2_slice_size - l2_index);
|
|
|
|
|
2020-07-10 18:13:02 +02:00
|
|
|
/* Check the type of all affected subclusters */
|
|
|
|
for (i = 0; i < nb_clusters; i++) {
|
|
|
|
l2_entry = get_l2_entry(s, l2_slice, l2_index + i);
|
|
|
|
l2_bitmap = get_l2_bitmap(s, l2_slice, l2_index + i);
|
|
|
|
if (skip_cow) {
|
|
|
|
unsigned write_from = MAX(cow_start_to, i << s->cluster_bits);
|
|
|
|
unsigned write_to = MIN(cow_end_from, (i + 1) << s->cluster_bits);
|
|
|
|
int first_sc = offset_to_sc_index(s, write_from);
|
|
|
|
int last_sc = offset_to_sc_index(s, write_to - 1);
|
|
|
|
int cnt = qcow2_get_subcluster_range_type(bs, l2_entry, l2_bitmap,
|
|
|
|
first_sc, &type);
|
|
|
|
/* Is any of the subclusters of type != QCOW2_SUBCLUSTER_NORMAL ? */
|
|
|
|
if (type != QCOW2_SUBCLUSTER_NORMAL || first_sc + cnt <= last_sc) {
|
|
|
|
skip_cow = false;
|
2020-07-10 18:12:47 +02:00
|
|
|
}
|
2020-07-10 18:13:02 +02:00
|
|
|
} else {
|
|
|
|
/* If we can't skip the cow we can still look for invalid entries */
|
|
|
|
type = qcow2_get_subcluster_type(bs, l2_entry, l2_bitmap, 0);
|
2020-07-10 18:12:47 +02:00
|
|
|
}
|
2020-07-10 18:13:02 +02:00
|
|
|
if (type == QCOW2_SUBCLUSTER_INVALID) {
|
|
|
|
int l1_index = offset_to_l1_index(s, guest_offset);
|
|
|
|
uint64_t l2_offset = s->l1_table[l1_index] & L1E_OFFSET_MASK;
|
|
|
|
qcow2_signal_corruption(bs, true, -1, -1, "Invalid cluster "
|
|
|
|
"entry found (L2 offset: %#" PRIx64
|
|
|
|
", L2 index: %#x)",
|
|
|
|
l2_offset, l2_index + i);
|
|
|
|
return -EIO;
|
2020-07-10 18:12:47 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2020-07-10 18:13:02 +02:00
|
|
|
if (skip_cow) {
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2020-07-10 18:12:47 +02:00
|
|
|
/* Get the L2 entry of the first cluster */
|
2020-07-10 18:12:48 +02:00
|
|
|
l2_entry = get_l2_entry(s, l2_slice, l2_index);
|
2020-07-10 18:13:02 +02:00
|
|
|
l2_bitmap = get_l2_bitmap(s, l2_slice, l2_index);
|
|
|
|
sc_index = offset_to_sc_index(s, guest_offset);
|
|
|
|
type = qcow2_get_subcluster_type(bs, l2_entry, l2_bitmap, sc_index);
|
|
|
|
|
|
|
|
if (!keep_old) {
|
|
|
|
switch (type) {
|
|
|
|
case QCOW2_SUBCLUSTER_COMPRESSED:
|
|
|
|
cow_start_from = 0;
|
|
|
|
break;
|
|
|
|
case QCOW2_SUBCLUSTER_NORMAL:
|
|
|
|
case QCOW2_SUBCLUSTER_ZERO_ALLOC:
|
|
|
|
case QCOW2_SUBCLUSTER_UNALLOCATED_ALLOC:
|
|
|
|
if (has_subclusters(s)) {
|
|
|
|
/* Skip all leading zero and unallocated subclusters */
|
|
|
|
uint32_t alloc_bitmap = l2_bitmap & QCOW_L2_BITMAP_ALL_ALLOC;
|
|
|
|
cow_start_from =
|
|
|
|
MIN(sc_index, ctz32(alloc_bitmap)) << s->subcluster_bits;
|
|
|
|
} else {
|
|
|
|
cow_start_from = 0;
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
case QCOW2_SUBCLUSTER_ZERO_PLAIN:
|
|
|
|
case QCOW2_SUBCLUSTER_UNALLOCATED_PLAIN:
|
|
|
|
cow_start_from = sc_index << s->subcluster_bits;
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
g_assert_not_reached();
|
|
|
|
}
|
2020-07-10 18:12:47 +02:00
|
|
|
} else {
|
2020-07-10 18:13:02 +02:00
|
|
|
switch (type) {
|
|
|
|
case QCOW2_SUBCLUSTER_NORMAL:
|
|
|
|
cow_start_from = cow_start_to;
|
|
|
|
break;
|
|
|
|
case QCOW2_SUBCLUSTER_ZERO_ALLOC:
|
|
|
|
case QCOW2_SUBCLUSTER_UNALLOCATED_ALLOC:
|
|
|
|
cow_start_from = sc_index << s->subcluster_bits;
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
g_assert_not_reached();
|
|
|
|
}
|
2020-07-10 18:12:47 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
/* Get the L2 entry of the last cluster */
|
2020-07-10 18:13:02 +02:00
|
|
|
l2_index += nb_clusters - 1;
|
|
|
|
l2_entry = get_l2_entry(s, l2_slice, l2_index);
|
|
|
|
l2_bitmap = get_l2_bitmap(s, l2_slice, l2_index);
|
|
|
|
sc_index = offset_to_sc_index(s, guest_offset + bytes - 1);
|
|
|
|
type = qcow2_get_subcluster_type(bs, l2_entry, l2_bitmap, sc_index);
|
|
|
|
|
|
|
|
if (!keep_old) {
|
|
|
|
switch (type) {
|
|
|
|
case QCOW2_SUBCLUSTER_COMPRESSED:
|
|
|
|
cow_end_to = ROUND_UP(cow_end_from, s->cluster_size);
|
|
|
|
break;
|
|
|
|
case QCOW2_SUBCLUSTER_NORMAL:
|
|
|
|
case QCOW2_SUBCLUSTER_ZERO_ALLOC:
|
|
|
|
case QCOW2_SUBCLUSTER_UNALLOCATED_ALLOC:
|
|
|
|
cow_end_to = ROUND_UP(cow_end_from, s->cluster_size);
|
|
|
|
if (has_subclusters(s)) {
|
|
|
|
/* Skip all trailing zero and unallocated subclusters */
|
|
|
|
uint32_t alloc_bitmap = l2_bitmap & QCOW_L2_BITMAP_ALL_ALLOC;
|
|
|
|
cow_end_to -=
|
|
|
|
MIN(s->subclusters_per_cluster - sc_index - 1,
|
|
|
|
clz32(alloc_bitmap)) << s->subcluster_bits;
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
case QCOW2_SUBCLUSTER_ZERO_PLAIN:
|
|
|
|
case QCOW2_SUBCLUSTER_UNALLOCATED_PLAIN:
|
|
|
|
cow_end_to = ROUND_UP(cow_end_from, s->subcluster_size);
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
g_assert_not_reached();
|
|
|
|
}
|
2020-07-10 18:12:47 +02:00
|
|
|
} else {
|
2020-07-10 18:13:02 +02:00
|
|
|
switch (type) {
|
|
|
|
case QCOW2_SUBCLUSTER_NORMAL:
|
|
|
|
cow_end_to = cow_end_from;
|
|
|
|
break;
|
|
|
|
case QCOW2_SUBCLUSTER_ZERO_ALLOC:
|
|
|
|
case QCOW2_SUBCLUSTER_UNALLOCATED_ALLOC:
|
|
|
|
cow_end_to = ROUND_UP(cow_end_from, s->subcluster_size);
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
g_assert_not_reached();
|
|
|
|
}
|
2020-07-10 18:12:47 +02:00
|
|
|
}
|
2020-07-10 18:12:45 +02:00
|
|
|
|
|
|
|
*m = g_malloc0(sizeof(**m));
|
|
|
|
**m = (QCowL2Meta) {
|
|
|
|
.next = old_m,
|
|
|
|
|
|
|
|
.alloc_offset = host_cluster_offset,
|
|
|
|
.offset = start_of_cluster(s, guest_offset),
|
|
|
|
.nb_clusters = nb_clusters,
|
|
|
|
|
|
|
|
.keep_old_clusters = keep_old,
|
|
|
|
|
|
|
|
.cow_start = {
|
|
|
|
.offset = cow_start_from,
|
|
|
|
.nb_bytes = cow_start_to - cow_start_from,
|
|
|
|
},
|
|
|
|
.cow_end = {
|
|
|
|
.offset = cow_end_from,
|
|
|
|
.nb_bytes = cow_end_to - cow_end_from,
|
|
|
|
},
|
|
|
|
};
|
|
|
|
|
|
|
|
qemu_co_queue_init(&(*m)->dependent_requests);
|
|
|
|
QLIST_INSERT_HEAD(&s->cluster_allocs, *m, next_in_flight);
|
2020-07-10 18:13:02 +02:00
|
|
|
|
|
|
|
return 0;
|
2020-07-10 18:12:45 +02:00
|
|
|
}
|
|
|
|
|
2020-07-10 18:12:47 +02:00
|
|
|
/*
|
|
|
|
* Returns true if writing to the cluster pointed to by @l2_entry
|
|
|
|
* requires a new allocation (that is, if the cluster is unallocated
|
|
|
|
* or has refcount > 1 and therefore cannot be written in-place).
|
|
|
|
*/
|
2023-10-27 17:53:30 +02:00
|
|
|
static bool GRAPH_RDLOCK
|
|
|
|
cluster_needs_new_alloc(BlockDriverState *bs, uint64_t l2_entry)
|
2020-07-10 18:12:46 +02:00
|
|
|
{
|
|
|
|
switch (qcow2_get_cluster_type(bs, l2_entry)) {
|
|
|
|
case QCOW2_CLUSTER_NORMAL:
|
2020-07-10 18:12:47 +02:00
|
|
|
case QCOW2_CLUSTER_ZERO_ALLOC:
|
2020-07-10 18:12:46 +02:00
|
|
|
if (l2_entry & QCOW_OFLAG_COPIED) {
|
|
|
|
return false;
|
|
|
|
}
|
2020-09-08 09:00:28 +02:00
|
|
|
/* fallthrough */
|
2020-07-10 18:12:46 +02:00
|
|
|
case QCOW2_CLUSTER_UNALLOCATED:
|
|
|
|
case QCOW2_CLUSTER_COMPRESSED:
|
|
|
|
case QCOW2_CLUSTER_ZERO_PLAIN:
|
|
|
|
return true;
|
|
|
|
default:
|
|
|
|
abort();
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2012-03-02 19:27:53 +01:00
|
|
|
/*
|
2020-07-10 18:12:47 +02:00
|
|
|
* Returns the number of contiguous clusters that can be written to
|
|
|
|
* using one single write request, starting from @l2_index.
|
|
|
|
* At most @nb_clusters are checked.
|
|
|
|
*
|
|
|
|
* If @new_alloc is true this counts clusters that are either
|
|
|
|
* unallocated, or allocated but with refcount > 1 (so they need to be
|
|
|
|
* newly allocated and COWed).
|
|
|
|
*
|
|
|
|
* If @new_alloc is false this counts clusters that are already
|
|
|
|
* allocated and can be overwritten in-place (this includes clusters
|
|
|
|
* of type QCOW2_CLUSTER_ZERO_ALLOC).
|
2012-03-02 19:27:53 +01:00
|
|
|
*/
|
2023-10-27 17:53:30 +02:00
|
|
|
static int GRAPH_RDLOCK
|
|
|
|
count_single_write_clusters(BlockDriverState *bs, int nb_clusters,
|
|
|
|
uint64_t *l2_slice, int l2_index, bool new_alloc)
|
2012-03-02 19:27:53 +01:00
|
|
|
{
|
2020-07-10 18:12:47 +02:00
|
|
|
BDRVQcow2State *s = bs->opaque;
|
2020-07-10 18:12:48 +02:00
|
|
|
uint64_t l2_entry = get_l2_entry(s, l2_slice, l2_index);
|
2020-07-10 18:12:47 +02:00
|
|
|
uint64_t expected_offset = l2_entry & L2E_OFFSET_MASK;
|
2012-03-27 13:17:22 +02:00
|
|
|
int i;
|
2012-03-02 19:27:53 +01:00
|
|
|
|
2012-03-27 13:17:22 +02:00
|
|
|
for (i = 0; i < nb_clusters; i++) {
|
2020-07-10 18:12:48 +02:00
|
|
|
l2_entry = get_l2_entry(s, l2_slice, l2_index + i);
|
2020-07-10 18:12:47 +02:00
|
|
|
if (cluster_needs_new_alloc(bs, l2_entry) != new_alloc) {
|
2012-03-02 19:27:53 +01:00
|
|
|
break;
|
2012-03-27 13:17:22 +02:00
|
|
|
}
|
2020-07-10 18:12:47 +02:00
|
|
|
if (!new_alloc) {
|
|
|
|
if (expected_offset != (l2_entry & L2E_OFFSET_MASK)) {
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
expected_offset += s->cluster_size;
|
|
|
|
}
|
2012-03-02 19:27:53 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
assert(i <= nb_clusters);
|
|
|
|
return i;
|
|
|
|
}
|
|
|
|
|
2012-03-02 14:10:54 +01:00
|
|
|
/*
|
2012-12-07 18:08:49 +01:00
|
|
|
* Check if there already is an AIO write request in flight which allocates
|
|
|
|
* the same cluster. In this case we need to wait until the previous
|
|
|
|
* request has completed and updated the L2 table accordingly.
|
2013-03-26 17:49:58 +01:00
|
|
|
*
|
|
|
|
* Returns:
|
|
|
|
* 0 if there was no dependency. *cur_bytes indicates the number of
|
|
|
|
* bytes from guest_offset that can be read before the next
|
|
|
|
* dependency must be processed (or the request is complete)
|
|
|
|
*
|
|
|
|
* -EAGAIN if we had to wait for another request, previously gathered
|
|
|
|
* information on cluster allocation may be invalid now. The caller
|
|
|
|
* must start over anyway, so consider *cur_bytes undefined.
|
2012-03-02 14:10:54 +01:00
|
|
|
*/
|
2022-09-22 10:49:12 +02:00
|
|
|
static int coroutine_fn handle_dependencies(BlockDriverState *bs,
|
|
|
|
uint64_t guest_offset,
|
|
|
|
uint64_t *cur_bytes, QCowL2Meta **m)
|
2012-03-02 14:10:54 +01:00
|
|
|
{
|
2015-09-07 17:12:56 +02:00
|
|
|
BDRVQcow2State *s = bs->opaque;
|
2012-03-02 14:10:54 +01:00
|
|
|
QCowL2Meta *old_alloc;
|
2013-03-26 17:49:58 +01:00
|
|
|
uint64_t bytes = *cur_bytes;
|
2012-03-02 14:10:54 +01:00
|
|
|
|
|
|
|
QLIST_FOREACH(old_alloc, &s->cluster_allocs, next_in_flight) {
|
|
|
|
|
2013-03-26 17:49:58 +01:00
|
|
|
uint64_t start = guest_offset;
|
|
|
|
uint64_t end = start + bytes;
|
2020-07-10 18:13:02 +02:00
|
|
|
uint64_t old_start = start_of_cluster(s, l2meta_cow_start(old_alloc));
|
|
|
|
uint64_t old_end = ROUND_UP(l2meta_cow_end(old_alloc), s->cluster_size);
|
2012-03-02 14:10:54 +01:00
|
|
|
|
2013-03-26 17:49:57 +01:00
|
|
|
if (end <= old_start || start >= old_end) {
|
2012-03-02 14:10:54 +01:00
|
|
|
/* No intersection */
|
2021-08-24 12:15:16 +02:00
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
2021-08-24 12:15:17 +02:00
|
|
|
if (old_alloc->keep_old_clusters &&
|
|
|
|
(end <= l2meta_cow_start(old_alloc) ||
|
|
|
|
start >= l2meta_cow_end(old_alloc)))
|
|
|
|
{
|
|
|
|
/*
|
|
|
|
* Clusters intersect but COW areas don't. And cluster itself is
|
|
|
|
* already allocated. So, there is no actual conflict.
|
|
|
|
*/
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
2021-08-24 12:15:16 +02:00
|
|
|
/* Conflict */
|
|
|
|
|
|
|
|
if (start < old_start) {
|
|
|
|
/* Stop at the start of a running allocation */
|
|
|
|
bytes = old_start - start;
|
2012-03-02 14:10:54 +01:00
|
|
|
} else {
|
2021-08-24 12:15:16 +02:00
|
|
|
bytes = 0;
|
|
|
|
}
|
2012-03-02 14:10:54 +01:00
|
|
|
|
2021-08-24 12:15:16 +02:00
|
|
|
/*
|
|
|
|
* Stop if an l2meta already exists. After yielding, it wouldn't
|
|
|
|
* be valid any more, so we'd have to clean up the old L2Metas
|
|
|
|
* and deal with requests depending on them before starting to
|
|
|
|
* gather new ones. Not worth the trouble.
|
|
|
|
*/
|
|
|
|
if (bytes == 0 && *m) {
|
|
|
|
*cur_bytes = 0;
|
|
|
|
return 0;
|
|
|
|
}
|
2013-03-27 11:43:49 +01:00
|
|
|
|
2021-08-24 12:15:16 +02:00
|
|
|
if (bytes == 0) {
|
|
|
|
/*
|
|
|
|
* Wait for the dependency to complete. We need to recheck
|
|
|
|
* the free/allocated clusters when we continue.
|
|
|
|
*/
|
|
|
|
qemu_co_queue_wait(&old_alloc->dependent_requests, &s->lock);
|
|
|
|
return -EAGAIN;
|
2012-03-02 14:10:54 +01:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2013-03-26 17:49:58 +01:00
|
|
|
/* Make sure that existing clusters and new allocations are only used up to
|
|
|
|
* the next dependency if we shortened the request above */
|
|
|
|
*cur_bytes = bytes;
|
2012-03-02 14:10:54 +01:00
|
|
|
|
2012-12-07 18:08:49 +01:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2013-03-26 17:50:05 +01:00
|
|
|
/*
|
2020-07-10 18:12:47 +02:00
|
|
|
* Checks how many already allocated clusters that don't require a new
|
|
|
|
* allocation there are at the given guest_offset (up to *bytes).
|
|
|
|
* If *host_offset is not INV_OFFSET, only physically contiguous clusters
|
|
|
|
* beginning at this host offset are counted.
|
2013-03-26 17:50:05 +01:00
|
|
|
*
|
2013-03-26 17:50:09 +01:00
|
|
|
* Note that guest_offset may not be cluster aligned. In this case, the
|
|
|
|
* returned *host_offset points to exact byte referenced by guest_offset and
|
|
|
|
* therefore isn't cluster aligned as well.
|
2013-03-26 17:50:05 +01:00
|
|
|
*
|
|
|
|
* Returns:
|
|
|
|
* 0: if no allocated clusters are available at the given offset.
|
|
|
|
* *bytes is normally unchanged. It is set to 0 if the cluster
|
2020-07-10 18:12:47 +02:00
|
|
|
* is allocated and can be overwritten in-place but doesn't have
|
|
|
|
* the right physical offset.
|
2013-03-26 17:50:05 +01:00
|
|
|
*
|
2020-07-10 18:12:47 +02:00
|
|
|
* 1: if allocated clusters that can be overwritten in place are
|
|
|
|
* available at the requested offset. *bytes may have decreased
|
|
|
|
* and describes the length of the area that can be written to.
|
2013-03-26 17:50:05 +01:00
|
|
|
*
|
|
|
|
* -errno: in error cases
|
|
|
|
*/
|
2023-09-29 16:51:49 +02:00
|
|
|
static int coroutine_fn GRAPH_RDLOCK
|
|
|
|
handle_copied(BlockDriverState *bs, uint64_t guest_offset,
|
|
|
|
uint64_t *host_offset, uint64_t *bytes, QCowL2Meta **m)
|
2013-03-26 17:50:05 +01:00
|
|
|
{
|
2015-09-07 17:12:56 +02:00
|
|
|
BDRVQcow2State *s = bs->opaque;
|
2013-03-26 17:50:05 +01:00
|
|
|
int l2_index;
|
2020-07-10 18:12:47 +02:00
|
|
|
uint64_t l2_entry, cluster_offset;
|
2018-02-05 15:33:22 +01:00
|
|
|
uint64_t *l2_slice;
|
2015-09-14 16:39:47 +02:00
|
|
|
uint64_t nb_clusters;
|
2013-03-26 17:50:07 +01:00
|
|
|
unsigned int keep_clusters;
|
2015-05-11 14:54:58 +02:00
|
|
|
int ret;
|
2013-03-26 17:50:05 +01:00
|
|
|
|
|
|
|
trace_qcow2_handle_copied(qemu_coroutine_self(), guest_offset, *host_offset,
|
|
|
|
*bytes);
|
|
|
|
|
2019-01-18 14:40:36 +01:00
|
|
|
assert(*host_offset == INV_OFFSET || offset_into_cluster(s, guest_offset)
|
|
|
|
== offset_into_cluster(s, *host_offset));
|
2013-03-26 17:50:09 +01:00
|
|
|
|
2013-03-26 17:50:06 +01:00
|
|
|
/*
|
2018-02-05 15:33:22 +01:00
|
|
|
* Calculate the number of clusters to look for. We stop at L2 slice
|
2013-03-26 17:50:06 +01:00
|
|
|
* boundaries to keep things simple.
|
|
|
|
*/
|
|
|
|
nb_clusters =
|
|
|
|
size_to_clusters(s, offset_into_cluster(s, guest_offset) + *bytes);
|
|
|
|
|
2018-02-05 15:33:22 +01:00
|
|
|
l2_index = offset_to_l2_slice_index(s, guest_offset);
|
|
|
|
nb_clusters = MIN(nb_clusters, s->l2_slice_size - l2_index);
|
2020-07-10 18:12:47 +02:00
|
|
|
/* Limit total byte count to BDRV_REQUEST_MAX_BYTES */
|
|
|
|
nb_clusters = MIN(nb_clusters, BDRV_REQUEST_MAX_BYTES >> s->cluster_bits);
|
2013-03-26 17:50:06 +01:00
|
|
|
|
2013-03-26 17:50:05 +01:00
|
|
|
/* Find L2 entry for the first involved cluster */
|
2018-02-05 15:33:22 +01:00
|
|
|
ret = get_cluster_table(bs, guest_offset, &l2_slice, &l2_index);
|
2013-03-26 17:50:05 +01:00
|
|
|
if (ret < 0) {
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2020-07-10 18:12:48 +02:00
|
|
|
l2_entry = get_l2_entry(s, l2_slice, l2_index);
|
2020-07-10 18:12:47 +02:00
|
|
|
cluster_offset = l2_entry & L2E_OFFSET_MASK;
|
|
|
|
|
|
|
|
if (!cluster_needs_new_alloc(bs, l2_entry)) {
|
|
|
|
if (offset_into_cluster(s, cluster_offset)) {
|
|
|
|
qcow2_signal_corruption(bs, true, -1, -1, "%s cluster offset "
|
|
|
|
"%#" PRIx64 " unaligned (guest offset: %#"
|
|
|
|
PRIx64 ")", l2_entry & QCOW_OFLAG_ZERO ?
|
|
|
|
"Preallocated zero" : "Data",
|
|
|
|
cluster_offset, guest_offset);
|
2014-09-05 16:07:18 +02:00
|
|
|
ret = -EIO;
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
2020-07-10 18:12:47 +02:00
|
|
|
/* If a specific host_offset is required, check it */
|
|
|
|
if (*host_offset != INV_OFFSET && cluster_offset != *host_offset) {
|
2013-03-26 17:50:08 +01:00
|
|
|
*bytes = 0;
|
|
|
|
ret = 0;
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
2013-03-26 17:50:05 +01:00
|
|
|
/* We keep all QCOW_OFLAG_COPIED clusters */
|
2020-07-10 18:12:47 +02:00
|
|
|
keep_clusters = count_single_write_clusters(bs, nb_clusters, l2_slice,
|
|
|
|
l2_index, false);
|
2013-03-26 17:50:07 +01:00
|
|
|
assert(keep_clusters <= nb_clusters);
|
|
|
|
|
|
|
|
*bytes = MIN(*bytes,
|
|
|
|
keep_clusters * s->cluster_size
|
|
|
|
- offset_into_cluster(s, guest_offset));
|
2020-07-10 18:12:47 +02:00
|
|
|
assert(*bytes != 0);
|
|
|
|
|
2020-07-10 18:13:02 +02:00
|
|
|
ret = calculate_l2_meta(bs, cluster_offset, guest_offset,
|
|
|
|
*bytes, l2_slice, m, true);
|
|
|
|
if (ret < 0) {
|
|
|
|
goto out;
|
|
|
|
}
|
2013-03-26 17:50:05 +01:00
|
|
|
|
|
|
|
ret = 1;
|
|
|
|
} else {
|
|
|
|
ret = 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Cleanup */
|
2013-03-26 17:50:08 +01:00
|
|
|
out:
|
2018-02-05 15:33:22 +01:00
|
|
|
qcow2_cache_put(s->l2_table_cache, (void **) &l2_slice);
|
2013-03-26 17:50:05 +01:00
|
|
|
|
2013-03-26 17:50:08 +01:00
|
|
|
/* Only return a host offset if we actually made progress. Otherwise we
|
|
|
|
* would make requirements for handle_alloc() that it can't fulfill */
|
2014-09-05 16:07:18 +02:00
|
|
|
if (ret > 0) {
|
2020-07-10 18:12:47 +02:00
|
|
|
*host_offset = cluster_offset + offset_into_cluster(s, guest_offset);
|
2013-03-26 17:50:08 +01:00
|
|
|
}
|
|
|
|
|
2013-03-26 17:50:05 +01:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2012-12-07 18:08:49 +01:00
|
|
|
/*
|
|
|
|
* Allocates new clusters for the given guest_offset.
|
|
|
|
*
|
|
|
|
* At most *nb_clusters are allocated, and on return *nb_clusters is updated to
|
|
|
|
* contain the number of clusters that have been allocated and are contiguous
|
|
|
|
* in the image file.
|
|
|
|
*
|
2019-01-18 14:40:36 +01:00
|
|
|
* If *host_offset is not INV_OFFSET, it specifies the offset in the image file
|
|
|
|
* at which the new clusters must start. *nb_clusters can be 0 on return in
|
|
|
|
* this case if the cluster at host_offset is already in use. If *host_offset
|
|
|
|
* is INV_OFFSET, the clusters can be allocated anywhere in the image file.
|
2012-12-07 18:08:49 +01:00
|
|
|
*
|
|
|
|
* *host_offset is updated to contain the offset into the image file at which
|
|
|
|
* the first allocated cluster starts.
|
|
|
|
*
|
|
|
|
* Return 0 on success and -errno in error cases. -EAGAIN means that the
|
|
|
|
* function has been waiting for another request and the allocation must be
|
|
|
|
* restarted, but the whole request should not be failed.
|
|
|
|
*/
|
2023-09-29 16:51:49 +02:00
|
|
|
static int coroutine_fn GRAPH_RDLOCK
|
|
|
|
do_alloc_cluster_offset(BlockDriverState *bs, uint64_t guest_offset,
|
|
|
|
uint64_t *host_offset, uint64_t *nb_clusters)
|
2012-12-07 18:08:49 +01:00
|
|
|
{
|
2015-09-07 17:12:56 +02:00
|
|
|
BDRVQcow2State *s = bs->opaque;
|
2012-12-07 18:08:49 +01:00
|
|
|
|
|
|
|
trace_qcow2_do_alloc_clusters_offset(qemu_coroutine_self(), guest_offset,
|
|
|
|
*host_offset, *nb_clusters);
|
|
|
|
|
2019-01-15 20:39:06 +01:00
|
|
|
if (has_data_file(bs)) {
|
|
|
|
assert(*host_offset == INV_OFFSET ||
|
|
|
|
*host_offset == start_of_cluster(s, guest_offset));
|
|
|
|
*host_offset = start_of_cluster(s, guest_offset);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2012-03-02 14:10:54 +01:00
|
|
|
/* Allocate new clusters */
|
|
|
|
trace_qcow2_cluster_alloc_phys(qemu_coroutine_self());
|
2019-01-18 14:40:36 +01:00
|
|
|
if (*host_offset == INV_OFFSET) {
|
2012-05-24 12:56:32 +02:00
|
|
|
int64_t cluster_offset =
|
|
|
|
qcow2_alloc_clusters(bs, *nb_clusters * s->cluster_size);
|
|
|
|
if (cluster_offset < 0) {
|
|
|
|
return cluster_offset;
|
|
|
|
}
|
|
|
|
*host_offset = cluster_offset;
|
|
|
|
return 0;
|
2012-03-02 14:10:54 +01:00
|
|
|
} else {
|
2015-09-14 16:39:47 +02:00
|
|
|
int64_t ret = qcow2_alloc_clusters_at(bs, *host_offset, *nb_clusters);
|
2012-05-24 12:56:32 +02:00
|
|
|
if (ret < 0) {
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
*nb_clusters = ret;
|
|
|
|
return 0;
|
2012-03-02 14:10:54 +01:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2013-03-26 17:50:00 +01:00
|
|
|
/*
|
2020-07-10 18:12:47 +02:00
|
|
|
* Allocates new clusters for an area that is either still unallocated or
|
|
|
|
* cannot be overwritten in-place. If *host_offset is not INV_OFFSET,
|
|
|
|
* clusters are only allocated if the new allocation can match the specified
|
|
|
|
* host offset.
|
2013-03-26 17:50:00 +01:00
|
|
|
*
|
2013-03-26 17:50:09 +01:00
|
|
|
* Note that guest_offset may not be cluster aligned. In this case, the
|
|
|
|
* returned *host_offset points to exact byte referenced by guest_offset and
|
|
|
|
* therefore isn't cluster aligned as well.
|
2013-03-26 17:50:00 +01:00
|
|
|
*
|
|
|
|
* Returns:
|
|
|
|
* 0: if no clusters could be allocated. *bytes is set to 0,
|
|
|
|
* *host_offset is left unchanged.
|
|
|
|
*
|
|
|
|
* 1: if new clusters were allocated. *bytes may be decreased if the
|
|
|
|
* new allocation doesn't cover all of the requested area.
|
|
|
|
* *host_offset is updated to contain the host offset of the first
|
|
|
|
* newly allocated cluster.
|
|
|
|
*
|
|
|
|
* -errno: in error cases
|
|
|
|
*/
|
2023-09-29 16:51:49 +02:00
|
|
|
static int coroutine_fn GRAPH_RDLOCK
|
|
|
|
handle_alloc(BlockDriverState *bs, uint64_t guest_offset,
|
|
|
|
uint64_t *host_offset, uint64_t *bytes, QCowL2Meta **m)
|
2013-03-26 17:50:00 +01:00
|
|
|
{
|
2015-09-07 17:12:56 +02:00
|
|
|
BDRVQcow2State *s = bs->opaque;
|
2013-03-26 17:50:00 +01:00
|
|
|
int l2_index;
|
2018-02-05 15:33:23 +01:00
|
|
|
uint64_t *l2_slice;
|
2015-09-14 16:39:47 +02:00
|
|
|
uint64_t nb_clusters;
|
2013-03-26 17:50:00 +01:00
|
|
|
int ret;
|
|
|
|
|
2020-07-10 18:12:47 +02:00
|
|
|
uint64_t alloc_cluster_offset;
|
2013-03-26 17:50:00 +01:00
|
|
|
|
|
|
|
trace_qcow2_handle_alloc(qemu_coroutine_self(), guest_offset, *host_offset,
|
|
|
|
*bytes);
|
|
|
|
assert(*bytes > 0);
|
|
|
|
|
2013-03-26 17:50:01 +01:00
|
|
|
/*
|
2018-02-05 15:33:23 +01:00
|
|
|
* Calculate the number of clusters to look for. We stop at L2 slice
|
2013-03-26 17:50:01 +01:00
|
|
|
* boundaries to keep things simple.
|
|
|
|
*/
|
2013-03-26 17:50:03 +01:00
|
|
|
nb_clusters =
|
|
|
|
size_to_clusters(s, offset_into_cluster(s, guest_offset) + *bytes);
|
|
|
|
|
2018-02-05 15:33:23 +01:00
|
|
|
l2_index = offset_to_l2_slice_index(s, guest_offset);
|
|
|
|
nb_clusters = MIN(nb_clusters, s->l2_slice_size - l2_index);
|
2020-07-10 18:12:47 +02:00
|
|
|
/* Limit total allocation byte count to BDRV_REQUEST_MAX_BYTES */
|
|
|
|
nb_clusters = MIN(nb_clusters, BDRV_REQUEST_MAX_BYTES >> s->cluster_bits);
|
2019-10-10 12:08:57 +02:00
|
|
|
|
2013-03-26 17:50:00 +01:00
|
|
|
/* Find L2 entry for the first involved cluster */
|
2018-02-05 15:33:23 +01:00
|
|
|
ret = get_cluster_table(bs, guest_offset, &l2_slice, &l2_index);
|
2013-03-26 17:50:00 +01:00
|
|
|
if (ret < 0) {
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2020-07-10 18:12:47 +02:00
|
|
|
nb_clusters = count_single_write_clusters(bs, nb_clusters,
|
|
|
|
l2_slice, l2_index, true);
|
2013-03-26 17:50:00 +01:00
|
|
|
|
2013-03-27 11:43:49 +01:00
|
|
|
/* This function is only called when there were no non-COW clusters, so if
|
|
|
|
* we can't find any unallocated or COW clusters either, something is
|
|
|
|
* wrong with our code. */
|
|
|
|
assert(nb_clusters > 0);
|
|
|
|
|
2020-07-10 18:12:47 +02:00
|
|
|
/* Allocate at a given offset in the image file */
|
|
|
|
alloc_cluster_offset = *host_offset == INV_OFFSET ? INV_OFFSET :
|
|
|
|
start_of_cluster(s, *host_offset);
|
|
|
|
ret = do_alloc_cluster_offset(bs, guest_offset, &alloc_cluster_offset,
|
|
|
|
&nb_clusters);
|
|
|
|
if (ret < 0) {
|
|
|
|
goto out;
|
2013-03-26 17:50:00 +01:00
|
|
|
}
|
|
|
|
|
2020-07-10 18:12:47 +02:00
|
|
|
/* Can't extend contiguous allocation */
|
|
|
|
if (nb_clusters == 0) {
|
|
|
|
*bytes = 0;
|
|
|
|
ret = 0;
|
|
|
|
goto out;
|
2014-08-07 22:47:53 +02:00
|
|
|
}
|
|
|
|
|
2020-07-10 18:12:47 +02:00
|
|
|
assert(alloc_cluster_offset != INV_OFFSET);
|
|
|
|
|
2013-03-26 17:50:04 +01:00
|
|
|
/*
|
|
|
|
* Save info needed for meta data update.
|
|
|
|
*
|
2016-06-01 14:08:56 +02:00
|
|
|
* requested_bytes: Number of bytes from the start of the first
|
2013-03-26 17:50:04 +01:00
|
|
|
* newly allocated cluster to the end of the (possibly shortened
|
|
|
|
* before) write request.
|
|
|
|
*
|
2016-06-01 14:08:56 +02:00
|
|
|
* avail_bytes: Number of bytes from the start of the first
|
2013-03-26 17:50:04 +01:00
|
|
|
* newly allocated to the end of the last newly allocated cluster.
|
|
|
|
*
|
2016-06-01 14:08:56 +02:00
|
|
|
* nb_bytes: The number of bytes from the start of the first
|
2013-03-26 17:50:04 +01:00
|
|
|
* newly allocated cluster to the end of the area that the write
|
|
|
|
* request actually writes to (excluding COW at the end)
|
|
|
|
*/
|
2016-06-01 14:08:56 +02:00
|
|
|
uint64_t requested_bytes = *bytes + offset_into_cluster(s, guest_offset);
|
2019-10-10 12:08:57 +02:00
|
|
|
int avail_bytes = nb_clusters << s->cluster_bits;
|
2016-06-01 14:08:56 +02:00
|
|
|
int nb_bytes = MIN(requested_bytes, avail_bytes);
|
2013-03-26 17:50:04 +01:00
|
|
|
|
2013-03-26 17:50:09 +01:00
|
|
|
*host_offset = alloc_cluster_offset + offset_into_cluster(s, guest_offset);
|
2016-06-01 14:08:56 +02:00
|
|
|
*bytes = MIN(*bytes, nb_bytes - offset_into_cluster(s, guest_offset));
|
2013-03-26 17:50:04 +01:00
|
|
|
assert(*bytes != 0);
|
|
|
|
|
2020-07-10 18:13:02 +02:00
|
|
|
ret = calculate_l2_meta(bs, alloc_cluster_offset, guest_offset, *bytes,
|
|
|
|
l2_slice, m, false);
|
|
|
|
if (ret < 0) {
|
|
|
|
goto out;
|
|
|
|
}
|
2020-07-10 18:12:45 +02:00
|
|
|
|
2020-07-10 18:12:47 +02:00
|
|
|
ret = 1;
|
2013-03-26 17:50:00 +01:00
|
|
|
|
2020-07-10 18:12:47 +02:00
|
|
|
out:
|
|
|
|
qcow2_cache_put(s->l2_table_cache, (void **) &l2_slice);
|
2013-03-26 17:50:00 +01:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2009-05-28 16:07:05 +02:00
|
|
|
/*
|
2020-09-03 18:37:49 +02:00
|
|
|
* For a given area on the virtual disk defined by @offset and @bytes,
|
|
|
|
* find the corresponding area on the qcow2 image, allocating new
|
|
|
|
* clusters (or subclusters) if necessary. The result can span a
|
|
|
|
* combination of allocated and previously unallocated clusters.
|
2009-05-28 16:07:05 +02:00
|
|
|
*
|
2020-09-11 16:09:42 +02:00
|
|
|
* Note that offset may not be cluster aligned. In this case, the returned
|
|
|
|
* *host_offset points to exact byte referenced by offset and therefore
|
|
|
|
* isn't cluster aligned as well.
|
|
|
|
*
|
2020-09-03 18:37:49 +02:00
|
|
|
* On return, @host_offset is set to the beginning of the requested
|
|
|
|
* area. This area is guaranteed to be contiguous on the qcow2 file
|
|
|
|
* but it can be smaller than initially requested. In this case @bytes
|
|
|
|
* is updated with the actual size.
|
2009-05-28 16:07:05 +02:00
|
|
|
*
|
2020-09-03 18:37:49 +02:00
|
|
|
* If any clusters or subclusters were allocated then @m contains a
|
|
|
|
* list with the information of all the affected regions. Note that
|
|
|
|
* this can happen regardless of whether this function succeeds or
|
|
|
|
* not. The caller is responsible for updating the L2 metadata of the
|
|
|
|
* allocated clusters (on success) or freeing them (on failure), and
|
|
|
|
* for clearing the contents of @m afterwards in both cases.
|
2009-05-28 16:07:05 +02:00
|
|
|
*
|
2011-06-30 17:42:09 +02:00
|
|
|
* If the request conflicts with another write request in flight, the coroutine
|
|
|
|
* is queued and will be reentered when the dependency has completed.
|
2010-01-20 15:03:01 +01:00
|
|
|
*
|
|
|
|
* Return 0 on success and -errno in error cases
|
2009-05-28 16:07:05 +02:00
|
|
|
*/
|
2022-09-22 10:49:12 +02:00
|
|
|
int coroutine_fn qcow2_alloc_host_offset(BlockDriverState *bs, uint64_t offset,
|
|
|
|
unsigned int *bytes,
|
|
|
|
uint64_t *host_offset,
|
|
|
|
QCowL2Meta **m)
|
2009-05-28 16:07:05 +02:00
|
|
|
{
|
2015-09-07 17:12:56 +02:00
|
|
|
BDRVQcow2State *s = bs->opaque;
|
2013-03-26 17:50:10 +01:00
|
|
|
uint64_t start, remaining;
|
2012-03-02 14:10:54 +01:00
|
|
|
uint64_t cluster_offset;
|
2013-03-26 17:49:58 +01:00
|
|
|
uint64_t cur_bytes;
|
2013-03-26 17:50:10 +01:00
|
|
|
int ret;
|
2009-05-28 16:07:05 +02:00
|
|
|
|
2016-06-01 16:55:05 +02:00
|
|
|
trace_qcow2_alloc_clusters_offset(qemu_coroutine_self(), offset, *bytes);
|
2013-03-26 17:50:10 +01:00
|
|
|
|
2012-04-24 16:10:56 +02:00
|
|
|
again:
|
2014-01-26 04:12:37 +01:00
|
|
|
start = offset;
|
2016-06-01 16:55:05 +02:00
|
|
|
remaining = *bytes;
|
2019-01-18 14:40:36 +01:00
|
|
|
cluster_offset = INV_OFFSET;
|
|
|
|
*host_offset = INV_OFFSET;
|
2013-03-27 11:43:49 +01:00
|
|
|
cur_bytes = 0;
|
|
|
|
*m = NULL;
|
2013-03-26 17:50:05 +01:00
|
|
|
|
2013-03-26 17:50:12 +01:00
|
|
|
while (true) {
|
2013-03-27 11:43:49 +01:00
|
|
|
|
2019-01-18 14:40:36 +01:00
|
|
|
if (*host_offset == INV_OFFSET && cluster_offset != INV_OFFSET) {
|
2020-09-11 16:09:42 +02:00
|
|
|
*host_offset = cluster_offset;
|
2013-03-27 11:43:49 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
assert(remaining >= cur_bytes);
|
|
|
|
|
|
|
|
start += cur_bytes;
|
|
|
|
remaining -= cur_bytes;
|
2019-01-18 14:40:36 +01:00
|
|
|
|
|
|
|
if (cluster_offset != INV_OFFSET) {
|
|
|
|
cluster_offset += cur_bytes;
|
|
|
|
}
|
2013-03-27 11:43:49 +01:00
|
|
|
|
|
|
|
if (remaining == 0) {
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
cur_bytes = remaining;
|
|
|
|
|
2013-03-26 17:50:12 +01:00
|
|
|
/*
|
|
|
|
* Now start gathering as many contiguous clusters as possible:
|
|
|
|
*
|
|
|
|
* 1. Check for overlaps with in-flight allocations
|
|
|
|
*
|
|
|
|
* a) Overlap not in the first cluster -> shorten this request and
|
|
|
|
* let the caller handle the rest in its next loop iteration.
|
|
|
|
*
|
|
|
|
* b) Real overlaps of two requests. Yield and restart the search
|
|
|
|
* for contiguous clusters (the situation could have changed
|
|
|
|
* while we were sleeping)
|
|
|
|
*
|
|
|
|
* c) TODO: Request starts in the same cluster as the in-flight
|
|
|
|
* allocation ends. Shorten the COW of the in-fight allocation,
|
|
|
|
* set cluster_offset to write to the same cluster and set up
|
|
|
|
* the right synchronisation between the in-flight request and
|
|
|
|
* the new one.
|
|
|
|
*/
|
2013-03-27 11:43:49 +01:00
|
|
|
ret = handle_dependencies(bs, start, &cur_bytes, m);
|
2013-03-26 17:50:12 +01:00
|
|
|
if (ret == -EAGAIN) {
|
2013-03-27 11:43:49 +01:00
|
|
|
/* Currently handle_dependencies() doesn't yield if we already had
|
|
|
|
* an allocation. If it did, we would have to clean up the L2Meta
|
|
|
|
* structs before starting over. */
|
|
|
|
assert(*m == NULL);
|
2013-03-26 17:50:12 +01:00
|
|
|
goto again;
|
|
|
|
} else if (ret < 0) {
|
|
|
|
return ret;
|
2013-03-27 11:43:49 +01:00
|
|
|
} else if (cur_bytes == 0) {
|
|
|
|
break;
|
2013-03-26 17:50:12 +01:00
|
|
|
} else {
|
|
|
|
/* handle_dependencies() may have decreased cur_bytes (shortened
|
|
|
|
* the allocations below) so that the next dependency is processed
|
|
|
|
* correctly during the next loop iteration. */
|
2013-03-26 17:50:05 +01:00
|
|
|
}
|
2013-03-26 17:50:10 +01:00
|
|
|
|
2013-03-26 17:50:12 +01:00
|
|
|
/*
|
|
|
|
* 2. Count contiguous COPIED clusters.
|
|
|
|
*/
|
|
|
|
ret = handle_copied(bs, start, &cluster_offset, &cur_bytes, m);
|
|
|
|
if (ret < 0) {
|
|
|
|
return ret;
|
|
|
|
} else if (ret) {
|
2013-03-27 11:43:49 +01:00
|
|
|
continue;
|
2013-03-26 17:50:12 +01:00
|
|
|
} else if (cur_bytes == 0) {
|
|
|
|
break;
|
|
|
|
}
|
2012-12-07 18:08:45 +01:00
|
|
|
|
2013-03-26 17:50:12 +01:00
|
|
|
/*
|
|
|
|
* 3. If the request still hasn't completed, allocate new clusters,
|
|
|
|
* considering any cluster_offset of steps 1c or 2.
|
|
|
|
*/
|
|
|
|
ret = handle_alloc(bs, start, &cluster_offset, &cur_bytes, m);
|
|
|
|
if (ret < 0) {
|
|
|
|
return ret;
|
|
|
|
} else if (ret) {
|
2013-03-27 11:43:49 +01:00
|
|
|
continue;
|
2013-03-26 17:50:12 +01:00
|
|
|
} else {
|
|
|
|
assert(cur_bytes == 0);
|
|
|
|
break;
|
|
|
|
}
|
2013-03-26 17:50:01 +01:00
|
|
|
}
|
2013-03-26 17:50:00 +01:00
|
|
|
|
2016-06-01 16:55:05 +02:00
|
|
|
*bytes -= remaining;
|
|
|
|
assert(*bytes > 0);
|
2019-01-18 14:40:36 +01:00
|
|
|
assert(*host_offset != INV_OFFSET);
|
2020-09-11 16:09:42 +02:00
|
|
|
assert(offset_into_cluster(s, *host_offset) ==
|
|
|
|
offset_into_cluster(s, offset));
|
2009-05-28 16:07:05 +02:00
|
|
|
|
2010-01-20 15:03:01 +01:00
|
|
|
return 0;
|
2009-05-28 16:07:05 +02:00
|
|
|
}
|
|
|
|
|
2011-01-26 16:56:48 +01:00
|
|
|
/*
|
|
|
|
* This discards as many clusters of nb_clusters as possible at once (i.e.
|
2018-02-05 15:33:24 +01:00
|
|
|
* all clusters in the same L2 slice) and returns the number of discarded
|
2011-01-26 16:56:48 +01:00
|
|
|
* clusters.
|
|
|
|
*/
|
2023-09-29 16:51:49 +02:00
|
|
|
static int GRAPH_RDLOCK
|
|
|
|
discard_in_l2_slice(BlockDriverState *bs, uint64_t offset, uint64_t nb_clusters,
|
|
|
|
enum qcow2_discard_type type, bool full_discard)
|
2011-01-26 16:56:48 +01:00
|
|
|
{
|
2015-09-07 17:12:56 +02:00
|
|
|
BDRVQcow2State *s = bs->opaque;
|
2018-02-05 15:33:24 +01:00
|
|
|
uint64_t *l2_slice;
|
2011-01-26 16:56:48 +01:00
|
|
|
int l2_index;
|
|
|
|
int ret;
|
|
|
|
int i;
|
|
|
|
|
2018-02-05 15:33:24 +01:00
|
|
|
ret = get_cluster_table(bs, offset, &l2_slice, &l2_index);
|
2011-01-26 16:56:48 +01:00
|
|
|
if (ret < 0) {
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2018-02-05 15:33:24 +01:00
|
|
|
/* Limit nb_clusters to one L2 slice */
|
|
|
|
nb_clusters = MIN(nb_clusters, s->l2_slice_size - l2_index);
|
2015-09-14 16:39:47 +02:00
|
|
|
assert(nb_clusters <= INT_MAX);
|
2011-01-26 16:56:48 +01:00
|
|
|
|
|
|
|
for (i = 0; i < nb_clusters; i++) {
|
2020-07-10 18:13:05 +02:00
|
|
|
uint64_t old_l2_entry = get_l2_entry(s, l2_slice, l2_index + i);
|
|
|
|
uint64_t old_l2_bitmap = get_l2_bitmap(s, l2_slice, l2_index + i);
|
|
|
|
uint64_t new_l2_entry = old_l2_entry;
|
|
|
|
uint64_t new_l2_bitmap = old_l2_bitmap;
|
|
|
|
QCow2ClusterType cluster_type =
|
|
|
|
qcow2_get_cluster_type(bs, old_l2_entry);
|
qcow2: add discard-no-unref option
When we for example have a sparse qcow2 image and discard: unmap is enabled,
there can be a lot of fragmentation in the image after some time. Especially on VM's
that do a lot of writes/deletes.
This causes the qcow2 image to grow even over 110% of its virtual size,
because the free gaps in the image get too small to allocate new
continuous clusters. So it allocates new space at the end of the image.
Disabling discard is not an option, as discard is needed to keep the
incremental backup size as low as possible. Without discard, the
incremental backups would become large, as qemu thinks it's just dirty
blocks but it doesn't know the blocks are unneeded.
So we need to avoid fragmentation but also 'empty' the unneeded blocks in
the image to have a small incremental backup.
In addition, we also want to send the discards further down the stack, so
the underlying blocks are still discarded.
Therefor we introduce a new qcow2 option "discard-no-unref".
When setting this option to true, discards will no longer have the qcow2
driver relinquish cluster allocations. Other than that, the request is
handled as normal: All clusters in range are marked as zero, and, if
pass-discard-request is true, it is passed further down the stack.
The only difference is that the now-zero clusters are preallocated
instead of being unallocated.
This will avoid fragmentation on the qcow2 image.
Fixes: https://gitlab.com/qemu-project/qemu/-/issues/1621
Signed-off-by: Jean-Louis Dupond <jean-louis@dupond.be>
Message-Id: <20230605084523.34134-2-jean-louis@dupond.be>
Reviewed-by: Hanna Czenczek <hreitz@redhat.com>
Signed-off-by: Hanna Czenczek <hreitz@redhat.com>
2023-06-05 10:45:24 +02:00
|
|
|
bool keep_reference = (cluster_type != QCOW2_CLUSTER_COMPRESSED) &&
|
|
|
|
!full_discard &&
|
|
|
|
(s->discard_no_unref &&
|
|
|
|
type == QCOW2_DISCARD_REQUEST);
|
2014-02-08 14:38:33 +01:00
|
|
|
|
|
|
|
/*
|
2020-07-10 18:13:05 +02:00
|
|
|
* If full_discard is true, the cluster should not read back as zeroes,
|
|
|
|
* but rather fall through to the backing file.
|
|
|
|
*
|
2014-10-24 15:57:30 +02:00
|
|
|
* If full_discard is false, make sure that a discarded area reads back
|
|
|
|
* as zeroes for v3 images (we cannot do it for v2 without actually
|
|
|
|
* writing a zero-filled buffer). We can skip the operation if the
|
|
|
|
* cluster is already marked as zero, or if it's unallocated and we
|
|
|
|
* don't have a backing file.
|
2014-02-08 14:38:33 +01:00
|
|
|
*
|
block: Convert bdrv_get_block_status() to bytes
We are gradually moving away from sector-based interfaces, towards
byte-based. In the common case, allocation is unlikely to ever use
values that are not naturally sector-aligned, but it is possible
that byte-based values will let us be more precise about allocation
at the end of an unaligned file that can do byte-based access.
Changing the name of the function from bdrv_get_block_status() to
bdrv_block_status() ensures that the compiler enforces that all
callers are updated. For now, the io.c layer still assert()s that
all callers are sector-aligned, but that can be relaxed when a later
patch implements byte-based block status in the drivers.
There was an inherent limitation in returning the offset via the
return value: we only have room for BDRV_BLOCK_OFFSET_MASK bits, which
means an offset can only be mapped for sector-aligned queries (or,
if we declare that non-aligned input is at the same relative position
modulo 512 of the answer), so the new interface also changes things to
return the offset via output through a parameter by reference rather
than mashed into the return value. We'll have some glue code that
munges between the two styles until we finish converting all uses.
For the most part this patch is just the addition of scaling at the
callers followed by inverse scaling at bdrv_block_status(), coupled
with the tweak in calling convention. But some code, particularly
bdrv_is_allocated(), gets a lot simpler because it no longer has to
mess with sectors.
For ease of review, bdrv_get_block_status_above() will be tackled
separately.
Signed-off-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2017-10-12 05:47:03 +02:00
|
|
|
* TODO We might want to use bdrv_block_status(bs) here, but we're
|
2014-02-08 14:38:33 +01:00
|
|
|
* holding s->lock, so that doesn't work today.
|
|
|
|
*/
|
2020-07-10 18:13:05 +02:00
|
|
|
if (full_discard) {
|
|
|
|
new_l2_entry = new_l2_bitmap = 0;
|
|
|
|
} else if (bs->backing || qcow2_cluster_is_allocated(cluster_type)) {
|
|
|
|
if (has_subclusters(s)) {
|
qcow2: add discard-no-unref option
When we for example have a sparse qcow2 image and discard: unmap is enabled,
there can be a lot of fragmentation in the image after some time. Especially on VM's
that do a lot of writes/deletes.
This causes the qcow2 image to grow even over 110% of its virtual size,
because the free gaps in the image get too small to allocate new
continuous clusters. So it allocates new space at the end of the image.
Disabling discard is not an option, as discard is needed to keep the
incremental backup size as low as possible. Without discard, the
incremental backups would become large, as qemu thinks it's just dirty
blocks but it doesn't know the blocks are unneeded.
So we need to avoid fragmentation but also 'empty' the unneeded blocks in
the image to have a small incremental backup.
In addition, we also want to send the discards further down the stack, so
the underlying blocks are still discarded.
Therefor we introduce a new qcow2 option "discard-no-unref".
When setting this option to true, discards will no longer have the qcow2
driver relinquish cluster allocations. Other than that, the request is
handled as normal: All clusters in range are marked as zero, and, if
pass-discard-request is true, it is passed further down the stack.
The only difference is that the now-zero clusters are preallocated
instead of being unallocated.
This will avoid fragmentation on the qcow2 image.
Fixes: https://gitlab.com/qemu-project/qemu/-/issues/1621
Signed-off-by: Jean-Louis Dupond <jean-louis@dupond.be>
Message-Id: <20230605084523.34134-2-jean-louis@dupond.be>
Reviewed-by: Hanna Czenczek <hreitz@redhat.com>
Signed-off-by: Hanna Czenczek <hreitz@redhat.com>
2023-06-05 10:45:24 +02:00
|
|
|
if (keep_reference) {
|
|
|
|
new_l2_entry = old_l2_entry;
|
|
|
|
} else {
|
|
|
|
new_l2_entry = 0;
|
|
|
|
}
|
2020-07-10 18:13:05 +02:00
|
|
|
new_l2_bitmap = QCOW_L2_BITMAP_ALL_ZEROES;
|
|
|
|
} else {
|
qcow2: add discard-no-unref option
When we for example have a sparse qcow2 image and discard: unmap is enabled,
there can be a lot of fragmentation in the image after some time. Especially on VM's
that do a lot of writes/deletes.
This causes the qcow2 image to grow even over 110% of its virtual size,
because the free gaps in the image get too small to allocate new
continuous clusters. So it allocates new space at the end of the image.
Disabling discard is not an option, as discard is needed to keep the
incremental backup size as low as possible. Without discard, the
incremental backups would become large, as qemu thinks it's just dirty
blocks but it doesn't know the blocks are unneeded.
So we need to avoid fragmentation but also 'empty' the unneeded blocks in
the image to have a small incremental backup.
In addition, we also want to send the discards further down the stack, so
the underlying blocks are still discarded.
Therefor we introduce a new qcow2 option "discard-no-unref".
When setting this option to true, discards will no longer have the qcow2
driver relinquish cluster allocations. Other than that, the request is
handled as normal: All clusters in range are marked as zero, and, if
pass-discard-request is true, it is passed further down the stack.
The only difference is that the now-zero clusters are preallocated
instead of being unallocated.
This will avoid fragmentation on the qcow2 image.
Fixes: https://gitlab.com/qemu-project/qemu/-/issues/1621
Signed-off-by: Jean-Louis Dupond <jean-louis@dupond.be>
Message-Id: <20230605084523.34134-2-jean-louis@dupond.be>
Reviewed-by: Hanna Czenczek <hreitz@redhat.com>
Signed-off-by: Hanna Czenczek <hreitz@redhat.com>
2023-06-05 10:45:24 +02:00
|
|
|
if (s->qcow_version >= 3) {
|
|
|
|
if (keep_reference) {
|
|
|
|
new_l2_entry |= QCOW_OFLAG_ZERO;
|
|
|
|
} else {
|
|
|
|
new_l2_entry = QCOW_OFLAG_ZERO;
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
new_l2_entry = 0;
|
|
|
|
}
|
2017-05-07 02:05:42 +02:00
|
|
|
}
|
2020-07-10 18:13:05 +02:00
|
|
|
}
|
2017-05-07 02:05:42 +02:00
|
|
|
|
2020-07-10 18:13:05 +02:00
|
|
|
if (old_l2_entry == new_l2_entry && old_l2_bitmap == new_l2_bitmap) {
|
|
|
|
continue;
|
2011-01-26 16:56:48 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
/* First remove L2 entries */
|
2018-02-05 15:33:24 +01:00
|
|
|
qcow2_cache_entry_mark_dirty(s->l2_table_cache, l2_slice);
|
2020-07-10 18:13:05 +02:00
|
|
|
set_l2_entry(s, l2_slice, l2_index + i, new_l2_entry);
|
|
|
|
if (has_subclusters(s)) {
|
|
|
|
set_l2_bitmap(s, l2_slice, l2_index + i, new_l2_bitmap);
|
2014-02-08 14:38:33 +01:00
|
|
|
}
|
qcow2: add discard-no-unref option
When we for example have a sparse qcow2 image and discard: unmap is enabled,
there can be a lot of fragmentation in the image after some time. Especially on VM's
that do a lot of writes/deletes.
This causes the qcow2 image to grow even over 110% of its virtual size,
because the free gaps in the image get too small to allocate new
continuous clusters. So it allocates new space at the end of the image.
Disabling discard is not an option, as discard is needed to keep the
incremental backup size as low as possible. Without discard, the
incremental backups would become large, as qemu thinks it's just dirty
blocks but it doesn't know the blocks are unneeded.
So we need to avoid fragmentation but also 'empty' the unneeded blocks in
the image to have a small incremental backup.
In addition, we also want to send the discards further down the stack, so
the underlying blocks are still discarded.
Therefor we introduce a new qcow2 option "discard-no-unref".
When setting this option to true, discards will no longer have the qcow2
driver relinquish cluster allocations. Other than that, the request is
handled as normal: All clusters in range are marked as zero, and, if
pass-discard-request is true, it is passed further down the stack.
The only difference is that the now-zero clusters are preallocated
instead of being unallocated.
This will avoid fragmentation on the qcow2 image.
Fixes: https://gitlab.com/qemu-project/qemu/-/issues/1621
Signed-off-by: Jean-Louis Dupond <jean-louis@dupond.be>
Message-Id: <20230605084523.34134-2-jean-louis@dupond.be>
Reviewed-by: Hanna Czenczek <hreitz@redhat.com>
Signed-off-by: Hanna Czenczek <hreitz@redhat.com>
2023-06-05 10:45:24 +02:00
|
|
|
if (!keep_reference) {
|
|
|
|
/* Then decrease the refcount */
|
|
|
|
qcow2_free_any_cluster(bs, old_l2_entry, type);
|
|
|
|
} else if (s->discard_passthrough[type] &&
|
|
|
|
(cluster_type == QCOW2_CLUSTER_NORMAL ||
|
|
|
|
cluster_type == QCOW2_CLUSTER_ZERO_ALLOC)) {
|
|
|
|
/* If we keep the reference, pass on the discard still */
|
|
|
|
bdrv_pdiscard(s->data_file, old_l2_entry & L2E_OFFSET_MASK,
|
|
|
|
s->cluster_size);
|
2023-10-03 14:52:37 +02:00
|
|
|
}
|
2011-01-26 16:56:48 +01:00
|
|
|
}
|
|
|
|
|
2018-02-05 15:33:24 +01:00
|
|
|
qcow2_cache_put(s->l2_table_cache, (void **) &l2_slice);
|
2011-01-26 16:56:48 +01:00
|
|
|
|
|
|
|
return nb_clusters;
|
|
|
|
}
|
|
|
|
|
qcow2: Discard/zero clusters by byte count
Passing a byte offset, but sector count, when we ultimately
want to operate on cluster granularity, is madness. Clean up
the external interfaces to take both offset and count as bytes,
while still keeping the assertion added previously that the
caller must align the values to a cluster. Then rename things
to make sure backports don't get confused by changed units:
instead of qcow2_discard_clusters() and qcow2_zero_clusters(),
we now have qcow2_cluster_discard() and qcow2_cluster_zeroize().
The internal functions still operate on clusters at a time, and
return an int for number of cleared clusters; but on an image
with 2M clusters, a single L2 table holds 256k entries that each
represent a 2M cluster, totalling well over INT_MAX bytes if we
ever had a request for that many bytes at once. All our callers
currently limit themselves to 32-bit bytes (and therefore fewer
clusters), but by making this function 64-bit clean, we have one
less place to clean up if we later improve the block layer to
support 64-bit bytes through all operations (with the block layer
auto-fragmenting on behalf of more-limited drivers), rather than
the current state where some interfaces are artificially limited
to INT_MAX at a time.
Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Message-id: 20170507000552.20847-13-eblake@redhat.com
Signed-off-by: Max Reitz <mreitz@redhat.com>
2017-05-07 02:05:52 +02:00
|
|
|
int qcow2_cluster_discard(BlockDriverState *bs, uint64_t offset,
|
|
|
|
uint64_t bytes, enum qcow2_discard_type type,
|
|
|
|
bool full_discard)
|
2011-01-26 16:56:48 +01:00
|
|
|
{
|
2015-09-07 17:12:56 +02:00
|
|
|
BDRVQcow2State *s = bs->opaque;
|
qcow2: Discard/zero clusters by byte count
Passing a byte offset, but sector count, when we ultimately
want to operate on cluster granularity, is madness. Clean up
the external interfaces to take both offset and count as bytes,
while still keeping the assertion added previously that the
caller must align the values to a cluster. Then rename things
to make sure backports don't get confused by changed units:
instead of qcow2_discard_clusters() and qcow2_zero_clusters(),
we now have qcow2_cluster_discard() and qcow2_cluster_zeroize().
The internal functions still operate on clusters at a time, and
return an int for number of cleared clusters; but on an image
with 2M clusters, a single L2 table holds 256k entries that each
represent a 2M cluster, totalling well over INT_MAX bytes if we
ever had a request for that many bytes at once. All our callers
currently limit themselves to 32-bit bytes (and therefore fewer
clusters), but by making this function 64-bit clean, we have one
less place to clean up if we later improve the block layer to
support 64-bit bytes through all operations (with the block layer
auto-fragmenting on behalf of more-limited drivers), rather than
the current state where some interfaces are artificially limited
to INT_MAX at a time.
Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Message-id: 20170507000552.20847-13-eblake@redhat.com
Signed-off-by: Max Reitz <mreitz@redhat.com>
2017-05-07 02:05:52 +02:00
|
|
|
uint64_t end_offset = offset + bytes;
|
2015-09-14 16:39:47 +02:00
|
|
|
uint64_t nb_clusters;
|
qcow2: Discard/zero clusters by byte count
Passing a byte offset, but sector count, when we ultimately
want to operate on cluster granularity, is madness. Clean up
the external interfaces to take both offset and count as bytes,
while still keeping the assertion added previously that the
caller must align the values to a cluster. Then rename things
to make sure backports don't get confused by changed units:
instead of qcow2_discard_clusters() and qcow2_zero_clusters(),
we now have qcow2_cluster_discard() and qcow2_cluster_zeroize().
The internal functions still operate on clusters at a time, and
return an int for number of cleared clusters; but on an image
with 2M clusters, a single L2 table holds 256k entries that each
represent a 2M cluster, totalling well over INT_MAX bytes if we
ever had a request for that many bytes at once. All our callers
currently limit themselves to 32-bit bytes (and therefore fewer
clusters), but by making this function 64-bit clean, we have one
less place to clean up if we later improve the block layer to
support 64-bit bytes through all operations (with the block layer
auto-fragmenting on behalf of more-limited drivers), rather than
the current state where some interfaces are artificially limited
to INT_MAX at a time.
Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Message-id: 20170507000552.20847-13-eblake@redhat.com
Signed-off-by: Max Reitz <mreitz@redhat.com>
2017-05-07 02:05:52 +02:00
|
|
|
int64_t cleared;
|
2011-01-26 16:56:48 +01:00
|
|
|
int ret;
|
|
|
|
|
2017-05-07 02:05:51 +02:00
|
|
|
/* Caller must pass aligned values, except at image end */
|
2017-03-31 20:53:55 +02:00
|
|
|
assert(QEMU_IS_ALIGNED(offset, s->cluster_size));
|
2017-05-07 02:05:51 +02:00
|
|
|
assert(QEMU_IS_ALIGNED(end_offset, s->cluster_size) ||
|
|
|
|
end_offset == bs->total_sectors << BDRV_SECTOR_BITS);
|
2011-01-26 16:56:48 +01:00
|
|
|
|
qcow2: Discard/zero clusters by byte count
Passing a byte offset, but sector count, when we ultimately
want to operate on cluster granularity, is madness. Clean up
the external interfaces to take both offset and count as bytes,
while still keeping the assertion added previously that the
caller must align the values to a cluster. Then rename things
to make sure backports don't get confused by changed units:
instead of qcow2_discard_clusters() and qcow2_zero_clusters(),
we now have qcow2_cluster_discard() and qcow2_cluster_zeroize().
The internal functions still operate on clusters at a time, and
return an int for number of cleared clusters; but on an image
with 2M clusters, a single L2 table holds 256k entries that each
represent a 2M cluster, totalling well over INT_MAX bytes if we
ever had a request for that many bytes at once. All our callers
currently limit themselves to 32-bit bytes (and therefore fewer
clusters), but by making this function 64-bit clean, we have one
less place to clean up if we later improve the block layer to
support 64-bit bytes through all operations (with the block layer
auto-fragmenting on behalf of more-limited drivers), rather than
the current state where some interfaces are artificially limited
to INT_MAX at a time.
Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Message-id: 20170507000552.20847-13-eblake@redhat.com
Signed-off-by: Max Reitz <mreitz@redhat.com>
2017-05-07 02:05:52 +02:00
|
|
|
nb_clusters = size_to_clusters(s, bytes);
|
2011-01-26 16:56:48 +01:00
|
|
|
|
2013-06-19 13:44:20 +02:00
|
|
|
s->cache_discards = true;
|
|
|
|
|
2018-02-05 15:33:24 +01:00
|
|
|
/* Each L2 slice is handled by its own loop iteration */
|
2011-01-26 16:56:48 +01:00
|
|
|
while (nb_clusters > 0) {
|
2018-02-05 15:33:24 +01:00
|
|
|
cleared = discard_in_l2_slice(bs, offset, nb_clusters, type,
|
|
|
|
full_discard);
|
qcow2: Discard/zero clusters by byte count
Passing a byte offset, but sector count, when we ultimately
want to operate on cluster granularity, is madness. Clean up
the external interfaces to take both offset and count as bytes,
while still keeping the assertion added previously that the
caller must align the values to a cluster. Then rename things
to make sure backports don't get confused by changed units:
instead of qcow2_discard_clusters() and qcow2_zero_clusters(),
we now have qcow2_cluster_discard() and qcow2_cluster_zeroize().
The internal functions still operate on clusters at a time, and
return an int for number of cleared clusters; but on an image
with 2M clusters, a single L2 table holds 256k entries that each
represent a 2M cluster, totalling well over INT_MAX bytes if we
ever had a request for that many bytes at once. All our callers
currently limit themselves to 32-bit bytes (and therefore fewer
clusters), but by making this function 64-bit clean, we have one
less place to clean up if we later improve the block layer to
support 64-bit bytes through all operations (with the block layer
auto-fragmenting on behalf of more-limited drivers), rather than
the current state where some interfaces are artificially limited
to INT_MAX at a time.
Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Message-id: 20170507000552.20847-13-eblake@redhat.com
Signed-off-by: Max Reitz <mreitz@redhat.com>
2017-05-07 02:05:52 +02:00
|
|
|
if (cleared < 0) {
|
|
|
|
ret = cleared;
|
2013-06-19 13:44:20 +02:00
|
|
|
goto fail;
|
2011-01-26 16:56:48 +01:00
|
|
|
}
|
|
|
|
|
qcow2: Discard/zero clusters by byte count
Passing a byte offset, but sector count, when we ultimately
want to operate on cluster granularity, is madness. Clean up
the external interfaces to take both offset and count as bytes,
while still keeping the assertion added previously that the
caller must align the values to a cluster. Then rename things
to make sure backports don't get confused by changed units:
instead of qcow2_discard_clusters() and qcow2_zero_clusters(),
we now have qcow2_cluster_discard() and qcow2_cluster_zeroize().
The internal functions still operate on clusters at a time, and
return an int for number of cleared clusters; but on an image
with 2M clusters, a single L2 table holds 256k entries that each
represent a 2M cluster, totalling well over INT_MAX bytes if we
ever had a request for that many bytes at once. All our callers
currently limit themselves to 32-bit bytes (and therefore fewer
clusters), but by making this function 64-bit clean, we have one
less place to clean up if we later improve the block layer to
support 64-bit bytes through all operations (with the block layer
auto-fragmenting on behalf of more-limited drivers), rather than
the current state where some interfaces are artificially limited
to INT_MAX at a time.
Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Message-id: 20170507000552.20847-13-eblake@redhat.com
Signed-off-by: Max Reitz <mreitz@redhat.com>
2017-05-07 02:05:52 +02:00
|
|
|
nb_clusters -= cleared;
|
|
|
|
offset += (cleared * s->cluster_size);
|
2011-01-26 16:56:48 +01:00
|
|
|
}
|
|
|
|
|
2013-06-19 13:44:20 +02:00
|
|
|
ret = 0;
|
|
|
|
fail:
|
|
|
|
s->cache_discards = false;
|
|
|
|
qcow2_process_discards(bs, ret);
|
|
|
|
|
|
|
|
return ret;
|
2011-01-26 16:56:48 +01:00
|
|
|
}
|
2012-03-20 15:12:58 +01:00
|
|
|
|
|
|
|
/*
|
|
|
|
* This zeroes as many clusters of nb_clusters as possible at once (i.e.
|
2018-02-05 15:33:25 +01:00
|
|
|
* all clusters in the same L2 slice) and returns the number of zeroed
|
2012-03-20 15:12:58 +01:00
|
|
|
* clusters.
|
|
|
|
*/
|
2023-09-29 16:51:49 +02:00
|
|
|
static int coroutine_fn GRAPH_RDLOCK
|
2023-06-01 13:51:43 +02:00
|
|
|
zero_in_l2_slice(BlockDriverState *bs, uint64_t offset,
|
|
|
|
uint64_t nb_clusters, int flags)
|
2012-03-20 15:12:58 +01:00
|
|
|
{
|
2015-09-07 17:12:56 +02:00
|
|
|
BDRVQcow2State *s = bs->opaque;
|
2018-02-05 15:33:25 +01:00
|
|
|
uint64_t *l2_slice;
|
2012-03-20 15:12:58 +01:00
|
|
|
int l2_index;
|
|
|
|
int ret;
|
|
|
|
int i;
|
|
|
|
|
2018-02-05 15:33:25 +01:00
|
|
|
ret = get_cluster_table(bs, offset, &l2_slice, &l2_index);
|
2012-03-20 15:12:58 +01:00
|
|
|
if (ret < 0) {
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2018-02-05 15:33:25 +01:00
|
|
|
/* Limit nb_clusters to one L2 slice */
|
|
|
|
nb_clusters = MIN(nb_clusters, s->l2_slice_size - l2_index);
|
2015-09-14 16:39:47 +02:00
|
|
|
assert(nb_clusters <= INT_MAX);
|
2012-03-20 15:12:58 +01:00
|
|
|
|
|
|
|
for (i = 0; i < nb_clusters; i++) {
|
2020-07-10 18:13:04 +02:00
|
|
|
uint64_t old_l2_entry = get_l2_entry(s, l2_slice, l2_index + i);
|
|
|
|
uint64_t old_l2_bitmap = get_l2_bitmap(s, l2_slice, l2_index + i);
|
|
|
|
QCow2ClusterType type = qcow2_get_cluster_type(bs, old_l2_entry);
|
|
|
|
bool unmap = (type == QCOW2_CLUSTER_COMPRESSED) ||
|
|
|
|
((flags & BDRV_REQ_MAY_UNMAP) && qcow2_cluster_is_allocated(type));
|
2023-10-03 14:52:37 +02:00
|
|
|
bool keep_reference =
|
|
|
|
(s->discard_no_unref && type != QCOW2_CLUSTER_COMPRESSED);
|
|
|
|
uint64_t new_l2_entry = old_l2_entry;
|
2020-07-10 18:13:04 +02:00
|
|
|
uint64_t new_l2_bitmap = old_l2_bitmap;
|
|
|
|
|
2023-10-03 14:52:37 +02:00
|
|
|
if (unmap && !keep_reference) {
|
|
|
|
new_l2_entry = 0;
|
|
|
|
}
|
|
|
|
|
2020-07-10 18:13:04 +02:00
|
|
|
if (has_subclusters(s)) {
|
|
|
|
new_l2_bitmap = QCOW_L2_BITMAP_ALL_ZEROES;
|
|
|
|
} else {
|
|
|
|
new_l2_entry |= QCOW_OFLAG_ZERO;
|
|
|
|
}
|
2012-03-20 15:12:58 +01:00
|
|
|
|
2020-07-10 18:13:04 +02:00
|
|
|
if (old_l2_entry == new_l2_entry && old_l2_bitmap == new_l2_bitmap) {
|
qcow2: Optimize zero_single_l2() to minimize L2 churn
Similar to discard_single_l2(), we should try to avoid dirtying
the L2 cache when the cluster we are changing already has the
right characteristics.
Note that by the time we get to zero_single_l2(), BDRV_REQ_MAY_UNMAP
is a requirement to unallocate a cluster (this is because the block
layer clears that flag if discard.* flags during open requested that
we never punch holes - see the conversation around commit 170f4b2e,
https://lists.gnu.org/archive/html/qemu-devel/2016-09/msg07306.html).
Therefore, this patch can only reuse a zero cluster as-is if either
unmapping is not requested, or if the zero cluster was not associated
with an allocation.
Technically, there are some cases where an unallocated cluster
already reads as all zeroes (namely, when there is no backing file
[easy: check bs->backing], or when the backing file also reads as
zeroes [harder: we can't check bdrv_get_block_status since we are
already holding the lock]), where the guest would not immediately see
a difference if we left that cluster unallocated. But if the user
did not request unmapping, leaving an unallocated cluster is wrong;
and even if the user DID request unmapping, keeping a cluster
unallocated risks a subtle semantic change of guest-visible contents
if a backing file is later added, and it is not worth auditing
whether all internal uses such as mirror properly avoid an unmap
request. Thus, this patch is intentionally limited to just clusters
that are already marked as zero.
Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Message-id: 20170507000552.20847-8-eblake@redhat.com
Signed-off-by: Max Reitz <mreitz@redhat.com>
2017-05-07 02:05:47 +02:00
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
qcow2: Fix corruption on write_zeroes with MAY_UNMAP
Commit 205fa50750 ("qcow2: Add subcluster support to zero_in_l2_slice()")
introduced a subtle change to code in zero_in_l2_slice:
It swapped the order of
1. qcow2_cache_entry_mark_dirty(s->l2_table_cache, l2_slice);
2. set_l2_entry(s, l2_slice, l2_index + i, QCOW_OFLAG_ZERO);
3. qcow2_free_any_clusters(bs, old_offset, 1, QCOW2_DISCARD_REQUEST);
To
1. qcow2_cache_entry_mark_dirty(s->l2_table_cache, l2_slice);
2. qcow2_free_any_clusters(bs, old_offset, 1, QCOW2_DISCARD_REQUEST);
3. set_l2_entry(s, l2_slice, l2_index + i, QCOW_OFLAG_ZERO);
It seems harmless, however the call to qcow2_free_any_clusters can
trigger a cache flush which can mark the L2 table as clean, and
assuming that this was the last write to it, a stale version of it
will remain on the disk.
Now we have a valid L2 entry pointing to a freed cluster. Oops.
Fixes: 205fa50750 ("qcow2: Add subcluster support to zero_in_l2_slice()")
Signed-off-by: Maxim Levitsky <mlevitsk@redhat.com>
[ kwolf: Fixed to restore the correct original order from before
205fa50750; added comments like in discard_in_l2_slice(). ]
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Message-Id: <20201124092815.39056-1-kwolf@redhat.com>
Reviewed-by: Alberto Garcia <berto@igalia.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2020-11-24 10:28:15 +01:00
|
|
|
/* First update L2 entries */
|
2018-02-05 15:33:25 +01:00
|
|
|
qcow2_cache_entry_mark_dirty(s->l2_table_cache, l2_slice);
|
2020-07-10 18:13:04 +02:00
|
|
|
set_l2_entry(s, l2_slice, l2_index + i, new_l2_entry);
|
|
|
|
if (has_subclusters(s)) {
|
|
|
|
set_l2_bitmap(s, l2_slice, l2_index + i, new_l2_bitmap);
|
2012-03-20 15:12:58 +01:00
|
|
|
}
|
qcow2: Fix corruption on write_zeroes with MAY_UNMAP
Commit 205fa50750 ("qcow2: Add subcluster support to zero_in_l2_slice()")
introduced a subtle change to code in zero_in_l2_slice:
It swapped the order of
1. qcow2_cache_entry_mark_dirty(s->l2_table_cache, l2_slice);
2. set_l2_entry(s, l2_slice, l2_index + i, QCOW_OFLAG_ZERO);
3. qcow2_free_any_clusters(bs, old_offset, 1, QCOW2_DISCARD_REQUEST);
To
1. qcow2_cache_entry_mark_dirty(s->l2_table_cache, l2_slice);
2. qcow2_free_any_clusters(bs, old_offset, 1, QCOW2_DISCARD_REQUEST);
3. set_l2_entry(s, l2_slice, l2_index + i, QCOW_OFLAG_ZERO);
It seems harmless, however the call to qcow2_free_any_clusters can
trigger a cache flush which can mark the L2 table as clean, and
assuming that this was the last write to it, a stale version of it
will remain on the disk.
Now we have a valid L2 entry pointing to a freed cluster. Oops.
Fixes: 205fa50750 ("qcow2: Add subcluster support to zero_in_l2_slice()")
Signed-off-by: Maxim Levitsky <mlevitsk@redhat.com>
[ kwolf: Fixed to restore the correct original order from before
205fa50750; added comments like in discard_in_l2_slice(). ]
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Message-Id: <20201124092815.39056-1-kwolf@redhat.com>
Reviewed-by: Alberto Garcia <berto@igalia.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2020-11-24 10:28:15 +01:00
|
|
|
|
|
|
|
if (unmap) {
|
2023-10-03 14:52:37 +02:00
|
|
|
if (!keep_reference) {
|
|
|
|
/* Then decrease the refcount */
|
|
|
|
qcow2_free_any_cluster(bs, old_l2_entry, QCOW2_DISCARD_REQUEST);
|
|
|
|
} else if (s->discard_passthrough[QCOW2_DISCARD_REQUEST] &&
|
|
|
|
(type == QCOW2_CLUSTER_NORMAL ||
|
|
|
|
type == QCOW2_CLUSTER_ZERO_ALLOC)) {
|
|
|
|
/* If we keep the reference, pass on the discard still */
|
|
|
|
bdrv_pdiscard(s->data_file, old_l2_entry & L2E_OFFSET_MASK,
|
|
|
|
s->cluster_size);
|
|
|
|
}
|
qcow2: Fix corruption on write_zeroes with MAY_UNMAP
Commit 205fa50750 ("qcow2: Add subcluster support to zero_in_l2_slice()")
introduced a subtle change to code in zero_in_l2_slice:
It swapped the order of
1. qcow2_cache_entry_mark_dirty(s->l2_table_cache, l2_slice);
2. set_l2_entry(s, l2_slice, l2_index + i, QCOW_OFLAG_ZERO);
3. qcow2_free_any_clusters(bs, old_offset, 1, QCOW2_DISCARD_REQUEST);
To
1. qcow2_cache_entry_mark_dirty(s->l2_table_cache, l2_slice);
2. qcow2_free_any_clusters(bs, old_offset, 1, QCOW2_DISCARD_REQUEST);
3. set_l2_entry(s, l2_slice, l2_index + i, QCOW_OFLAG_ZERO);
It seems harmless, however the call to qcow2_free_any_clusters can
trigger a cache flush which can mark the L2 table as clean, and
assuming that this was the last write to it, a stale version of it
will remain on the disk.
Now we have a valid L2 entry pointing to a freed cluster. Oops.
Fixes: 205fa50750 ("qcow2: Add subcluster support to zero_in_l2_slice()")
Signed-off-by: Maxim Levitsky <mlevitsk@redhat.com>
[ kwolf: Fixed to restore the correct original order from before
205fa50750; added comments like in discard_in_l2_slice(). ]
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Message-Id: <20201124092815.39056-1-kwolf@redhat.com>
Reviewed-by: Alberto Garcia <berto@igalia.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2020-11-24 10:28:15 +01:00
|
|
|
}
|
2012-03-20 15:12:58 +01:00
|
|
|
}
|
|
|
|
|
2018-02-05 15:33:25 +01:00
|
|
|
qcow2_cache_put(s->l2_table_cache, (void **) &l2_slice);
|
2012-03-20 15:12:58 +01:00
|
|
|
|
|
|
|
return nb_clusters;
|
|
|
|
}
|
|
|
|
|
2023-09-29 16:51:49 +02:00
|
|
|
static int coroutine_fn GRAPH_RDLOCK
|
2023-03-09 09:44:55 +01:00
|
|
|
zero_l2_subclusters(BlockDriverState *bs, uint64_t offset,
|
|
|
|
unsigned nb_subclusters)
|
2020-07-10 18:13:10 +02:00
|
|
|
{
|
|
|
|
BDRVQcow2State *s = bs->opaque;
|
|
|
|
uint64_t *l2_slice;
|
|
|
|
uint64_t old_l2_bitmap, l2_bitmap;
|
|
|
|
int l2_index, ret, sc = offset_to_sc_index(s, offset);
|
|
|
|
|
|
|
|
/* For full clusters use zero_in_l2_slice() instead */
|
|
|
|
assert(nb_subclusters > 0 && nb_subclusters < s->subclusters_per_cluster);
|
|
|
|
assert(sc + nb_subclusters <= s->subclusters_per_cluster);
|
|
|
|
assert(offset_into_subcluster(s, offset) == 0);
|
|
|
|
|
|
|
|
ret = get_cluster_table(bs, offset, &l2_slice, &l2_index);
|
|
|
|
if (ret < 0) {
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
switch (qcow2_get_cluster_type(bs, get_l2_entry(s, l2_slice, l2_index))) {
|
|
|
|
case QCOW2_CLUSTER_COMPRESSED:
|
|
|
|
ret = -ENOTSUP; /* We cannot partially zeroize compressed clusters */
|
|
|
|
goto out;
|
|
|
|
case QCOW2_CLUSTER_NORMAL:
|
|
|
|
case QCOW2_CLUSTER_UNALLOCATED:
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
g_assert_not_reached();
|
|
|
|
}
|
|
|
|
|
|
|
|
old_l2_bitmap = l2_bitmap = get_l2_bitmap(s, l2_slice, l2_index);
|
|
|
|
|
|
|
|
l2_bitmap |= QCOW_OFLAG_SUB_ZERO_RANGE(sc, sc + nb_subclusters);
|
|
|
|
l2_bitmap &= ~QCOW_OFLAG_SUB_ALLOC_RANGE(sc, sc + nb_subclusters);
|
|
|
|
|
|
|
|
if (old_l2_bitmap != l2_bitmap) {
|
|
|
|
set_l2_bitmap(s, l2_slice, l2_index, l2_bitmap);
|
|
|
|
qcow2_cache_entry_mark_dirty(s->l2_table_cache, l2_slice);
|
|
|
|
}
|
|
|
|
|
|
|
|
ret = 0;
|
|
|
|
out:
|
|
|
|
qcow2_cache_put(s->l2_table_cache, (void **) &l2_slice);
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2022-09-22 10:49:12 +02:00
|
|
|
int coroutine_fn qcow2_subcluster_zeroize(BlockDriverState *bs, uint64_t offset,
|
|
|
|
uint64_t bytes, int flags)
|
2012-03-20 15:12:58 +01:00
|
|
|
{
|
2015-09-07 17:12:56 +02:00
|
|
|
BDRVQcow2State *s = bs->opaque;
|
qcow2: Discard/zero clusters by byte count
Passing a byte offset, but sector count, when we ultimately
want to operate on cluster granularity, is madness. Clean up
the external interfaces to take both offset and count as bytes,
while still keeping the assertion added previously that the
caller must align the values to a cluster. Then rename things
to make sure backports don't get confused by changed units:
instead of qcow2_discard_clusters() and qcow2_zero_clusters(),
we now have qcow2_cluster_discard() and qcow2_cluster_zeroize().
The internal functions still operate on clusters at a time, and
return an int for number of cleared clusters; but on an image
with 2M clusters, a single L2 table holds 256k entries that each
represent a 2M cluster, totalling well over INT_MAX bytes if we
ever had a request for that many bytes at once. All our callers
currently limit themselves to 32-bit bytes (and therefore fewer
clusters), but by making this function 64-bit clean, we have one
less place to clean up if we later improve the block layer to
support 64-bit bytes through all operations (with the block layer
auto-fragmenting on behalf of more-limited drivers), rather than
the current state where some interfaces are artificially limited
to INT_MAX at a time.
Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Message-id: 20170507000552.20847-13-eblake@redhat.com
Signed-off-by: Max Reitz <mreitz@redhat.com>
2017-05-07 02:05:52 +02:00
|
|
|
uint64_t end_offset = offset + bytes;
|
2015-09-14 16:39:47 +02:00
|
|
|
uint64_t nb_clusters;
|
2020-07-10 18:13:10 +02:00
|
|
|
unsigned head, tail;
|
qcow2: Discard/zero clusters by byte count
Passing a byte offset, but sector count, when we ultimately
want to operate on cluster granularity, is madness. Clean up
the external interfaces to take both offset and count as bytes,
while still keeping the assertion added previously that the
caller must align the values to a cluster. Then rename things
to make sure backports don't get confused by changed units:
instead of qcow2_discard_clusters() and qcow2_zero_clusters(),
we now have qcow2_cluster_discard() and qcow2_cluster_zeroize().
The internal functions still operate on clusters at a time, and
return an int for number of cleared clusters; but on an image
with 2M clusters, a single L2 table holds 256k entries that each
represent a 2M cluster, totalling well over INT_MAX bytes if we
ever had a request for that many bytes at once. All our callers
currently limit themselves to 32-bit bytes (and therefore fewer
clusters), but by making this function 64-bit clean, we have one
less place to clean up if we later improve the block layer to
support 64-bit bytes through all operations (with the block layer
auto-fragmenting on behalf of more-limited drivers), rather than
the current state where some interfaces are artificially limited
to INT_MAX at a time.
Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Message-id: 20170507000552.20847-13-eblake@redhat.com
Signed-off-by: Max Reitz <mreitz@redhat.com>
2017-05-07 02:05:52 +02:00
|
|
|
int64_t cleared;
|
2012-03-20 15:12:58 +01:00
|
|
|
int ret;
|
|
|
|
|
2019-02-22 14:29:38 +01:00
|
|
|
/* If we have to stay in sync with an external data file, zero out
|
|
|
|
* s->data_file first. */
|
|
|
|
if (data_file_is_raw(bs)) {
|
|
|
|
assert(has_data_file(bs));
|
|
|
|
ret = bdrv_co_pwrite_zeroes(s->data_file, offset, bytes, flags);
|
|
|
|
if (ret < 0) {
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2017-05-07 02:05:51 +02:00
|
|
|
/* Caller must pass aligned values, except at image end */
|
2020-07-10 18:13:10 +02:00
|
|
|
assert(offset_into_subcluster(s, offset) == 0);
|
|
|
|
assert(offset_into_subcluster(s, end_offset) == 0 ||
|
2020-04-24 14:54:42 +02:00
|
|
|
end_offset >= bs->total_sectors << BDRV_SECTOR_BITS);
|
2017-05-07 02:05:51 +02:00
|
|
|
|
2020-07-21 15:55:19 +02:00
|
|
|
/*
|
|
|
|
* The zero flag is only supported by version 3 and newer. However, if we
|
|
|
|
* have no backing file, we can resort to discard in version 2.
|
|
|
|
*/
|
2012-03-20 15:12:58 +01:00
|
|
|
if (s->qcow_version < 3) {
|
2020-07-21 15:55:19 +02:00
|
|
|
if (!bs->backing) {
|
|
|
|
return qcow2_cluster_discard(bs, offset, bytes,
|
|
|
|
QCOW2_DISCARD_REQUEST, false);
|
|
|
|
}
|
2012-03-20 15:12:58 +01:00
|
|
|
return -ENOTSUP;
|
|
|
|
}
|
|
|
|
|
2020-07-10 18:13:10 +02:00
|
|
|
head = MIN(end_offset, ROUND_UP(offset, s->cluster_size)) - offset;
|
|
|
|
offset += head;
|
|
|
|
|
|
|
|
tail = (end_offset >= bs->total_sectors << BDRV_SECTOR_BITS) ? 0 :
|
|
|
|
end_offset - MAX(offset, start_of_cluster(s, end_offset));
|
|
|
|
end_offset -= tail;
|
2012-03-20 15:12:58 +01:00
|
|
|
|
2013-06-19 13:44:20 +02:00
|
|
|
s->cache_discards = true;
|
|
|
|
|
2020-07-10 18:13:10 +02:00
|
|
|
if (head) {
|
|
|
|
ret = zero_l2_subclusters(bs, offset - head,
|
|
|
|
size_to_subclusters(s, head));
|
|
|
|
if (ret < 0) {
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Each L2 slice is handled by its own loop iteration */
|
|
|
|
nb_clusters = size_to_clusters(s, end_offset - offset);
|
|
|
|
|
2012-03-20 15:12:58 +01:00
|
|
|
while (nb_clusters > 0) {
|
2018-02-05 15:33:25 +01:00
|
|
|
cleared = zero_in_l2_slice(bs, offset, nb_clusters, flags);
|
qcow2: Discard/zero clusters by byte count
Passing a byte offset, but sector count, when we ultimately
want to operate on cluster granularity, is madness. Clean up
the external interfaces to take both offset and count as bytes,
while still keeping the assertion added previously that the
caller must align the values to a cluster. Then rename things
to make sure backports don't get confused by changed units:
instead of qcow2_discard_clusters() and qcow2_zero_clusters(),
we now have qcow2_cluster_discard() and qcow2_cluster_zeroize().
The internal functions still operate on clusters at a time, and
return an int for number of cleared clusters; but on an image
with 2M clusters, a single L2 table holds 256k entries that each
represent a 2M cluster, totalling well over INT_MAX bytes if we
ever had a request for that many bytes at once. All our callers
currently limit themselves to 32-bit bytes (and therefore fewer
clusters), but by making this function 64-bit clean, we have one
less place to clean up if we later improve the block layer to
support 64-bit bytes through all operations (with the block layer
auto-fragmenting on behalf of more-limited drivers), rather than
the current state where some interfaces are artificially limited
to INT_MAX at a time.
Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Message-id: 20170507000552.20847-13-eblake@redhat.com
Signed-off-by: Max Reitz <mreitz@redhat.com>
2017-05-07 02:05:52 +02:00
|
|
|
if (cleared < 0) {
|
|
|
|
ret = cleared;
|
2013-06-19 13:44:20 +02:00
|
|
|
goto fail;
|
2012-03-20 15:12:58 +01:00
|
|
|
}
|
|
|
|
|
qcow2: Discard/zero clusters by byte count
Passing a byte offset, but sector count, when we ultimately
want to operate on cluster granularity, is madness. Clean up
the external interfaces to take both offset and count as bytes,
while still keeping the assertion added previously that the
caller must align the values to a cluster. Then rename things
to make sure backports don't get confused by changed units:
instead of qcow2_discard_clusters() and qcow2_zero_clusters(),
we now have qcow2_cluster_discard() and qcow2_cluster_zeroize().
The internal functions still operate on clusters at a time, and
return an int for number of cleared clusters; but on an image
with 2M clusters, a single L2 table holds 256k entries that each
represent a 2M cluster, totalling well over INT_MAX bytes if we
ever had a request for that many bytes at once. All our callers
currently limit themselves to 32-bit bytes (and therefore fewer
clusters), but by making this function 64-bit clean, we have one
less place to clean up if we later improve the block layer to
support 64-bit bytes through all operations (with the block layer
auto-fragmenting on behalf of more-limited drivers), rather than
the current state where some interfaces are artificially limited
to INT_MAX at a time.
Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Message-id: 20170507000552.20847-13-eblake@redhat.com
Signed-off-by: Max Reitz <mreitz@redhat.com>
2017-05-07 02:05:52 +02:00
|
|
|
nb_clusters -= cleared;
|
|
|
|
offset += (cleared * s->cluster_size);
|
2012-03-20 15:12:58 +01:00
|
|
|
}
|
|
|
|
|
2020-07-10 18:13:10 +02:00
|
|
|
if (tail) {
|
|
|
|
ret = zero_l2_subclusters(bs, end_offset, size_to_subclusters(s, tail));
|
|
|
|
if (ret < 0) {
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2013-06-19 13:44:20 +02:00
|
|
|
ret = 0;
|
|
|
|
fail:
|
|
|
|
s->cache_discards = false;
|
|
|
|
qcow2_process_discards(bs, ret);
|
|
|
|
|
|
|
|
return ret;
|
2012-03-20 15:12:58 +01:00
|
|
|
}
|
2013-09-03 10:09:52 +02:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Expands all zero clusters in a specific L1 table (or deallocates them, for
|
|
|
|
* non-backed non-pre-allocated zero clusters).
|
|
|
|
*
|
2014-10-27 11:12:53 +01:00
|
|
|
* l1_entries and *visited_l1_entries are used to keep track of progress for
|
|
|
|
* status_cb(). l1_entries contains the total number of L1 entries and
|
|
|
|
* *visited_l1_entries counts all visited L1 entries.
|
2013-09-03 10:09:52 +02:00
|
|
|
*/
|
2023-09-29 16:51:49 +02:00
|
|
|
static int GRAPH_RDLOCK
|
|
|
|
expand_zero_clusters_in_l1(BlockDriverState *bs, uint64_t *l1_table,
|
|
|
|
int l1_size, int64_t *visited_l1_entries,
|
|
|
|
int64_t l1_entries,
|
|
|
|
BlockDriverAmendStatusCB *status_cb,
|
|
|
|
void *cb_opaque)
|
2013-09-03 10:09:52 +02:00
|
|
|
{
|
2015-09-07 17:12:56 +02:00
|
|
|
BDRVQcow2State *s = bs->opaque;
|
2013-09-03 10:09:52 +02:00
|
|
|
bool is_active_l1 = (l1_table == s->l1_table);
|
2018-02-05 15:33:30 +01:00
|
|
|
uint64_t *l2_slice = NULL;
|
|
|
|
unsigned slice, slice_size2, n_slices;
|
2013-09-03 10:09:52 +02:00
|
|
|
int ret;
|
|
|
|
int i, j;
|
|
|
|
|
2020-07-10 18:13:15 +02:00
|
|
|
/* qcow2_downgrade() is not allowed in images with subclusters */
|
|
|
|
assert(!has_subclusters(s));
|
|
|
|
|
2020-07-10 18:12:54 +02:00
|
|
|
slice_size2 = s->l2_slice_size * l2_entry_size(s);
|
2018-02-05 15:33:30 +01:00
|
|
|
n_slices = s->cluster_size / slice_size2;
|
|
|
|
|
2013-09-03 10:09:52 +02:00
|
|
|
if (!is_active_l1) {
|
|
|
|
/* inactive L2 tables require a buffer to be stored in when loading
|
|
|
|
* them from disk */
|
2018-02-05 15:33:30 +01:00
|
|
|
l2_slice = qemu_try_blockalign(bs->file->bs, slice_size2);
|
|
|
|
if (l2_slice == NULL) {
|
2014-05-20 17:12:47 +02:00
|
|
|
return -ENOMEM;
|
|
|
|
}
|
2013-09-03 10:09:52 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
for (i = 0; i < l1_size; i++) {
|
|
|
|
uint64_t l2_offset = l1_table[i] & L1E_OFFSET_MASK;
|
2015-02-10 21:28:48 +01:00
|
|
|
uint64_t l2_refcount;
|
2013-09-03 10:09:52 +02:00
|
|
|
|
|
|
|
if (!l2_offset) {
|
|
|
|
/* unallocated */
|
2014-10-27 11:12:53 +01:00
|
|
|
(*visited_l1_entries)++;
|
|
|
|
if (status_cb) {
|
2015-07-27 17:51:32 +02:00
|
|
|
status_cb(bs, *visited_l1_entries, l1_entries, cb_opaque);
|
2014-10-27 11:12:53 +01:00
|
|
|
}
|
2013-09-03 10:09:52 +02:00
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
2015-01-19 21:49:03 +01:00
|
|
|
if (offset_into_cluster(s, l2_offset)) {
|
|
|
|
qcow2_signal_corruption(bs, true, -1, -1, "L2 table offset %#"
|
|
|
|
PRIx64 " unaligned (L1 index: %#x)",
|
|
|
|
l2_offset, i);
|
|
|
|
ret = -EIO;
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
|
2018-02-05 15:33:28 +01:00
|
|
|
ret = qcow2_get_refcount(bs, l2_offset >> s->cluster_bits,
|
|
|
|
&l2_refcount);
|
|
|
|
if (ret < 0) {
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
|
2018-02-05 15:33:30 +01:00
|
|
|
for (slice = 0; slice < n_slices; slice++) {
|
|
|
|
uint64_t slice_offset = l2_offset + slice * slice_size2;
|
|
|
|
bool l2_dirty = false;
|
2018-02-05 15:33:29 +01:00
|
|
|
if (is_active_l1) {
|
|
|
|
/* get active L2 tables from cache */
|
2018-02-05 15:33:30 +01:00
|
|
|
ret = qcow2_cache_get(bs, s->l2_table_cache, slice_offset,
|
|
|
|
(void **)&l2_slice);
|
2018-02-05 15:33:29 +01:00
|
|
|
} else {
|
|
|
|
/* load inactive L2 tables from disk */
|
block: Change bdrv_{pread,pwrite,pwrite_sync}() param order
Swap 'buf' and 'bytes' around for consistency with
bdrv_co_{pread,pwrite}(), and in preparation to implement these
functions using generated_co_wrapper.
Callers were updated using this Coccinelle script:
@@ expression child, offset, buf, bytes, flags; @@
- bdrv_pread(child, offset, buf, bytes, flags)
+ bdrv_pread(child, offset, bytes, buf, flags)
@@ expression child, offset, buf, bytes, flags; @@
- bdrv_pwrite(child, offset, buf, bytes, flags)
+ bdrv_pwrite(child, offset, bytes, buf, flags)
@@ expression child, offset, buf, bytes, flags; @@
- bdrv_pwrite_sync(child, offset, buf, bytes, flags)
+ bdrv_pwrite_sync(child, offset, bytes, buf, flags)
Resulting overly-long lines were then fixed by hand.
Signed-off-by: Alberto Faria <afaria@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Message-Id: <20220609152744.3891847-3-afaria@redhat.com>
Reviewed-by: Hanna Reitz <hreitz@redhat.com>
Signed-off-by: Hanna Reitz <hreitz@redhat.com>
2022-06-09 17:27:36 +02:00
|
|
|
ret = bdrv_pread(bs->file, slice_offset, slice_size2,
|
|
|
|
l2_slice, 0);
|
2018-02-05 15:33:29 +01:00
|
|
|
}
|
|
|
|
if (ret < 0) {
|
|
|
|
goto fail;
|
2013-09-03 10:09:52 +02:00
|
|
|
}
|
|
|
|
|
2018-02-05 15:33:30 +01:00
|
|
|
for (j = 0; j < s->l2_slice_size; j++) {
|
2020-07-10 18:12:48 +02:00
|
|
|
uint64_t l2_entry = get_l2_entry(s, l2_slice, j);
|
2018-02-05 15:33:29 +01:00
|
|
|
int64_t offset = l2_entry & L2E_OFFSET_MASK;
|
|
|
|
QCow2ClusterType cluster_type =
|
2019-01-17 18:42:40 +01:00
|
|
|
qcow2_get_cluster_type(bs, l2_entry);
|
2018-02-05 15:33:29 +01:00
|
|
|
|
|
|
|
if (cluster_type != QCOW2_CLUSTER_ZERO_PLAIN &&
|
|
|
|
cluster_type != QCOW2_CLUSTER_ZERO_ALLOC) {
|
2013-09-03 10:09:52 +02:00
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
2018-02-05 15:33:29 +01:00
|
|
|
if (cluster_type == QCOW2_CLUSTER_ZERO_PLAIN) {
|
|
|
|
if (!bs->backing) {
|
2020-07-10 18:13:15 +02:00
|
|
|
/*
|
|
|
|
* not backed; therefore we can simply deallocate the
|
|
|
|
* cluster. No need to call set_l2_bitmap(), this
|
|
|
|
* function doesn't support images with subclusters.
|
|
|
|
*/
|
2020-07-10 18:12:48 +02:00
|
|
|
set_l2_entry(s, l2_slice, j, 0);
|
2018-02-05 15:33:29 +01:00
|
|
|
l2_dirty = true;
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
|
|
|
offset = qcow2_alloc_clusters(bs, s->cluster_size);
|
|
|
|
if (offset < 0) {
|
|
|
|
ret = offset;
|
|
|
|
goto fail;
|
|
|
|
}
|
2014-10-27 11:12:55 +01:00
|
|
|
|
2020-01-13 17:11:46 +01:00
|
|
|
/* The offset must fit in the offset field */
|
|
|
|
assert((offset & L2E_OFFSET_MASK) == offset);
|
|
|
|
|
2018-02-05 15:33:29 +01:00
|
|
|
if (l2_refcount > 1) {
|
|
|
|
/* For shared L2 tables, set the refcount accordingly
|
|
|
|
* (it is already 1 and needs to be l2_refcount) */
|
|
|
|
ret = qcow2_update_cluster_refcount(
|
|
|
|
bs, offset >> s->cluster_bits,
|
2015-02-10 21:28:47 +01:00
|
|
|
refcount_diff(1, l2_refcount), false,
|
2014-10-27 11:12:55 +01:00
|
|
|
QCOW2_DISCARD_OTHER);
|
2018-02-05 15:33:29 +01:00
|
|
|
if (ret < 0) {
|
|
|
|
qcow2_free_clusters(bs, offset, s->cluster_size,
|
|
|
|
QCOW2_DISCARD_OTHER);
|
|
|
|
goto fail;
|
|
|
|
}
|
2014-10-27 11:12:55 +01:00
|
|
|
}
|
|
|
|
}
|
2013-09-03 10:09:52 +02:00
|
|
|
|
2018-02-05 15:33:29 +01:00
|
|
|
if (offset_into_cluster(s, offset)) {
|
2018-02-05 15:33:30 +01:00
|
|
|
int l2_index = slice * s->l2_slice_size + j;
|
2018-02-05 15:33:29 +01:00
|
|
|
qcow2_signal_corruption(
|
|
|
|
bs, true, -1, -1,
|
|
|
|
"Cluster allocation offset "
|
|
|
|
"%#" PRIx64 " unaligned (L2 offset: %#"
|
|
|
|
PRIx64 ", L2 index: %#x)", offset,
|
2018-02-05 15:33:30 +01:00
|
|
|
l2_offset, l2_index);
|
2018-02-05 15:33:29 +01:00
|
|
|
if (cluster_type == QCOW2_CLUSTER_ZERO_PLAIN) {
|
|
|
|
qcow2_free_clusters(bs, offset, s->cluster_size,
|
|
|
|
QCOW2_DISCARD_ALWAYS);
|
|
|
|
}
|
|
|
|
ret = -EIO;
|
|
|
|
goto fail;
|
2015-01-19 21:49:03 +01:00
|
|
|
}
|
|
|
|
|
2018-02-05 15:33:29 +01:00
|
|
|
ret = qcow2_pre_write_overlap_check(bs, 0, offset,
|
2019-01-15 20:39:06 +01:00
|
|
|
s->cluster_size, true);
|
2018-02-05 15:33:29 +01:00
|
|
|
if (ret < 0) {
|
|
|
|
if (cluster_type == QCOW2_CLUSTER_ZERO_PLAIN) {
|
|
|
|
qcow2_free_clusters(bs, offset, s->cluster_size,
|
|
|
|
QCOW2_DISCARD_ALWAYS);
|
|
|
|
}
|
|
|
|
goto fail;
|
2013-09-27 10:21:48 +02:00
|
|
|
}
|
2013-09-03 10:09:52 +02:00
|
|
|
|
2019-01-15 20:39:06 +01:00
|
|
|
ret = bdrv_pwrite_zeroes(s->data_file, offset,
|
|
|
|
s->cluster_size, 0);
|
2018-02-05 15:33:29 +01:00
|
|
|
if (ret < 0) {
|
|
|
|
if (cluster_type == QCOW2_CLUSTER_ZERO_PLAIN) {
|
|
|
|
qcow2_free_clusters(bs, offset, s->cluster_size,
|
|
|
|
QCOW2_DISCARD_ALWAYS);
|
|
|
|
}
|
|
|
|
goto fail;
|
2013-09-27 10:21:48 +02:00
|
|
|
}
|
2013-09-03 10:09:52 +02:00
|
|
|
|
2018-02-05 15:33:29 +01:00
|
|
|
if (l2_refcount == 1) {
|
2020-07-10 18:12:48 +02:00
|
|
|
set_l2_entry(s, l2_slice, j, offset | QCOW_OFLAG_COPIED);
|
2018-02-05 15:33:29 +01:00
|
|
|
} else {
|
2020-07-10 18:12:48 +02:00
|
|
|
set_l2_entry(s, l2_slice, j, offset);
|
2018-02-05 15:33:29 +01:00
|
|
|
}
|
2020-07-10 18:13:15 +02:00
|
|
|
/*
|
|
|
|
* No need to call set_l2_bitmap() after set_l2_entry() because
|
|
|
|
* this function doesn't support images with subclusters.
|
|
|
|
*/
|
2018-02-05 15:33:29 +01:00
|
|
|
l2_dirty = true;
|
2013-09-25 12:07:22 +02:00
|
|
|
}
|
2013-09-03 10:09:52 +02:00
|
|
|
|
2018-02-05 15:33:29 +01:00
|
|
|
if (is_active_l1) {
|
|
|
|
if (l2_dirty) {
|
2018-02-05 15:33:30 +01:00
|
|
|
qcow2_cache_entry_mark_dirty(s->l2_table_cache, l2_slice);
|
2018-02-05 15:33:29 +01:00
|
|
|
qcow2_cache_depends_on_flush(s->l2_table_cache);
|
2013-09-03 10:09:52 +02:00
|
|
|
}
|
2018-02-05 15:33:30 +01:00
|
|
|
qcow2_cache_put(s->l2_table_cache, (void **) &l2_slice);
|
2018-02-05 15:33:29 +01:00
|
|
|
} else {
|
|
|
|
if (l2_dirty) {
|
|
|
|
ret = qcow2_pre_write_overlap_check(
|
|
|
|
bs, QCOW2_OL_INACTIVE_L2 | QCOW2_OL_ACTIVE_L2,
|
2019-01-15 20:39:06 +01:00
|
|
|
slice_offset, slice_size2, false);
|
2018-02-05 15:33:29 +01:00
|
|
|
if (ret < 0) {
|
|
|
|
goto fail;
|
|
|
|
}
|
2013-09-03 10:09:52 +02:00
|
|
|
|
block: Change bdrv_{pread,pwrite,pwrite_sync}() param order
Swap 'buf' and 'bytes' around for consistency with
bdrv_co_{pread,pwrite}(), and in preparation to implement these
functions using generated_co_wrapper.
Callers were updated using this Coccinelle script:
@@ expression child, offset, buf, bytes, flags; @@
- bdrv_pread(child, offset, buf, bytes, flags)
+ bdrv_pread(child, offset, bytes, buf, flags)
@@ expression child, offset, buf, bytes, flags; @@
- bdrv_pwrite(child, offset, buf, bytes, flags)
+ bdrv_pwrite(child, offset, bytes, buf, flags)
@@ expression child, offset, buf, bytes, flags; @@
- bdrv_pwrite_sync(child, offset, buf, bytes, flags)
+ bdrv_pwrite_sync(child, offset, bytes, buf, flags)
Resulting overly-long lines were then fixed by hand.
Signed-off-by: Alberto Faria <afaria@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Message-Id: <20220609152744.3891847-3-afaria@redhat.com>
Reviewed-by: Hanna Reitz <hreitz@redhat.com>
Signed-off-by: Hanna Reitz <hreitz@redhat.com>
2022-06-09 17:27:36 +02:00
|
|
|
ret = bdrv_pwrite(bs->file, slice_offset, slice_size2,
|
|
|
|
l2_slice, 0);
|
2018-02-05 15:33:29 +01:00
|
|
|
if (ret < 0) {
|
|
|
|
goto fail;
|
|
|
|
}
|
2013-09-03 10:09:52 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2014-10-27 11:12:53 +01:00
|
|
|
|
|
|
|
(*visited_l1_entries)++;
|
|
|
|
if (status_cb) {
|
2015-07-27 17:51:32 +02:00
|
|
|
status_cb(bs, *visited_l1_entries, l1_entries, cb_opaque);
|
2014-10-27 11:12:53 +01:00
|
|
|
}
|
2013-09-03 10:09:52 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
ret = 0;
|
|
|
|
|
|
|
|
fail:
|
2018-02-05 15:33:30 +01:00
|
|
|
if (l2_slice) {
|
2013-09-03 10:09:52 +02:00
|
|
|
if (!is_active_l1) {
|
2018-02-05 15:33:30 +01:00
|
|
|
qemu_vfree(l2_slice);
|
2013-09-03 10:09:52 +02:00
|
|
|
} else {
|
2018-02-05 15:33:30 +01:00
|
|
|
qcow2_cache_put(s->l2_table_cache, (void **) &l2_slice);
|
2013-09-03 10:09:52 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* For backed images, expands all zero clusters on the image. For non-backed
|
|
|
|
* images, deallocates all non-pre-allocated zero clusters (and claims the
|
|
|
|
* allocation for pre-allocated ones). This is important for downgrading to a
|
|
|
|
* qcow2 version which doesn't yet support metadata zero clusters.
|
|
|
|
*/
|
2014-10-27 11:12:53 +01:00
|
|
|
int qcow2_expand_zero_clusters(BlockDriverState *bs,
|
2015-07-27 17:51:32 +02:00
|
|
|
BlockDriverAmendStatusCB *status_cb,
|
|
|
|
void *cb_opaque)
|
2013-09-03 10:09:52 +02:00
|
|
|
{
|
2015-09-07 17:12:56 +02:00
|
|
|
BDRVQcow2State *s = bs->opaque;
|
2013-09-03 10:09:52 +02:00
|
|
|
uint64_t *l1_table = NULL;
|
2014-10-27 11:12:53 +01:00
|
|
|
int64_t l1_entries = 0, visited_l1_entries = 0;
|
2013-09-03 10:09:52 +02:00
|
|
|
int ret;
|
|
|
|
int i, j;
|
|
|
|
|
2014-10-27 11:12:53 +01:00
|
|
|
if (status_cb) {
|
|
|
|
l1_entries = s->l1_size;
|
|
|
|
for (i = 0; i < s->nb_snapshots; i++) {
|
|
|
|
l1_entries += s->snapshots[i].l1_size;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2013-09-03 10:09:52 +02:00
|
|
|
ret = expand_zero_clusters_in_l1(bs, s->l1_table, s->l1_size,
|
2014-10-27 11:12:53 +01:00
|
|
|
&visited_l1_entries, l1_entries,
|
2015-07-27 17:51:32 +02:00
|
|
|
status_cb, cb_opaque);
|
2013-09-03 10:09:52 +02:00
|
|
|
if (ret < 0) {
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Inactive L1 tables may point to active L2 tables - therefore it is
|
|
|
|
* necessary to flush the L2 table cache before trying to access the L2
|
|
|
|
* tables pointed to by inactive L1 entries (else we might try to expand
|
|
|
|
* zero clusters that have already been expanded); furthermore, it is also
|
|
|
|
* necessary to empty the L2 table cache, since it may contain tables which
|
|
|
|
* are now going to be modified directly on disk, bypassing the cache.
|
|
|
|
* qcow2_cache_empty() does both for us. */
|
|
|
|
ret = qcow2_cache_empty(bs, s->l2_table_cache);
|
|
|
|
if (ret < 0) {
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
|
|
|
|
for (i = 0; i < s->nb_snapshots; i++) {
|
2018-03-06 17:14:08 +01:00
|
|
|
int l1_size2;
|
|
|
|
uint64_t *new_l1_table;
|
|
|
|
Error *local_err = NULL;
|
|
|
|
|
|
|
|
ret = qcow2_validate_table(bs, s->snapshots[i].l1_table_offset,
|
2020-08-28 13:08:28 +02:00
|
|
|
s->snapshots[i].l1_size, L1E_SIZE,
|
2018-03-06 17:14:08 +01:00
|
|
|
QCOW_MAX_L1_SIZE, "Snapshot L1 table",
|
|
|
|
&local_err);
|
|
|
|
if (ret < 0) {
|
|
|
|
error_report_err(local_err);
|
|
|
|
goto fail;
|
|
|
|
}
|
2013-09-03 10:09:52 +02:00
|
|
|
|
2020-08-28 13:08:28 +02:00
|
|
|
l1_size2 = s->snapshots[i].l1_size * L1E_SIZE;
|
2018-03-06 17:14:08 +01:00
|
|
|
new_l1_table = g_try_realloc(l1_table, l1_size2);
|
2018-02-09 15:42:22 +01:00
|
|
|
|
|
|
|
if (!new_l1_table) {
|
|
|
|
ret = -ENOMEM;
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
|
|
|
|
l1_table = new_l1_table;
|
2013-09-03 10:09:52 +02:00
|
|
|
|
block: Change bdrv_{pread,pwrite,pwrite_sync}() param order
Swap 'buf' and 'bytes' around for consistency with
bdrv_co_{pread,pwrite}(), and in preparation to implement these
functions using generated_co_wrapper.
Callers were updated using this Coccinelle script:
@@ expression child, offset, buf, bytes, flags; @@
- bdrv_pread(child, offset, buf, bytes, flags)
+ bdrv_pread(child, offset, bytes, buf, flags)
@@ expression child, offset, buf, bytes, flags; @@
- bdrv_pwrite(child, offset, buf, bytes, flags)
+ bdrv_pwrite(child, offset, bytes, buf, flags)
@@ expression child, offset, buf, bytes, flags; @@
- bdrv_pwrite_sync(child, offset, buf, bytes, flags)
+ bdrv_pwrite_sync(child, offset, bytes, buf, flags)
Resulting overly-long lines were then fixed by hand.
Signed-off-by: Alberto Faria <afaria@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Message-Id: <20220609152744.3891847-3-afaria@redhat.com>
Reviewed-by: Hanna Reitz <hreitz@redhat.com>
Signed-off-by: Hanna Reitz <hreitz@redhat.com>
2022-06-09 17:27:36 +02:00
|
|
|
ret = bdrv_pread(bs->file, s->snapshots[i].l1_table_offset, l1_size2,
|
|
|
|
l1_table, 0);
|
2013-09-03 10:09:52 +02:00
|
|
|
if (ret < 0) {
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
|
|
|
|
for (j = 0; j < s->snapshots[i].l1_size; j++) {
|
|
|
|
be64_to_cpus(&l1_table[j]);
|
|
|
|
}
|
|
|
|
|
|
|
|
ret = expand_zero_clusters_in_l1(bs, l1_table, s->snapshots[i].l1_size,
|
2014-10-27 11:12:53 +01:00
|
|
|
&visited_l1_entries, l1_entries,
|
2015-07-27 17:51:32 +02:00
|
|
|
status_cb, cb_opaque);
|
2013-09-03 10:09:52 +02:00
|
|
|
if (ret < 0) {
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
ret = 0;
|
|
|
|
|
|
|
|
fail:
|
|
|
|
g_free(l1_table);
|
|
|
|
return ret;
|
|
|
|
}
|
2021-09-14 14:24:47 +02:00
|
|
|
|
|
|
|
void qcow2_parse_compressed_l2_entry(BlockDriverState *bs, uint64_t l2_entry,
|
|
|
|
uint64_t *coffset, int *csize)
|
|
|
|
{
|
|
|
|
BDRVQcow2State *s = bs->opaque;
|
|
|
|
int nb_csectors;
|
|
|
|
|
|
|
|
assert(qcow2_get_cluster_type(bs, l2_entry) == QCOW2_CLUSTER_COMPRESSED);
|
|
|
|
|
|
|
|
*coffset = l2_entry & s->cluster_offset_mask;
|
|
|
|
|
|
|
|
nb_csectors = ((l2_entry >> s->csize_shift) & s->csize_mask) + 1;
|
|
|
|
*csize = nb_csectors * QCOW2_COMPRESSED_SECTOR_SIZE -
|
|
|
|
(*coffset & (QCOW2_COMPRESSED_SECTOR_SIZE - 1));
|
|
|
|
}
|