2012-06-20 08:59:32 +02:00
|
|
|
/*
|
|
|
|
* A virtio device implementing a hardware random number generator.
|
|
|
|
*
|
|
|
|
* Copyright 2012 Red Hat, Inc.
|
|
|
|
* Copyright 2012 Amit Shah <amit.shah@redhat.com>
|
|
|
|
*
|
|
|
|
* This work is licensed under the terms of the GNU GPL, version 2 or
|
|
|
|
* (at your option) any later version. See the COPYING file in the
|
|
|
|
* top-level directory.
|
|
|
|
*/
|
|
|
|
|
2016-01-26 19:17:07 +01:00
|
|
|
#include "qemu/osdep.h"
|
include/qemu/osdep.h: Don't include qapi/error.h
Commit 57cb38b included qapi/error.h into qemu/osdep.h to get the
Error typedef. Since then, we've moved to include qemu/osdep.h
everywhere. Its file comment explains: "To avoid getting into
possible circular include dependencies, this file should not include
any other QEMU headers, with the exceptions of config-host.h,
compiler.h, os-posix.h and os-win32.h, all of which are doing a
similar job to this file and are under similar constraints."
qapi/error.h doesn't do a similar job, and it doesn't adhere to
similar constraints: it includes qapi-types.h. That's in excess of
100KiB of crap most .c files don't actually need.
Add the typedef to qemu/typedefs.h, and include that instead of
qapi/error.h. Include qapi/error.h in .c files that need it and don't
get it now. Include qapi-types.h in qom/object.h for uint16List.
Update scripts/clean-includes accordingly. Update it further to match
reality: replace config.h by config-target.h, add sysemu/os-posix.h,
sysemu/os-win32.h. Update the list of includes in the qemu/osdep.h
comment quoted above similarly.
This reduces the number of objects depending on qapi/error.h from "all
of them" to less than a third. Unfortunately, the number depending on
qapi-types.h shrinks only a little. More work is needed for that one.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
[Fix compilation without the spice devel packages. - Paolo]
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
2016-03-14 09:01:28 +01:00
|
|
|
#include "qapi/error.h"
|
2012-12-17 18:20:00 +01:00
|
|
|
#include "qemu/iov.h"
|
2019-05-23 16:35:07 +02:00
|
|
|
#include "qemu/module.h"
|
2019-08-12 07:23:59 +02:00
|
|
|
#include "qemu/timer.h"
|
2013-02-05 17:06:20 +01:00
|
|
|
#include "hw/virtio/virtio.h"
|
2019-08-12 07:23:51 +02:00
|
|
|
#include "hw/qdev-properties.h"
|
2013-02-05 17:06:20 +01:00
|
|
|
#include "hw/virtio/virtio-rng.h"
|
2013-04-08 16:55:25 +02:00
|
|
|
#include "sysemu/rng.h"
|
2019-08-12 07:23:59 +02:00
|
|
|
#include "sysemu/runstate.h"
|
2014-01-16 17:34:39 +01:00
|
|
|
#include "qom/object_interfaces.h"
|
2014-08-04 12:52:44 +02:00
|
|
|
#include "trace.h"
|
2012-06-20 08:59:32 +02:00
|
|
|
|
|
|
|
static bool is_guest_ready(VirtIORNG *vrng)
|
|
|
|
{
|
2013-04-24 10:08:01 +02:00
|
|
|
VirtIODevice *vdev = VIRTIO_DEVICE(vrng);
|
2012-06-20 08:59:32 +02:00
|
|
|
if (virtio_queue_ready(vrng->vq)
|
2013-04-24 10:08:01 +02:00
|
|
|
&& (vdev->status & VIRTIO_CONFIG_S_DRIVER_OK)) {
|
2012-06-20 08:59:32 +02:00
|
|
|
return true;
|
|
|
|
}
|
2014-08-04 12:52:44 +02:00
|
|
|
trace_virtio_rng_guest_not_ready(vrng);
|
2012-06-20 08:59:32 +02:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2012-11-29 23:02:56 +01:00
|
|
|
static size_t get_request_size(VirtQueue *vq, unsigned quota)
|
2012-06-20 08:59:32 +02:00
|
|
|
{
|
2012-11-21 06:51:18 +01:00
|
|
|
unsigned int in, out;
|
2012-06-20 08:59:32 +02:00
|
|
|
|
2012-11-29 23:02:56 +01:00
|
|
|
virtqueue_get_avail_bytes(vq, &in, &out, quota, 0);
|
2012-11-21 06:51:18 +01:00
|
|
|
return in;
|
2012-06-20 08:59:32 +02:00
|
|
|
}
|
|
|
|
|
2012-10-30 23:45:05 +01:00
|
|
|
static void virtio_rng_process(VirtIORNG *vrng);
|
|
|
|
|
2012-06-20 08:59:32 +02:00
|
|
|
/* Send data from a char device over to the guest */
|
|
|
|
static void chr_read(void *opaque, const void *buf, size_t size)
|
|
|
|
{
|
|
|
|
VirtIORNG *vrng = opaque;
|
2013-04-24 10:08:01 +02:00
|
|
|
VirtIODevice *vdev = VIRTIO_DEVICE(vrng);
|
2016-02-04 15:26:51 +01:00
|
|
|
VirtQueueElement *elem;
|
2012-06-20 08:59:32 +02:00
|
|
|
size_t len;
|
|
|
|
int offset;
|
|
|
|
|
|
|
|
if (!is_guest_ready(vrng)) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2017-04-12 15:53:12 +02:00
|
|
|
/* we can't modify the virtqueue until
|
|
|
|
* our state is fully synced
|
|
|
|
*/
|
|
|
|
|
|
|
|
if (!runstate_check(RUN_STATE_RUNNING)) {
|
|
|
|
trace_virtio_rng_cpu_is_stopped(vrng, size);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2012-10-30 23:45:05 +01:00
|
|
|
vrng->quota_remaining -= size;
|
|
|
|
|
2012-06-20 08:59:32 +02:00
|
|
|
offset = 0;
|
|
|
|
while (offset < size) {
|
2016-02-04 15:26:51 +01:00
|
|
|
elem = virtqueue_pop(vrng->vq, sizeof(VirtQueueElement));
|
|
|
|
if (!elem) {
|
2012-06-20 08:59:32 +02:00
|
|
|
break;
|
|
|
|
}
|
2017-04-12 15:53:12 +02:00
|
|
|
trace_virtio_rng_popped(vrng);
|
2016-02-04 15:26:51 +01:00
|
|
|
len = iov_from_buf(elem->in_sg, elem->in_num,
|
2012-06-20 08:59:32 +02:00
|
|
|
0, buf + offset, size - offset);
|
|
|
|
offset += len;
|
|
|
|
|
2016-02-04 15:26:51 +01:00
|
|
|
virtqueue_push(vrng->vq, elem, len);
|
2014-08-04 12:52:44 +02:00
|
|
|
trace_virtio_rng_pushed(vrng, len);
|
2016-02-04 15:26:51 +01:00
|
|
|
g_free(elem);
|
2012-06-20 08:59:32 +02:00
|
|
|
}
|
2013-04-24 10:08:01 +02:00
|
|
|
virtio_notify(vdev, vrng->vq);
|
2016-03-03 10:48:34 +01:00
|
|
|
|
|
|
|
if (!virtio_queue_empty(vrng->vq)) {
|
|
|
|
/* If we didn't drain the queue, call virtio_rng_process
|
|
|
|
* to take care of asking for more data as appropriate.
|
|
|
|
*/
|
|
|
|
virtio_rng_process(vrng);
|
|
|
|
}
|
2012-06-20 08:59:32 +02:00
|
|
|
}
|
|
|
|
|
2012-10-30 23:45:05 +01:00
|
|
|
static void virtio_rng_process(VirtIORNG *vrng)
|
2012-06-20 08:59:32 +02:00
|
|
|
{
|
2012-11-21 06:51:18 +01:00
|
|
|
size_t size;
|
2012-11-29 23:02:56 +01:00
|
|
|
unsigned quota;
|
2012-10-30 23:45:05 +01:00
|
|
|
|
|
|
|
if (!is_guest_ready(vrng)) {
|
|
|
|
return;
|
|
|
|
}
|
2012-06-20 08:59:32 +02:00
|
|
|
|
2015-07-15 14:16:47 +02:00
|
|
|
if (vrng->activate_timer) {
|
|
|
|
timer_mod(vrng->rate_limit_timer,
|
|
|
|
qemu_clock_get_ms(QEMU_CLOCK_VIRTUAL) + vrng->conf.period_ms);
|
|
|
|
vrng->activate_timer = false;
|
|
|
|
}
|
|
|
|
|
2012-11-29 23:02:56 +01:00
|
|
|
if (vrng->quota_remaining < 0) {
|
|
|
|
quota = 0;
|
|
|
|
} else {
|
|
|
|
quota = MIN((uint64_t)vrng->quota_remaining, (uint64_t)UINT32_MAX);
|
|
|
|
}
|
|
|
|
size = get_request_size(vrng->vq, quota);
|
2014-08-04 12:52:44 +02:00
|
|
|
|
|
|
|
trace_virtio_rng_request(vrng, size, quota);
|
|
|
|
|
2012-10-30 23:45:05 +01:00
|
|
|
size = MIN(vrng->quota_remaining, size);
|
2012-11-21 06:51:18 +01:00
|
|
|
if (size) {
|
2012-06-20 08:59:32 +02:00
|
|
|
rng_backend_request_entropy(vrng->rng, size, chr_read, vrng);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2012-10-30 23:45:05 +01:00
|
|
|
static void handle_input(VirtIODevice *vdev, VirtQueue *vq)
|
|
|
|
{
|
2013-04-24 10:08:01 +02:00
|
|
|
VirtIORNG *vrng = VIRTIO_RNG(vdev);
|
2012-10-30 23:45:05 +01:00
|
|
|
virtio_rng_process(vrng);
|
|
|
|
}
|
|
|
|
|
2015-07-27 11:49:19 +02:00
|
|
|
static uint64_t get_features(VirtIODevice *vdev, uint64_t f, Error **errp)
|
2012-06-20 08:59:32 +02:00
|
|
|
{
|
|
|
|
return f;
|
|
|
|
}
|
|
|
|
|
2017-04-12 15:53:12 +02:00
|
|
|
static void virtio_rng_vm_state_change(void *opaque, int running,
|
|
|
|
RunState state)
|
2012-06-20 08:59:32 +02:00
|
|
|
{
|
2014-11-27 06:48:10 +01:00
|
|
|
VirtIORNG *vrng = opaque;
|
2012-06-20 08:59:32 +02:00
|
|
|
|
2017-04-12 15:53:12 +02:00
|
|
|
trace_virtio_rng_vm_state_change(vrng, running, state);
|
|
|
|
|
2012-10-30 23:45:05 +01:00
|
|
|
/* We may have an element ready but couldn't process it due to a quota
|
2017-04-12 15:53:12 +02:00
|
|
|
* limit or because CPU was stopped. Make sure to try again when the
|
|
|
|
* CPU restart.
|
2012-11-21 06:51:21 +01:00
|
|
|
*/
|
2012-10-30 23:45:05 +01:00
|
|
|
|
2017-04-12 15:53:12 +02:00
|
|
|
if (running && is_guest_ready(vrng)) {
|
|
|
|
virtio_rng_process(vrng);
|
|
|
|
}
|
2012-06-20 08:59:32 +02:00
|
|
|
}
|
|
|
|
|
2012-10-30 23:45:05 +01:00
|
|
|
static void check_rate_limit(void *opaque)
|
|
|
|
{
|
2013-04-24 10:08:01 +02:00
|
|
|
VirtIORNG *vrng = opaque;
|
2012-10-30 23:45:05 +01:00
|
|
|
|
2013-04-24 10:08:01 +02:00
|
|
|
vrng->quota_remaining = vrng->conf.max_bytes;
|
|
|
|
virtio_rng_process(vrng);
|
2015-07-15 14:16:47 +02:00
|
|
|
vrng->activate_timer = true;
|
2012-10-30 23:45:05 +01:00
|
|
|
}
|
|
|
|
|
2018-06-27 13:25:20 +02:00
|
|
|
static void virtio_rng_set_status(VirtIODevice *vdev, uint8_t status)
|
|
|
|
{
|
|
|
|
VirtIORNG *vrng = VIRTIO_RNG(vdev);
|
|
|
|
|
|
|
|
if (!vdev->vm_running) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
vdev->status = status;
|
|
|
|
|
|
|
|
/* Something changed, try to process buffers */
|
|
|
|
virtio_rng_process(vrng);
|
|
|
|
}
|
|
|
|
|
2013-07-30 02:57:37 +02:00
|
|
|
static void virtio_rng_device_realize(DeviceState *dev, Error **errp)
|
2012-06-20 08:59:32 +02:00
|
|
|
{
|
2013-07-30 02:57:37 +02:00
|
|
|
VirtIODevice *vdev = VIRTIO_DEVICE(dev);
|
2013-07-30 05:12:47 +02:00
|
|
|
VirtIORNG *vrng = VIRTIO_RNG(dev);
|
2012-06-20 08:59:32 +02:00
|
|
|
|
2014-12-11 08:47:42 +01:00
|
|
|
if (vrng->conf.period_ms <= 0) {
|
2014-07-30 01:28:58 +02:00
|
|
|
error_setg(errp, "'period' parameter expects a positive integer");
|
2013-07-30 02:57:37 +02:00
|
|
|
return;
|
2013-11-21 11:53:23 +01:00
|
|
|
}
|
|
|
|
|
2014-07-30 01:28:57 +02:00
|
|
|
/* Workaround: Property parsing does not enforce unsigned integers,
|
|
|
|
* So this is a hack to reject such numbers. */
|
|
|
|
if (vrng->conf.max_bytes > INT64_MAX) {
|
2014-07-30 01:28:58 +02:00
|
|
|
error_setg(errp, "'max-bytes' parameter must be non-negative, "
|
|
|
|
"and less than 2^63");
|
2014-07-30 01:28:57 +02:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2013-04-24 10:07:59 +02:00
|
|
|
if (vrng->conf.rng == NULL) {
|
2019-08-20 18:06:15 +02:00
|
|
|
Object *default_backend = object_new(TYPE_RNG_BUILTIN);
|
2013-04-24 10:07:59 +02:00
|
|
|
|
qom: Use returned bool to check for failure, Coccinelle part
The previous commit enables conversion of
foo(..., &err);
if (err) {
...
}
to
if (!foo(..., errp)) {
...
}
for QOM functions that now return true / false on success / error.
Coccinelle script:
@@
identifier fun = {
object_apply_global_props, object_initialize_child_with_props,
object_initialize_child_with_propsv, object_property_get,
object_property_get_bool, object_property_parse, object_property_set,
object_property_set_bool, object_property_set_int,
object_property_set_link, object_property_set_qobject,
object_property_set_str, object_property_set_uint, object_set_props,
object_set_propv, user_creatable_add_dict,
user_creatable_complete, user_creatable_del
};
expression list args, args2;
typedef Error;
Error *err;
@@
- fun(args, &err, args2);
- if (err)
+ if (!fun(args, &err, args2))
{
...
}
Fails to convert hw/arm/armsse.c, because Coccinelle gets confused by
ARMSSE being used both as typedef and function-like macro there.
Convert manually.
Line breaks tidied up manually.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20200707160613.848843-29-armbru@redhat.com>
2020-07-07 18:05:56 +02:00
|
|
|
if (!user_creatable_complete(USER_CREATABLE(default_backend),
|
error: Eliminate error_propagate() with Coccinelle, part 1
When all we do with an Error we receive into a local variable is
propagating to somewhere else, we can just as well receive it there
right away. Convert
if (!foo(..., &err)) {
...
error_propagate(errp, err);
...
return ...
}
to
if (!foo(..., errp)) {
...
...
return ...
}
where nothing else needs @err. Coccinelle script:
@rule1 forall@
identifier fun, err, errp, lbl;
expression list args, args2;
binary operator op;
constant c1, c2;
symbol false;
@@
if (
(
- fun(args, &err, args2)
+ fun(args, errp, args2)
|
- !fun(args, &err, args2)
+ !fun(args, errp, args2)
|
- fun(args, &err, args2) op c1
+ fun(args, errp, args2) op c1
)
)
{
... when != err
when != lbl:
when strict
- error_propagate(errp, err);
... when != err
(
return;
|
return c2;
|
return false;
)
}
@rule2 forall@
identifier fun, err, errp, lbl;
expression list args, args2;
expression var;
binary operator op;
constant c1, c2;
symbol false;
@@
- var = fun(args, &err, args2);
+ var = fun(args, errp, args2);
... when != err
if (
(
var
|
!var
|
var op c1
)
)
{
... when != err
when != lbl:
when strict
- error_propagate(errp, err);
... when != err
(
return;
|
return c2;
|
return false;
|
return var;
)
}
@depends on rule1 || rule2@
identifier err;
@@
- Error *err = NULL;
... when != err
Not exactly elegant, I'm afraid.
The "when != lbl:" is necessary to avoid transforming
if (fun(args, &err)) {
goto out
}
...
out:
error_propagate(errp, err);
even though other paths to label out still need the error_propagate().
For an actual example, see sclp_realize().
Without the "when strict", Coccinelle transforms vfio_msix_setup(),
incorrectly. I don't know what exactly "when strict" does, only that
it helps here.
The match of return is narrower than what I want, but I can't figure
out how to express "return where the operand doesn't use @err". For
an example where it's too narrow, see vfio_intx_enable().
Silently fails to convert hw/arm/armsse.c, because Coccinelle gets
confused by ARMSSE being used both as typedef and function-like macro
there. Converted manually.
Line breaks tidied up manually. One nested declaration of @local_err
deleted manually. Preexisting unwanted blank line dropped in
hw/riscv/sifive_e.c.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <20200707160613.848843-35-armbru@redhat.com>
2020-07-07 18:06:02 +02:00
|
|
|
errp)) {
|
2019-08-20 18:06:14 +02:00
|
|
|
object_unref(default_backend);
|
2014-01-16 17:34:39 +01:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2019-08-20 18:06:14 +02:00
|
|
|
object_property_add_child(OBJECT(dev), "default-backend",
|
qom: Drop parameter @errp of object_property_add() & friends
The only way object_property_add() can fail is when a property with
the same name already exists. Since our property names are all
hardcoded, failure is a programming error, and the appropriate way to
handle it is passing &error_abort.
Same for its variants, except for object_property_add_child(), which
additionally fails when the child already has a parent. Parentage is
also under program control, so this is a programming error, too.
We have a bit over 500 callers. Almost half of them pass
&error_abort, slightly fewer ignore errors, one test case handles
errors, and the remaining few callers pass them to their own callers.
The previous few commits demonstrated once again that ignoring
programming errors is a bad idea.
Of the few ones that pass on errors, several violate the Error API.
The Error ** argument must be NULL, &error_abort, &error_fatal, or a
pointer to a variable containing NULL. Passing an argument of the
latter kind twice without clearing it in between is wrong: if the
first call sets an error, it no longer points to NULL for the second
call. ich9_pm_add_properties(), sparc32_ledma_realize(),
sparc32_dma_realize(), xilinx_axidma_realize(), xilinx_enet_realize()
are wrong that way.
When the one appropriate choice of argument is &error_abort, letting
users pick the argument is a bad idea.
Drop parameter @errp and assert the preconditions instead.
There's one exception to "duplicate property name is a programming
error": the way object_property_add() implements the magic (and
undocumented) "automatic arrayification". Don't drop @errp there.
Instead, rename object_property_add() to object_property_try_add(),
and add the obvious wrapper object_property_add().
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200505152926.18877-15-armbru@redhat.com>
[Two semantic rebase conflicts resolved]
2020-05-05 17:29:22 +02:00
|
|
|
default_backend);
|
2013-04-24 10:07:59 +02:00
|
|
|
|
2014-03-19 08:58:57 +01:00
|
|
|
/* The child property took a reference, we can safely drop ours now */
|
2019-08-20 18:06:14 +02:00
|
|
|
object_unref(default_backend);
|
2014-03-19 08:58:57 +01:00
|
|
|
|
qom: Put name parameter before value / visitor parameter
The object_property_set_FOO() setters take property name and value in
an unusual order:
void object_property_set_FOO(Object *obj, FOO_TYPE value,
const char *name, Error **errp)
Having to pass value before name feels grating. Swap them.
Same for object_property_set(), object_property_get(), and
object_property_parse().
Convert callers with this Coccinelle script:
@@
identifier fun = {
object_property_get, object_property_parse, object_property_set_str,
object_property_set_link, object_property_set_bool,
object_property_set_int, object_property_set_uint, object_property_set,
object_property_set_qobject
};
expression obj, v, name, errp;
@@
- fun(obj, v, name, errp)
+ fun(obj, name, v, errp)
Chokes on hw/arm/musicpal.c's lcd_refresh() with the unhelpful error
message "no position information". Convert that one manually.
Fails to convert hw/arm/armsse.c, because Coccinelle gets confused by
ARMSSE being used both as typedef and function-like macro there.
Convert manually.
Fails to convert hw/rx/rx-gdbsim.c, because Coccinelle gets confused
by RXCPU being used both as typedef and function-like macro there.
Convert manually. The other files using RXCPU that way don't need
conversion.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20200707160613.848843-27-armbru@redhat.com>
[Straightforwad conflict with commit 2336172d9b "audio: set default
value for pcspk.iobase property" resolved]
2020-07-07 18:05:54 +02:00
|
|
|
object_property_set_link(OBJECT(dev), "rng", default_backend,
|
|
|
|
&error_abort);
|
2013-04-24 10:07:55 +02:00
|
|
|
}
|
2012-06-20 08:59:32 +02:00
|
|
|
|
2013-04-24 10:07:59 +02:00
|
|
|
vrng->rng = vrng->conf.rng;
|
2012-06-20 08:59:32 +02:00
|
|
|
if (vrng->rng == NULL) {
|
2014-07-30 01:28:58 +02:00
|
|
|
error_setg(errp, "'rng' parameter expects a valid object");
|
2013-07-30 02:57:37 +02:00
|
|
|
return;
|
2012-06-20 08:59:32 +02:00
|
|
|
}
|
|
|
|
|
2014-07-30 01:28:57 +02:00
|
|
|
virtio_init(vdev, "virtio-rng", VIRTIO_ID_RNG, 0);
|
2013-04-24 10:07:55 +02:00
|
|
|
|
2014-07-30 01:28:57 +02:00
|
|
|
vrng->vq = virtio_add_queue(vdev, 8, handle_input);
|
2013-04-24 10:07:54 +02:00
|
|
|
vrng->quota_remaining = vrng->conf.max_bytes;
|
2013-08-21 17:03:08 +02:00
|
|
|
vrng->rate_limit_timer = timer_new_ms(QEMU_CLOCK_VIRTUAL,
|
2012-10-30 23:45:05 +01:00
|
|
|
check_rate_limit, vrng);
|
2015-07-15 14:16:47 +02:00
|
|
|
vrng->activate_timer = true;
|
2017-04-12 15:53:12 +02:00
|
|
|
|
|
|
|
vrng->vmstate = qemu_add_vm_change_state_handler(virtio_rng_vm_state_change,
|
|
|
|
vrng);
|
2013-04-24 10:07:55 +02:00
|
|
|
}
|
|
|
|
|
qdev: Unrealize must not fail
Devices may have component devices and buses.
Device realization may fail. Realization is recursive: a device's
realize() method realizes its components, and device_set_realized()
realizes its buses (which should in turn realize the devices on that
bus, except bus_set_realized() doesn't implement that, yet).
When realization of a component or bus fails, we need to roll back:
unrealize everything we realized so far. If any of these unrealizes
failed, the device would be left in an inconsistent state. Must not
happen.
device_set_realized() lets it happen: it ignores errors in the roll
back code starting at label child_realize_fail.
Since realization is recursive, unrealization must be recursive, too.
But how could a partly failed unrealize be rolled back? We'd have to
re-realize, which can fail. This design is fundamentally broken.
device_set_realized() does not roll back at all. Instead, it keeps
unrealizing, ignoring further errors.
It can screw up even for a device with no buses: if the lone
dc->unrealize() fails, it still unregisters vmstate, and calls
listeners' unrealize() callback.
bus_set_realized() does not roll back either. Instead, it stops
unrealizing.
Fortunately, no unrealize method can fail, as we'll see below.
To fix the design error, drop parameter @errp from all the unrealize
methods.
Any unrealize method that uses @errp now needs an update. This leads
us to unrealize() methods that can fail. Merely passing it to another
unrealize method cannot cause failure, though. Here are the ones that
do other things with @errp:
* virtio_serial_device_unrealize()
Fails when qbus_set_hotplug_handler() fails, but still does all the
other work. On failure, the device would stay realized with its
resources completely gone. Oops. Can't happen, because
qbus_set_hotplug_handler() can't actually fail here. Pass
&error_abort to qbus_set_hotplug_handler() instead.
* hw/ppc/spapr_drc.c's unrealize()
Fails when object_property_del() fails, but all the other work is
already done. On failure, the device would stay realized with its
vmstate registration gone. Oops. Can't happen, because
object_property_del() can't actually fail here. Pass &error_abort
to object_property_del() instead.
* spapr_phb_unrealize()
Fails and bails out when remove_drcs() fails, but other work is
already done. On failure, the device would stay realized with some
of its resources gone. Oops. remove_drcs() fails only when
chassis_from_bus()'s object_property_get_uint() fails, and it can't
here. Pass &error_abort to remove_drcs() instead.
Therefore, no unrealize method can fail before this patch.
device_set_realized()'s recursive unrealization via bus uses
object_property_set_bool(). Can't drop @errp there, so pass
&error_abort.
We similarly unrealize with object_property_set_bool() elsewhere,
always ignoring errors. Pass &error_abort instead.
Several unrealize methods no longer handle errors from other unrealize
methods: virtio_9p_device_unrealize(),
virtio_input_device_unrealize(), scsi_qdev_unrealize(), ...
Much of the deleted error handling looks wrong anyway.
One unrealize methods no longer ignore such errors:
usb_ehci_pci_exit().
Several realize methods no longer ignore errors when rolling back:
v9fs_device_realize_common(), pci_qdev_unrealize(),
spapr_phb_realize(), usb_qdev_realize(), vfio_ccw_realize(),
virtio_device_realize().
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200505152926.18877-17-armbru@redhat.com>
2020-05-05 17:29:24 +02:00
|
|
|
static void virtio_rng_device_unrealize(DeviceState *dev)
|
2013-04-24 10:07:55 +02:00
|
|
|
{
|
2013-07-30 03:50:44 +02:00
|
|
|
VirtIODevice *vdev = VIRTIO_DEVICE(dev);
|
|
|
|
VirtIORNG *vrng = VIRTIO_RNG(dev);
|
2013-04-24 10:07:55 +02:00
|
|
|
|
2017-04-12 15:53:12 +02:00
|
|
|
qemu_del_vm_change_state_handler(vrng->vmstate);
|
2013-08-21 17:03:08 +02:00
|
|
|
timer_del(vrng->rate_limit_timer);
|
|
|
|
timer_free(vrng->rate_limit_timer);
|
2019-10-25 10:35:23 +02:00
|
|
|
virtio_del_queue(vdev, 0);
|
2013-04-24 10:21:22 +02:00
|
|
|
virtio_cleanup(vdev);
|
2013-04-24 10:07:55 +02:00
|
|
|
}
|
|
|
|
|
2016-10-06 14:55:48 +02:00
|
|
|
static const VMStateDescription vmstate_virtio_rng = {
|
|
|
|
.name = "virtio-rng",
|
|
|
|
.minimum_version_id = 1,
|
|
|
|
.version_id = 1,
|
|
|
|
.fields = (VMStateField[]) {
|
|
|
|
VMSTATE_VIRTIO_DEVICE,
|
|
|
|
VMSTATE_END_OF_LIST()
|
|
|
|
},
|
|
|
|
};
|
2016-07-14 19:22:48 +02:00
|
|
|
|
2013-04-24 10:07:55 +02:00
|
|
|
static Property virtio_rng_properties[] = {
|
2015-06-10 17:04:33 +02:00
|
|
|
/* Set a default rate limit of 2^47 bytes per minute or roughly 2TB/s. If
|
|
|
|
* you have an entropy source capable of generating more entropy than this
|
|
|
|
* and you can pass it through via virtio-rng, then hats off to you. Until
|
|
|
|
* then, this is unlimited for all practical purposes.
|
|
|
|
*/
|
|
|
|
DEFINE_PROP_UINT64("max-bytes", VirtIORNG, conf.max_bytes, INT64_MAX),
|
|
|
|
DEFINE_PROP_UINT32("period", VirtIORNG, conf.period_ms, 1 << 16),
|
2017-07-14 04:14:57 +02:00
|
|
|
DEFINE_PROP_LINK("rng", VirtIORNG, conf.rng, TYPE_RNG_BACKEND, RngBackend *),
|
2013-04-24 10:07:55 +02:00
|
|
|
DEFINE_PROP_END_OF_LIST(),
|
|
|
|
};
|
|
|
|
|
|
|
|
static void virtio_rng_class_init(ObjectClass *klass, void *data)
|
|
|
|
{
|
|
|
|
DeviceClass *dc = DEVICE_CLASS(klass);
|
|
|
|
VirtioDeviceClass *vdc = VIRTIO_DEVICE_CLASS(klass);
|
2013-07-30 02:57:37 +02:00
|
|
|
|
2020-01-10 16:30:32 +01:00
|
|
|
device_class_set_props(dc, virtio_rng_properties);
|
2016-07-14 19:22:48 +02:00
|
|
|
dc->vmsd = &vmstate_virtio_rng;
|
2013-07-29 16:17:45 +02:00
|
|
|
set_bit(DEVICE_CATEGORY_MISC, dc->categories);
|
2013-07-30 02:57:37 +02:00
|
|
|
vdc->realize = virtio_rng_device_realize;
|
2013-07-30 03:50:44 +02:00
|
|
|
vdc->unrealize = virtio_rng_device_unrealize;
|
2013-04-24 10:07:55 +02:00
|
|
|
vdc->get_features = get_features;
|
2018-06-27 13:25:20 +02:00
|
|
|
vdc->set_status = virtio_rng_set_status;
|
2013-04-24 10:07:55 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
static const TypeInfo virtio_rng_info = {
|
|
|
|
.name = TYPE_VIRTIO_RNG,
|
|
|
|
.parent = TYPE_VIRTIO_DEVICE,
|
|
|
|
.instance_size = sizeof(VirtIORNG),
|
|
|
|
.class_init = virtio_rng_class_init,
|
|
|
|
};
|
|
|
|
|
|
|
|
static void virtio_register_types(void)
|
|
|
|
{
|
|
|
|
type_register_static(&virtio_rng_info);
|
|
|
|
}
|
|
|
|
|
|
|
|
type_init(virtio_register_types)
|