linux-user: Check copy_from_user() return value in vma_dump_size()
Coverity points out that we don't check the return value from copy_from_user() in vma_dump_size(). This is to some extent a "can't happen" error since we've already checked the page with an access_ok() call earlier, but it's simple enough to handle the error anyway. Fixes: Coverity CID 1432362 Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Laurent Vivier <laurent@vivier.eu> Message-Id: <20201103141532.19912-1-peter.maydell@linaro.org> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
This commit is contained in:
parent
e4ce178b61
commit
022625a8ad
|
@ -3485,7 +3485,9 @@ static abi_ulong vma_dump_size(const struct vm_area_struct *vma)
|
||||||
if (vma->vma_flags & PROT_EXEC) {
|
if (vma->vma_flags & PROT_EXEC) {
|
||||||
char page[TARGET_PAGE_SIZE];
|
char page[TARGET_PAGE_SIZE];
|
||||||
|
|
||||||
copy_from_user(page, vma->vma_start, sizeof (page));
|
if (copy_from_user(page, vma->vma_start, sizeof (page))) {
|
||||||
|
return 0;
|
||||||
|
}
|
||||||
if ((page[EI_MAG0] == ELFMAG0) &&
|
if ((page[EI_MAG0] == ELFMAG0) &&
|
||||||
(page[EI_MAG1] == ELFMAG1) &&
|
(page[EI_MAG1] == ELFMAG1) &&
|
||||||
(page[EI_MAG2] == ELFMAG2) &&
|
(page[EI_MAG2] == ELFMAG2) &&
|
||||||
|
|
Loading…
Reference in New Issue