From 0d4104e5760221547fad158bbbb655a4e4c22b50 Mon Sep 17 00:00:00 2001 From: Fam Zheng Date: Tue, 2 Aug 2016 11:41:41 +0800 Subject: [PATCH] qdev: Fix use after free in qdev_init_nofail error path Since 69382d8b (qdev: Fix object reference leak in case device.realize() fails), object_property_set_bool could release the object. The error path wants the type name, so hold an reference before realizing it. Cc: Igor Mammedov Signed-off-by: Fam Zheng Message-Id: <1470109301-12966-1-git-send-email-famz@redhat.com> Reviewed-by: John Snow Signed-off-by: Paolo Bonzini --- hw/core/qdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/core/qdev.c b/hw/core/qdev.c index ee4a083e64..57834423b9 100644 --- a/hw/core/qdev.c +++ b/hw/core/qdev.c @@ -354,12 +354,14 @@ void qdev_init_nofail(DeviceState *dev) assert(!dev->realized); + object_ref(OBJECT(dev)); object_property_set_bool(OBJECT(dev), true, "realized", &err); if (err) { error_reportf_err(err, "Initialization of device %s failed: ", object_get_typename(OBJECT(dev))); exit(1); } + object_unref(OBJECT(dev)); } void qdev_machine_creation_done(void)