From 1394dc0690e7a1514bd6594322d5a2105e881769 Mon Sep 17 00:00:00 2001 From: Simran Singhal Date: Thu, 2 Apr 2020 23:58:48 +0530 Subject: [PATCH] json: Fix check for unbalanced right curly brace We immediately diagnose unbalanced right curly brace: $ qemu-kvm --nodefaults --nographic --qmp stdio {"QMP": {"version": {"qemu": {"micro": 91, "minor": 2, "major": 4}, "package": "v5.0.0-rc1-1-gf6ce4a439a08"}, "capabilities": ["oob"]}} } {"error": {"class": "GenericError", "desc": "JSON parse error, expecting value"}} except within square bracket: [} The check for unbalanced braces has a typo. Fix it. Fixes: 8d3265b3d00db1071d1d3bf8433b4818088fdeb5 Signed-off-by: Simran Singhal Reviewed-by: Eric Blake Message-Id: <20200402182848.GA3023@simran-Inspiron-5558> Reviewed-by: Markus Armbruster [Commit message rewritten to explain what's broken] Signed-off-by: Markus Armbruster --- qobject/json-streamer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qobject/json-streamer.c b/qobject/json-streamer.c index 47dd7ea576..b93d97b995 100644 --- a/qobject/json-streamer.c +++ b/qobject/json-streamer.c @@ -85,7 +85,7 @@ void json_message_process_token(JSONLexer *lexer, GString *input, g_queue_push_tail(&parser->tokens, token); if ((parser->brace_count > 0 || parser->bracket_count > 0) - && parser->bracket_count >= 0 && parser->bracket_count >= 0) { + && parser->brace_count >= 0 && parser->bracket_count >= 0) { return; }