From 187f47e947d1e0f4547e58b7cc4fad4d5542b185 Mon Sep 17 00:00:00 2001 From: Eric Blake Date: Sat, 24 Jun 2017 12:10:07 -0600 Subject: [PATCH] qobject: Catch another straggler for use of qdict_put_str() Dan's addition of key-secret improvements in commit 29cf9336 was developed prior to the addition of QDict scalar insertion macros, but merged after the general cleanup in commit 46f5ac20. Patch created mechanically by rerunning: spatch --sp-file scripts/coccinelle/qobject.cocci \ --macro-file scripts/cocci-macro-file.h --dir . --in-place Signed-off-by: Eric Blake Reviewed-by: Alberto Garcia Message-Id: <20170624181008.25497-2-eblake@redhat.com> Reviewed-by: Max Reitz Reviewed-by: Stefan Hajnoczi Signed-off-by: Markus Armbruster --- qemu-img.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-img.c b/qemu-img.c index f7ffb79db6..02900ce1d1 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -355,7 +355,7 @@ static int img_add_key_secrets(void *opaque, QDict *options = opaque; if (g_str_has_suffix(name, "key-secret")) { - qdict_put(options, name, qstring_from_str(value)); + qdict_put_str(options, name, value); } return 0;