OpenE2K
/
qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity

gdbstub: Drop dead code in cpu_gdb_{read,write}_register() 

GET_REG*() macros include a return statement, thus no need for break.

Acked-by: Michael Walle <michael@walle.cc> (for lm32)
Signed-off-by: Andreas Färber <afaerber@suse.de>
This commit is contained in:
Andreas Färber 2013-07-07 11:52:52 +02:00
parent 47d74ef57a
commit 19a77215f1
1 changed files with 0 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
gdbstub.c
View File

@ -1295,15 +1295,12 @@ static int cpu_gdb_read_register(CPUOpenRISCState *env, uint8_t *mem_buf, int n)
switch (n) { switch (n) {
case 32: /* PPC */ case 32: /* PPC */
GET_REG32(env->ppc); GET_REG32(env->ppc);
break;
case 33: /* NPC */ case 33: /* NPC */
GET_REG32(env->npc); GET_REG32(env->npc);
break;
case 34: /* SR */ case 34: /* SR */
GET_REG32(env->sr); GET_REG32(env->sr);
break;
default: default:
break; break;
@ -1516,14 +1513,11 @@ read_register_crisv10(CPUCRISState *env, uint8_t *mem_buf, int n)
switch (n) { switch (n) {
case 16: case 16:
GET_REG8(env->pregs[n - 16]); GET_REG8(env->pregs[n - 16]);
break;
case 17: case 17:
GET_REG8(env->pregs[n - 16]); GET_REG8(env->pregs[n - 16]);
break;
case 20: case 20:
case 21: case 21:
GET_REG16(env->pregs[n - 16]); GET_REG16(env->pregs[n - 16]);
break;
default: default:
if (n >= 23) { if (n >= 23) {
GET_REG32(env->pregs[n - 16]); GET_REG32(env->pregs[n - 16]);
@ -1693,22 +1687,16 @@ static int cpu_gdb_read_register(CPUS390XState *env, uint8_t *mem_buf, int n)
cc_op = calc_cc(env, env->cc_op, env->cc_src, env->cc_dst, env->cc_vr); cc_op = calc_cc(env, env->cc_op, env->cc_src, env->cc_dst, env->cc_vr);
val = deposit64(env->psw.mask, 44, 2, cc_op); val = deposit64(env->psw.mask, 44, 2, cc_op);
GET_REGL(val); GET_REGL(val);
break;
case S390_PSWA_REGNUM: case S390_PSWA_REGNUM:
GET_REGL(env->psw.addr); GET_REGL(env->psw.addr);
break;
case S390_R0_REGNUM ... S390_R15_REGNUM: case S390_R0_REGNUM ... S390_R15_REGNUM:
GET_REGL(env->regs[n-S390_R0_REGNUM]); GET_REGL(env->regs[n-S390_R0_REGNUM]);
break;
case S390_A0_REGNUM ... S390_A15_REGNUM: case S390_A0_REGNUM ... S390_A15_REGNUM:
GET_REG32(env->aregs[n-S390_A0_REGNUM]); GET_REG32(env->aregs[n-S390_A0_REGNUM]);
break;
case S390_FPC_REGNUM: case S390_FPC_REGNUM:
GET_REG32(env->fpc); GET_REG32(env->fpc);
break;
case S390_F0_REGNUM ... S390_F15_REGNUM: case S390_F0_REGNUM ... S390_F15_REGNUM:
GET_REG64(env->fregs[n-S390_F0_REGNUM].ll); GET_REG64(env->fregs[n-S390_F0_REGNUM].ll);
break;
} }
return 0; return 0;
@ -1762,26 +1750,19 @@ static int cpu_gdb_read_register(CPULM32State *env, uint8_t *mem_buf, int n)
switch (n) { switch (n) {
case 32: case 32:
GET_REG32(env->pc); GET_REG32(env->pc);
break;
/* FIXME: put in right exception ID */ /* FIXME: put in right exception ID */
case 33: case 33:
GET_REG32(0); GET_REG32(0);
break;
case 34: case 34:
GET_REG32(env->eba); GET_REG32(env->eba);
break;
case 35: case 35:
GET_REG32(env->deba); GET_REG32(env->deba);
break;
case 36: case 36:
GET_REG32(env->ie); GET_REG32(env->ie);
break;
case 37: case 37:
GET_REG32(lm32_pic_get_im(env->pic_state)); GET_REG32(lm32_pic_get_im(env->pic_state));
break;
case 38: case 38:
GET_REG32(lm32_pic_get_ip(env->pic_state)); GET_REG32(lm32_pic_get_ip(env->pic_state));
break;
} }
} }
return 0; return 0;
@ -1844,28 +1825,22 @@ static int cpu_gdb_read_register(CPUXtensaState *env, uint8_t *mem_buf, int n)
switch (reg->type) { switch (reg->type) {
case 9: /*pc*/ case 9: /*pc*/
GET_REG32(env->pc); GET_REG32(env->pc);
break;
case 1: /*ar*/ case 1: /*ar*/
xtensa_sync_phys_from_window(env); xtensa_sync_phys_from_window(env);
GET_REG32(env->phys_regs[(reg->targno & 0xff) % env->config->nareg]); GET_REG32(env->phys_regs[(reg->targno & 0xff) % env->config->nareg]);
break;
case 2: /*SR*/ case 2: /*SR*/
GET_REG32(env->sregs[reg->targno & 0xff]); GET_REG32(env->sregs[reg->targno & 0xff]);
break;
case 3: /*UR*/ case 3: /*UR*/
GET_REG32(env->uregs[reg->targno & 0xff]); GET_REG32(env->uregs[reg->targno & 0xff]);
break;
case 4: /*f*/ case 4: /*f*/
GET_REG32(float32_val(env->fregs[reg->targno & 0x0f])); GET_REG32(float32_val(env->fregs[reg->targno & 0x0f]));
break;
case 8: /*a*/ case 8: /*a*/
GET_REG32(env->regs[reg->targno & 0x0f]); GET_REG32(env->regs[reg->targno & 0x0f]);
break;
default: default:
qemu_log("%s from reg %d of unsupported type %d\n", qemu_log("%s from reg %d of unsupported type %d\n",