OpenE2K/qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity

dump: Rename write_elf*_phdr_note to prepare_elf*_phdr_note

Browse Source 
The functions in question do not actually write to the file descriptor
they set up a buffer which is later written to the fd.

Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
Reviewed-by: Janis Schoetterl-Glausch <scgl@linux.ibm.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20220811121111.9878-9-frankja@linux.ibm.com>
This commit is contained in:
Janosch Frank 2022-08-11 12:11:01 +00:00 committed by Marc-André Lureau
parent 670e76998a
commit 2341a94d3a
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
dump/dump.c
View File

@ -260,7 +260,7 @@ static void write_elf32_load(DumpState *s, MemoryMapping *memory_mapping,
} }
} }
static void write_elf64_phdr_note(DumpState *s, Elf64_Phdr *phdr) static void prepare_elf64_phdr_note(DumpState *s, Elf64_Phdr *phdr)
{ {
memset(phdr, 0, sizeof(*phdr)); memset(phdr, 0, sizeof(*phdr));
phdr->p_type = cpu_to_dump32(s, PT_NOTE); phdr->p_type = cpu_to_dump32(s, PT_NOTE);
@ -316,7 +316,7 @@ static void write_elf64_notes(WriteCoreDumpFunction f, DumpState *s,
write_guest_note(f, s, errp); write_guest_note(f, s, errp);
} }
static void write_elf32_phdr_note(DumpState *s, Elf32_Phdr *phdr) static void prepare_elf32_phdr_note(DumpState *s, Elf32_Phdr *phdr)
{ {
memset(phdr, 0, sizeof(*phdr)); memset(phdr, 0, sizeof(*phdr));
phdr->p_type = cpu_to_dump32(s, PT_NOTE); phdr->p_type = cpu_to_dump32(s, PT_NOTE);
@ -364,11 +364,11 @@ static void write_elf_phdr_note(DumpState *s, Error **errp)
int ret; int ret;
if (dump_is_64bit(s)) { if (dump_is_64bit(s)) {
write_elf64_phdr_note(s, &phdr64); prepare_elf64_phdr_note(s, &phdr64);
size = sizeof(phdr64); size = sizeof(phdr64);
phdr = &phdr64; phdr = &phdr64;
} else { } else {
write_elf32_phdr_note(s, &phdr32); prepare_elf32_phdr_note(s, &phdr32);
size = sizeof(phdr32); size = sizeof(phdr32);
phdr = &phdr32; phdr = &phdr32;
} }