OpenE2K/qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity

qcow2: Fix sector calculation in qcow2_measure()

Browse Source 
We used MAX() instead of the intended MIN() when computing how many
sectors to view in the current loop iteration of qcow2_measure(),
and passed in a value of INT_MAX sectors instead of our more usual
limit of BDRV_REQUEST_MAX_SECTORS (the latter avoids 32-bit overflow
on conversion to bytes).  For small files, the bug is harmless:
bdrv_get_block_status_above() clamps its *pnum answer to the BDS
size, regardless of any insanely larger input request.  However, for
any file at least 2T in size, we can very easily end up going into an
infinite loop (the maximum of 0x100000000 sectors and INT_MAX is a
64-bit quantity, which becomes 0 when assigned to int; once nb_sectors
is 0, we never make progress).

Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
This commit is contained in:
Eric Blake 2017-07-21 13:32:43 -05:00 committed by Kevin Wolf
parent 6c98c57af3
commit 24bae02b19
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
block/qcow2.c
View File

@ -3669,8 +3669,8 @@ static BlockMeasureInfo *qcow2_measure(QemuOpts *opts, BlockDriverState *in_bs,
for (sector_num = 0; for (sector_num = 0;
sector_num < ssize / BDRV_SECTOR_SIZE; sector_num < ssize / BDRV_SECTOR_SIZE;
sector_num += pnum) { sector_num += pnum) {
int nb_sectors = MAX(ssize / BDRV_SECTOR_SIZE - sector_num, int nb_sectors = MIN(ssize / BDRV_SECTOR_SIZE - sector_num,
INT_MAX); BDRV_REQUEST_MAX_SECTORS);
BlockDriverState *file; BlockDriverState *file;
int64_t ret; int64_t ret;