chardev: honour the reconnect setting in tcp_chr_wait_connected

If establishing a client connection fails, the tcp_chr_wait_connected
method should sleep for the reconnect timeout and then retry the
attempt. This ensures the callers don't immediately abort with an
error when the initial connection fails.

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20190211182442.8542-13-berrange@redhat.com>
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
This commit is contained in:
Daniel P. Berrangé 2019-02-11 18:24:38 +00:00 committed by Marc-André Lureau
parent 32423ccaa1
commit 25d93b6a11

View File

@ -957,8 +957,15 @@ static int tcp_chr_wait_connected(Chardev *chr, Error **errp)
if (s->is_listen) { if (s->is_listen) {
tcp_chr_accept_server_sync(chr); tcp_chr_accept_server_sync(chr);
} else { } else {
if (tcp_chr_connect_client_sync(chr, errp) < 0) { Error *err = NULL;
return -1; if (tcp_chr_connect_client_sync(chr, &err) < 0) {
if (s->reconnect_time) {
error_free(err);
g_usleep(s->reconnect_time * 1000ULL * 1000ULL);
} else {
error_propagate(errp, err);
return -1;
}
} }
} }
} }