OpenE2K/qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity

esp.c: introduce esp_fifo_push_buf() function for pushing to the FIFO

Browse Source 
Instead of pushing data into the FIFO directly with fifo8_push_all(), add a new
esp_fifo_push_buf() function and use it accordingly.

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20240324191707.623175-10-mark.cave-ayland@ilande.co.uk>
Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
This commit is contained in:
Mark Cave-Ayland 2024-03-24 19:16:58 +00:00
parent da8381260b
commit 266170f91f
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
hw/scsi/esp.c
View File

@ -116,6 +116,11 @@ static void esp_fifo_push(ESPState *s, uint8_t val)
fifo8_push(&s->fifo, val); fifo8_push(&s->fifo, val);
} }
static void esp_fifo_push_buf(ESPState *s, uint8_t *buf, int len)
{
fifo8_push_all(&s->fifo, buf, len);
}
static uint8_t esp_fifo_pop(ESPState *s) static uint8_t esp_fifo_pop(ESPState *s)
{ {
if (fifo8_is_empty(&s->fifo)) { if (fifo8_is_empty(&s->fifo)) {
@ -601,7 +606,7 @@ static void esp_do_dma(ESPState *s)
} else { } else {
/* Copy device data to FIFO */ /* Copy device data to FIFO */
len = MIN(len, fifo8_num_free(&s->fifo)); len = MIN(len, fifo8_num_free(&s->fifo));
fifo8_push_all(&s->fifo, s->async_buf, len); esp_fifo_push_buf(s, s->async_buf, len);
esp_raise_drq(s); esp_raise_drq(s);
} }
@ -650,7 +655,7 @@ static void esp_do_dma(ESPState *s)
if (s->dma_memory_write) { if (s->dma_memory_write) {
s->dma_memory_write(s->dma_opaque, buf, len); s->dma_memory_write(s->dma_opaque, buf, len);
} else { } else {
fifo8_push_all(&s->fifo, buf, len); esp_fifo_push_buf(s, buf, len);
} }
esp_set_tc(s, esp_get_tc(s) - len); esp_set_tc(s, esp_get_tc(s) - len);
@ -685,7 +690,7 @@ static void esp_do_dma(ESPState *s)
if (s->dma_memory_write) { if (s->dma_memory_write) {
s->dma_memory_write(s->dma_opaque, buf, len); s->dma_memory_write(s->dma_opaque, buf, len);
} else { } else {
fifo8_push_all(&s->fifo, buf, len); esp_fifo_push_buf(s, buf, len);
} }
esp_set_tc(s, esp_get_tc(s) - len); esp_set_tc(s, esp_get_tc(s) - len);