OpenE2K/qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity

scripts/qmp-shell: Remove too-broad-exception

Browse Source 
We are only anticipating QMPShellErrors here, for syntax we weren't able
to understand. Other errors, if any, should be allowed to percolate
upwards.

Signed-off-by: John Snow <jsnow@redhat.com>
Message-id: 20210607200649.1840382-36-jsnow@redhat.com
Signed-off-by: John Snow <jsnow@redhat.com>
This commit is contained in:
John Snow 2021-06-07 16:06:42 -04:00
parent c83055ef1d
commit 26d3ce9e5e
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
scripts/qmp/qmp-shell
View File

@ -291,10 +291,13 @@ class QMPShell(qmp.QEMUMonitorProtocol):
def _execute_cmd(self, cmdline: str) -> bool: def _execute_cmd(self, cmdline: str) -> bool:
try: try:
qmpcmd = self.__build_cmd(cmdline) qmpcmd = self.__build_cmd(cmdline)
except Exception as err: except QMPShellError as err:
print('Error while parsing command line: %s' % err) print(
print('command format: <command-name> ', end=' ') f"Error while parsing command line: {err!s}\n"
print('[arg-name1=arg1] ... [arg-nameN=argN]') "command format: <command-name> "
"[arg-name1=arg1] ... [arg-nameN=argN",
file=sys.stderr
)
return True return True
# For transaction mode, we may have just cached the action: # For transaction mode, we may have just cached the action:
if qmpcmd is None: if qmpcmd is None: