hw/pvrdma: Post CQE when receive invalid gid index
This error should propagate back to guest.
Spotted by Coverity: CID 1398595
Fixes: 2b05705dc8
Reported-by: Li Qiang <liq3ea@163.com>
Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com>
Reviewed-by: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
This commit is contained in:
parent
732d948ca5
commit
26fd869556
|
@ -32,6 +32,7 @@
|
||||||
#define VENDOR_ERR_INVLKEY 0x207
|
#define VENDOR_ERR_INVLKEY 0x207
|
||||||
#define VENDOR_ERR_MR_SMALL 0x208
|
#define VENDOR_ERR_MR_SMALL 0x208
|
||||||
#define VENDOR_ERR_INV_MAD_BUFF 0x209
|
#define VENDOR_ERR_INV_MAD_BUFF 0x209
|
||||||
|
#define VENDOR_ERR_INV_GID_IDX 0x210
|
||||||
|
|
||||||
/* Add definition for QP0 and QP1 as there is no userspace enums for them */
|
/* Add definition for QP0 and QP1 as there is no userspace enums for them */
|
||||||
enum ibv_special_qp_type {
|
enum ibv_special_qp_type {
|
||||||
|
|
|
@ -178,7 +178,8 @@ int pvrdma_qp_send(PVRDMADev *dev, uint32_t qp_handle)
|
||||||
sgid = rdma_rm_get_gid(&dev->rdma_dev_res, wqe->hdr.wr.ud.av.gid_index);
|
sgid = rdma_rm_get_gid(&dev->rdma_dev_res, wqe->hdr.wr.ud.av.gid_index);
|
||||||
if (!sgid) {
|
if (!sgid) {
|
||||||
pr_dbg("Fail to get gid for idx %d\n", wqe->hdr.wr.ud.av.gid_index);
|
pr_dbg("Fail to get gid for idx %d\n", wqe->hdr.wr.ud.av.gid_index);
|
||||||
return -EIO;
|
complete_with_error(VENDOR_ERR_INV_GID_IDX, comp_ctx);
|
||||||
|
continue;
|
||||||
}
|
}
|
||||||
pr_dbg("sgid_id=%d, sgid=0x%llx\n", wqe->hdr.wr.ud.av.gid_index,
|
pr_dbg("sgid_id=%d, sgid=0x%llx\n", wqe->hdr.wr.ud.av.gid_index,
|
||||||
sgid->global.interface_id);
|
sgid->global.interface_id);
|
||||||
|
@ -189,7 +190,8 @@ int pvrdma_qp_send(PVRDMADev *dev, uint32_t qp_handle)
|
||||||
if (sgid_idx <= 0) {
|
if (sgid_idx <= 0) {
|
||||||
pr_dbg("Fail to get bk sgid_idx for sgid_idx %d\n",
|
pr_dbg("Fail to get bk sgid_idx for sgid_idx %d\n",
|
||||||
wqe->hdr.wr.ud.av.gid_index);
|
wqe->hdr.wr.ud.av.gid_index);
|
||||||
return -EIO;
|
complete_with_error(VENDOR_ERR_INV_GID_IDX, comp_ctx);
|
||||||
|
continue;
|
||||||
}
|
}
|
||||||
|
|
||||||
if (wqe->hdr.num_sge > dev->dev_attr.max_sge) {
|
if (wqe->hdr.num_sge > dev->dev_attr.max_sge) {
|
||||||
|
|
Loading…
Reference in New Issue