OpenE2K/qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity

dump: Drop qmp_dump_guest_memory() stub and build for all targets

Browse Source 
qmp_dump_guest_memory() calls dump_init() and returns an Error when
cpu_get_dump_info() returns an error, as done by the stub.
So there is no need to have a stub for qmp_dump_guest_memory().

Enable the documentation of the always-present dump-guest-memory command.

That way we can drop CONFIG_HAVE_CORE_DUMP and leave configure
completely out of the picture for target CPU features.

Signed-off-by: Andreas Färber <afaerber@suse.de>
This commit is contained in:
Andreas Färber 2013-05-17 11:54:40 +02:00
parent c22d8e0448
commit 2a78636bd2
4 changed files with 1 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Makefile.target
View File

@ -110,7 +110,7 @@ obj-$(CONFIG_FDT) += device_tree.o
obj-$(CONFIG_KVM) += kvm-all.o obj-$(CONFIG_KVM) += kvm-all.o
obj-y += memory.o savevm.o cputlb.o obj-y += memory.o savevm.o cputlb.o
obj-y += memory_mapping.o obj-y += memory_mapping.o
obj-$(CONFIG_HAVE_CORE_DUMP) += dump.o obj-y += dump.o
LIBS+=$(libs_softmmu) LIBS+=$(libs_softmmu)
# xen support # xen support

4
configure vendored
View File

@ -4303,10 +4303,6 @@ if test "$target_bigendian" = "yes" ; then
fi fi
if test "$target_softmmu" = "yes" ; then if test "$target_softmmu" = "yes" ; then
echo "CONFIG_SOFTMMU=y" >> $config_target_mak echo "CONFIG_SOFTMMU=y" >> $config_target_mak
case "$target_arch2" in
i386|x86_64)
echo "CONFIG_HAVE_CORE_DUMP=y" >> $config_target_mak
esac
fi fi
if test "$target_user_only" = "yes" ; then if test "$target_user_only" = "yes" ; then
echo "CONFIG_USER_ONLY=y" >> $config_target_mak echo "CONFIG_USER_ONLY=y" >> $config_target_mak

2
hmp-commands.hx
View File

@ -991,7 +991,6 @@ server will ask the spice/vnc client to automatically reconnect using the
new parameters (if specified) once the vm migration finished successfully. new parameters (if specified) once the vm migration finished successfully.
ETEXI ETEXI
#if defined(CONFIG_HAVE_CORE_DUMP)
{ {
.name = "dump-guest-memory", .name = "dump-guest-memory",
.args_type = "paging:-p,filename:F,begin:i?,length:i?", .args_type = "paging:-p,filename:F,begin:i?,length:i?",
@ -1015,7 +1014,6 @@ gdb.
length: the memory size, in bytes. It's optional, and should be specified length: the memory size, in bytes. It's optional, and should be specified
with begin together. with begin together.
ETEXI ETEXI
#endif
{ {
.name = "snapshot_blkdev", .name = "snapshot_blkdev",

8
stubs/dump.c
View File

@ -16,14 +16,6 @@
#include "qapi/qmp/qerror.h" #include "qapi/qmp/qerror.h"
#include "qmp-commands.h" #include "qmp-commands.h"
/* we need this function in hmp.c */
void qmp_dump_guest_memory(bool paging, const char *file, bool has_begin,
int64_t begin, bool has_length, int64_t length,
Error **errp)
{
error_set(errp, QERR_UNSUPPORTED);
}
int cpu_get_dump_info(ArchDumpInfo *info) int cpu_get_dump_info(ArchDumpInfo *info)
{ {
return -1; return -1;