OpenE2K/qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity

audio: don't use 'Yoda conditions'

Browse Source 
imitate nearby code about using '!value' or 'value == NULL'

Signed-off-by: Gonglei <arei.gonglei@huawei.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
This commit is contained in:
Gonglei 2014-08-11 21:00:53 +08:00 committed by Michael Tokarev
parent d0657b2aab
commit 2ab5bf67b7
3 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hw/audio/gus.c
View File

@ -212,7 +212,7 @@ static int GUS_read_DMA (void *opaque, int nchan, int dma_pos, int dma_len)
pos += copied; pos += copied;
} }
if (0 == ((mode >> 4) & 1)) { if (((mode >> 4) & 1) == 0) {
DMA_release_DREQ (s->emu.gusdma); DMA_release_DREQ (s->emu.gusdma);
} }
return dma_len; return dma_len;

3
hw/audio/hda-codec.c
View File

@ -489,8 +489,9 @@ static int hda_audio_init(HDACodecDevice *hda, const struct desc_codec *desc)
for (i = 0; i < a->desc->nnodes; i++) { for (i = 0; i < a->desc->nnodes; i++) {
node = a->desc->nodes + i; node = a->desc->nodes + i;
param = hda_codec_find_param(node, AC_PAR_AUDIO_WIDGET_CAP); param = hda_codec_find_param(node, AC_PAR_AUDIO_WIDGET_CAP);
if (NULL == param) if (param == NULL) {
continue; continue;
}
type = (param->val & AC_WCAP_TYPE) >> AC_WCAP_TYPE_SHIFT; type = (param->val & AC_WCAP_TYPE) >> AC_WCAP_TYPE_SHIFT;
switch (type) { switch (type) {
case AC_WID_AUD_OUT: case AC_WID_AUD_OUT:

6
hw/audio/sb16.c
View File

@ -928,7 +928,7 @@ static IO_WRITE_PROTO (dsp_write)
/* if (s->highspeed) */ /* if (s->highspeed) */
/* break; */ /* break; */
if (0 == s->needed_bytes) { if (s->needed_bytes == 0) {
command (s, val); command (s, val);
#if 0 #if 0
if (0 == s->needed_bytes) { if (0 == s->needed_bytes) {
@ -1212,7 +1212,7 @@ static int SB_read_DMA (void *opaque, int nchan, int dma_pos, int dma_len)
#endif #endif
if (till <= copy) { if (till <= copy) {
if (0 == s->dma_auto) { if (s->dma_auto == 0) {
copy = till; copy = till;
} }
} }
@ -1224,7 +1224,7 @@ static int SB_read_DMA (void *opaque, int nchan, int dma_pos, int dma_len)
if (s->left_till_irq <= 0) { if (s->left_till_irq <= 0) {
s->mixer_regs[0x82] |= (nchan & 4) ? 2 : 1; s->mixer_regs[0x82] |= (nchan & 4) ? 2 : 1;
qemu_irq_raise (s->pic); qemu_irq_raise (s->pic);
if (0 == s->dma_auto) { if (s->dma_auto == 0) {
control (s, 0); control (s, 0);
speaker (s, 0); speaker (s, 0);
} }