From 2ea3e2c1e85097c45a882dbc1fbba4a7fdb3ff1c Mon Sep 17 00:00:00 2001 From: Markus Armbruster Date: Thu, 27 Jun 2013 15:25:12 +0200 Subject: [PATCH] qemu-char: Fix ID reuse after chardev-remove for qapi-based init Commit 2c5f488 introduced qapi-based character device initialization as a new code path in qemu_chr_new_from_opts(). Unfortunately, it failed to store parameter opts in the new chardev. Therefore, qemu_chr_delete() doesn't delete it. Even though the device is gone, its options linger, and any attempt to create another one with the same ID fails. Cc: qemu-stable@nongnu.org Signed-off-by: Markus Armbruster Reviewed-by: Gerd Hoffmann Message-id: 1372339512-28149-1-git-send-email-armbru@redhat.com Signed-off-by: Anthony Liguori --- qemu-char.c | 1 + 1 file changed, 1 insertion(+) diff --git a/qemu-char.c b/qemu-char.c index a030e6b01e..63972ae4be 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -3219,6 +3219,7 @@ CharDriverState *qemu_chr_new_from_opts(QemuOpts *opts, } chr = qemu_chr_find(id); + chr->opts = opts; qapi_out: qapi_free_ChardevBackend(backend);