OpenE2K/qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity

semihosting: fix memleak at semihosting_arg_fallback

Browse Source 
We duplicate "cmd" as strtok may modify its argument, but we forgot
to free it later. Furthermore, add_semihosting_arg doesn't take
responsibility for this memory either (it strdup's the argument).

Signed-off-by: Matheus Tavares Bernardino <quic_mathbern@quicinc.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-Id: <03d81c56bfc3d08224e4106efca5949d8894cfa5.1697801632.git.quic_mathbern@quicinc.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20231029145033.592566-18-alex.bennee@linaro.org>
This commit is contained in:
Matheus Tavares Bernardino 2023-10-29 14:50:31 +00:00 committed by Alex Bennée
parent dbd6623ce7
commit 2eb71a0c20
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
semihosting/config.c
View File

@ -113,12 +113,13 @@ static int add_semihosting_arg(void *opaque,
void semihosting_arg_fallback(const char *file, const char *cmd) void semihosting_arg_fallback(const char *file, const char *cmd)
{ {
char *cmd_token; char *cmd_token;
g_autofree char *cmd_dup = g_strdup(cmd);
/* argv[0] */ /* argv[0] */
add_semihosting_arg(&semihosting, "arg", file, NULL); add_semihosting_arg(&semihosting, "arg", file, NULL);
/* split -append and initialize argv[1..n] */ /* split -append and initialize argv[1..n] */
cmd_token = strtok(g_strdup(cmd), " "); cmd_token = strtok(cmd_dup, " ");
while (cmd_token) { while (cmd_token) {
add_semihosting_arg(&semihosting, "arg", cmd_token, NULL); add_semihosting_arg(&semihosting, "arg", cmd_token, NULL);
cmd_token = strtok(NULL, " "); cmd_token = strtok(NULL, " ");