OpenE2K/qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity

usb-uhci: implement bandwidth management

Browse Source 
The OS is allowed to make the UHCI Controller run in circles.  That is
usually done to serve multiple connected USB devices in a robin-round
fashion, so the available USB bandwidth is evenly distributed between
devices.

The uhci emulation handles this in a very poor way though.  When it
figures it runs in circles it stops processing unconditionally, so
it usually processes at most a single transfer desriptor per queue,
even if there are multiple transfer descriptors are queued up.

This patch makes uhci act in a more sophisticated way.  It keeps track
of successful processed transfer descriptors and transfered bytes.  Then
it will stop processing when there is nothing to do (no transfer
descriptor was completed the last round) or when the transfered data
reaches the usb bandwidth limit.

Result is that the usb-storage devices connected to uhci are ten times
faster, mkfs.vfat time for a 64M stick goes down from five seconds to
a half second.  Reason for this is that we are now processing up to 20
transfer descriptors (with 64 bytes each) per frame instead of a single
one.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
This commit is contained in:
Gerd Hoffmann 2012-01-26 13:57:40 +01:00
parent 57c83dacfe
commit 3200d1085d
1 changed files with 22 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
hw/usb-uhci.c
View File

@ -73,7 +73,7 @@
#define FRAME_TIMER_FREQ 1000 #define FRAME_TIMER_FREQ 1000
#define FRAME_MAX_LOOPS 100 #define FRAME_MAX_LOOPS 256
#define NB_PORTS 2 #define NB_PORTS 2
@ -942,7 +942,7 @@ static int qhdb_insert(QhDb *db, uint32_t addr)
static void uhci_process_frame(UHCIState *s) static void uhci_process_frame(UHCIState *s)
{ {
uint32_t frame_addr, link, old_td_ctrl, val, int_mask; uint32_t frame_addr, link, old_td_ctrl, val, int_mask;
uint32_t curr_qh; uint32_t curr_qh, td_count = 0, bytes_count = 0;
int cnt, ret; int cnt, ret;
UHCI_TD td; UHCI_TD td;
UHCI_QH qh; UHCI_QH qh;
@ -968,12 +968,25 @@ static void uhci_process_frame(UHCIState *s)
/* /*
* We're going in circles. Which is not a bug because * We're going in circles. Which is not a bug because
* HCD is allowed to do that as part of the BW management. * HCD is allowed to do that as part of the BW management.
* In our case though it makes no sense to spin here. Sync transations *
* are already done, and async completion handler will re-process * Stop processing here if
* the frame when something is ready. * (a) no transaction has been done since we've been
* here last time, or
* (b) we've reached the usb 1.1 bandwidth, which is
* 1280 bytes/frame.
*/ */
DPRINTF("uhci: detected loop. qh 0x%x\n", link); DPRINTF("uhci: detected loop. qh 0x%x\n", link);
if (td_count == 0) {
DPRINTF("uhci: no transaction last round, stop\n");
break; break;
} else if (bytes_count >= 1280) {
DPRINTF("uhci: bandwidth limit reached, stop\n");
break;
} else {
td_count = 0;
qhdb_reset(&qhdb);
qhdb_insert(&qhdb, link);
}
} }
pci_dma_read(&s->dev, link & ~0xf, &qh, sizeof(qh)); pci_dma_read(&s->dev, link & ~0xf, &qh, sizeof(qh));
@ -1033,6 +1046,8 @@ static void uhci_process_frame(UHCIState *s)
link, td.link, td.ctrl, td.token, curr_qh); link, td.link, td.ctrl, td.token, curr_qh);
link = td.link; link = td.link;
td_count++;
bytes_count += (td.ctrl & 0x7ff) + 1;
if (curr_qh) { if (curr_qh) {
/* update QH element link */ /* update QH element link */