OpenE2K/qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity

hw/smbios: Fix port connector option validation

Browse Source 
qemu_smbios_type8_opts did not have the list terminator and that
resulted in out-of-bound memory access. It also needs to have an element
for the type option.

Cc: qemu-stable@nongnu.org
Fixes: fd8caa253c ("hw/smbios: support for type 8 (port connector)")
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>
Message-Id: <20240129-smbios-v2-2-9ee6fede0d10@daynix.com>
Reviewed-by: Ani Sinha <anisinha@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
This commit is contained in:
Akihiko Odaki 2024-01-29 17:03:08 +09:00 committed by Michael S. Tsirkin
parent e8ddec5805
commit 33b081e294
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
hw/smbios/smbios.c
View File

@ -352,6 +352,11 @@ static const QemuOptDesc qemu_smbios_type4_opts[] = {
}; };
static const QemuOptDesc qemu_smbios_type8_opts[] = { static const QemuOptDesc qemu_smbios_type8_opts[] = {
{
.name = "type",
.type = QEMU_OPT_NUMBER,
.help = "SMBIOS element type",
},
{ {
.name = "internal_reference", .name = "internal_reference",
.type = QEMU_OPT_STRING, .type = QEMU_OPT_STRING,
@ -372,6 +377,7 @@ static const QemuOptDesc qemu_smbios_type8_opts[] = {
.type = QEMU_OPT_NUMBER, .type = QEMU_OPT_NUMBER,
.help = "port type", .help = "port type",
}, },
{ /* end of list */ }
}; };
static const QemuOptDesc qemu_smbios_type11_opts[] = { static const QemuOptDesc qemu_smbios_type11_opts[] = {