OpenE2K/qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity

authz-pam: Check that 'service' property is set

Browse Source 
If the 'service' property is not set, we'll call pam_start() with a NULL
pointer for the service name. This fails and leaves a message like this
in the syslog:

qemu-storage-daemon[294015]: PAM pam_start: invalid argument: service == NULL

Make specifying the property mandatory and catch the error already
during the creation of the object.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
This commit is contained in:
Kevin Wolf 2020-11-17 17:30:44 +01:00 committed by Daniel P. Berrangé
parent 8e26ae7bb5
commit 3428455df9
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
authz/pamacct.c
View File

@ -84,6 +84,12 @@ qauthz_pam_prop_get_service(Object *obj,
static void static void
qauthz_pam_complete(UserCreatable *uc, Error **errp) qauthz_pam_complete(UserCreatable *uc, Error **errp)
{ {
QAuthZPAM *pauthz = QAUTHZ_PAM(uc);
if (!pauthz->service) {
error_setg(errp, "The 'service' property must be set");
return;
}
} }