OpenE2K/qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity

qxl: remove assert in qxl_pre_save.

Browse Source 
Since commit 551dbd0846 ("migration: check pre_save return in
vmstate_save_state") the pre_save hook can fail.  So lets finally
use that to drop the guest-triggerable assert in qxl_pre_save().

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20210721093347.338536-2-kraxel@redhat.com>
This commit is contained in:
Gerd Hoffmann 2021-07-21 11:33:46 +02:00
parent dc2deaba48
commit 39b8a183e2
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
hw/display/qxl.c
View File

@ -2283,7 +2283,9 @@ static int qxl_pre_save(void *opaque)
} else { } else {
d->last_release_offset = (uint8_t *)d->last_release - ram_start; d->last_release_offset = (uint8_t *)d->last_release - ram_start;
} }
assert(d->last_release_offset < d->vga.vram_size); if (d->last_release_offset < d->vga.vram_size) {
return 1;
}
return 0; return 0;
} }