OpenE2K
/
qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity

tests/qtest/bios-tables-test: Check for dup2() failure 

Coverity notes that we don't check for dup2() failing.  Add some
assertions so that if it does ever happen we get some indication.
(This is similar to how we handle other "don't expect this syscall to
fail" checks in this test code.)

Fixes: Coverity CID 1432346
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>
Message-id: 20210525134458.6675-2-peter.maydell@linaro.org
This commit is contained in:
Peter Maydell 2021-05-25 14:44:53 +01:00
parent bac969ef30
commit 3c65e439b2
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
tests/qtest/bios-tables-test.c
View File

@ -489,10 +489,14 @@ static void test_acpi_asl(test_data *data)
exp_sdt->asl_file, sdt->asl_file);
int out = dup(STDOUT_FILENO);
int ret G_GNUC_UNUSED;
int dupret;
dup2(STDERR_FILENO, STDOUT_FILENO);
g_assert(out >= 0);
dupret = dup2(STDERR_FILENO, STDOUT_FILENO);
g_assert(dupret >= 0);
ret = system(diff) ;
dup2(out, STDOUT_FILENO);
dupret = dup2(out, STDOUT_FILENO);
g_assert(dupret >= 0);
close(out);
g_free(diff);
}