target/mips: hold BQL in mips_vpe_wake()
Hold BQL whenever mips_vpe_wake() is invoked. Without this patch, MIPS MT with MTTCG enabled triggers an abort in tcg_handle_interrupt() due to an unlocked access to cpu_interrupt(). This patch makes sure that the BQL is held in this case. Signed-off-by: Goran Ferenc <goran.ferenc@imgtec.com> Signed-off-by: Miodrag Dinic <miodrag.dinic@imgtec.com> Signed-off-by: Aleksandar Markovic <amarkovic@wavecomp.com> Acked-by: Alex Bennée <alex.bennee@linaro.org> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
This commit is contained in:
parent
215581bdf1
commit
41931c0137
|
@ -17,6 +17,7 @@
|
||||||
* License along with this library; if not, see <http://www.gnu.org/licenses/>.
|
* License along with this library; if not, see <http://www.gnu.org/licenses/>.
|
||||||
*/
|
*/
|
||||||
#include "qemu/osdep.h"
|
#include "qemu/osdep.h"
|
||||||
|
#include "qemu/main-loop.h"
|
||||||
#include "cpu.h"
|
#include "cpu.h"
|
||||||
#include "internal.h"
|
#include "internal.h"
|
||||||
#include "qemu/host-utils.h"
|
#include "qemu/host-utils.h"
|
||||||
|
@ -638,7 +639,9 @@ static inline void mips_vpe_wake(MIPSCPU *c)
|
||||||
/* Don't set ->halted = 0 directly, let it be done via cpu_has_work
|
/* Don't set ->halted = 0 directly, let it be done via cpu_has_work
|
||||||
because there might be other conditions that state that c should
|
because there might be other conditions that state that c should
|
||||||
be sleeping. */
|
be sleeping. */
|
||||||
|
qemu_mutex_lock_iothread();
|
||||||
cpu_interrupt(CPU(c), CPU_INTERRUPT_WAKE);
|
cpu_interrupt(CPU(c), CPU_INTERRUPT_WAKE);
|
||||||
|
qemu_mutex_unlock_iothread();
|
||||||
}
|
}
|
||||||
|
|
||||||
static inline void mips_vpe_sleep(MIPSCPU *cpu)
|
static inline void mips_vpe_sleep(MIPSCPU *cpu)
|
||||||
|
|
Loading…
Reference in New Issue