tcg: Introduce arg_temp
Reviewed-by: Emilio G. Cota <cota@braap.org> Reviewed-by: Alex Bennée <alex.bennee@linaro.org> Signed-off-by: Richard Henderson <rth@twiddle.net>
This commit is contained in:
parent
dd18629201
commit
434391390b
@ -133,7 +133,7 @@ static TCGArg find_better_copy(TCGContext *s, TCGArg temp)
|
||||
}
|
||||
|
||||
/* If it is a temp, search for a temp local. */
|
||||
if (!s->temps[temp].temp_local) {
|
||||
if (!arg_temp(temp)->temp_local) {
|
||||
for (i = temps[temp].next_copy ; i != temp ; i = temps[i].next_copy) {
|
||||
if (s->temps[i].temp_local) {
|
||||
return i;
|
||||
@ -207,7 +207,7 @@ static void tcg_opt_gen_mov(TCGContext *s, TCGOp *op, TCGArg dst, TCGArg src)
|
||||
}
|
||||
temps[dst].mask = mask;
|
||||
|
||||
if (s->temps[src].type == s->temps[dst].type) {
|
||||
if (arg_temp(src)->type == arg_temp(dst)->type) {
|
||||
temps[dst].next_copy = temps[src].next_copy;
|
||||
temps[dst].prev_copy = src;
|
||||
temps[temps[dst].next_copy].prev_copy = dst;
|
||||
|
51
tcg/tcg.c
51
tcg/tcg.c
@ -1200,11 +1200,10 @@ static char *tcg_get_arg_str_ptr(TCGContext *s, char *buf, int buf_size,
|
||||
return buf;
|
||||
}
|
||||
|
||||
static char *tcg_get_arg_str_idx(TCGContext *s, char *buf,
|
||||
int buf_size, int idx)
|
||||
static char *tcg_get_arg_str(TCGContext *s, char *buf,
|
||||
int buf_size, TCGArg arg)
|
||||
{
|
||||
tcg_debug_assert(idx >= 0 && idx < s->nb_temps);
|
||||
return tcg_get_arg_str_ptr(s, buf, buf_size, &s->temps[idx]);
|
||||
return tcg_get_arg_str_ptr(s, buf, buf_size, arg_temp(arg));
|
||||
}
|
||||
|
||||
/* Find helper name. */
|
||||
@ -1307,14 +1306,14 @@ void tcg_dump_ops(TCGContext *s)
|
||||
tcg_find_helper(s, op->args[nb_oargs + nb_iargs]),
|
||||
op->args[nb_oargs + nb_iargs + 1], nb_oargs);
|
||||
for (i = 0; i < nb_oargs; i++) {
|
||||
col += qemu_log(",%s", tcg_get_arg_str_idx(s, buf, sizeof(buf),
|
||||
op->args[i]));
|
||||
col += qemu_log(",%s", tcg_get_arg_str(s, buf, sizeof(buf),
|
||||
op->args[i]));
|
||||
}
|
||||
for (i = 0; i < nb_iargs; i++) {
|
||||
TCGArg arg = op->args[nb_oargs + i];
|
||||
const char *t = "<dummy>";
|
||||
if (arg != TCG_CALL_DUMMY_ARG) {
|
||||
t = tcg_get_arg_str_idx(s, buf, sizeof(buf), arg);
|
||||
t = tcg_get_arg_str(s, buf, sizeof(buf), arg);
|
||||
}
|
||||
col += qemu_log(",%s", t);
|
||||
}
|
||||
@ -1330,15 +1329,15 @@ void tcg_dump_ops(TCGContext *s)
|
||||
if (k != 0) {
|
||||
col += qemu_log(",");
|
||||
}
|
||||
col += qemu_log("%s", tcg_get_arg_str_idx(s, buf, sizeof(buf),
|
||||
op->args[k++]));
|
||||
col += qemu_log("%s", tcg_get_arg_str(s, buf, sizeof(buf),
|
||||
op->args[k++]));
|
||||
}
|
||||
for (i = 0; i < nb_iargs; i++) {
|
||||
if (k != 0) {
|
||||
col += qemu_log(",");
|
||||
}
|
||||
col += qemu_log("%s", tcg_get_arg_str_idx(s, buf, sizeof(buf),
|
||||
op->args[k++]));
|
||||
col += qemu_log("%s", tcg_get_arg_str(s, buf, sizeof(buf),
|
||||
op->args[k++]));
|
||||
}
|
||||
switch (c) {
|
||||
case INDEX_op_brcond_i32:
|
||||
@ -1930,7 +1929,7 @@ static bool liveness_pass_2(TCGContext *s, uint8_t *temp_state)
|
||||
if (arg < nb_globals) {
|
||||
dir = dir_temps[arg];
|
||||
if (dir != 0 && temp_state[arg] == TS_DEAD) {
|
||||
TCGTemp *its = &s->temps[arg];
|
||||
TCGTemp *its = arg_temp(arg);
|
||||
TCGOpcode lopc = (its->type == TCG_TYPE_I32
|
||||
? INDEX_op_ld_i32
|
||||
: INDEX_op_ld_i64);
|
||||
@ -2001,7 +2000,7 @@ static bool liveness_pass_2(TCGContext *s, uint8_t *temp_state)
|
||||
|
||||
/* Sync outputs upon their last write. */
|
||||
if (NEED_SYNC_ARG(i)) {
|
||||
TCGTemp *its = &s->temps[arg];
|
||||
TCGTemp *its = arg_temp(arg);
|
||||
TCGOpcode sopc = (its->type == TCG_TYPE_I32
|
||||
? INDEX_op_st_i32
|
||||
: INDEX_op_st_i64);
|
||||
@ -2032,7 +2031,7 @@ static void dump_regs(TCGContext *s)
|
||||
|
||||
for(i = 0; i < s->nb_temps; i++) {
|
||||
ts = &s->temps[i];
|
||||
printf(" %10s: ", tcg_get_arg_str_idx(s, buf, sizeof(buf), i));
|
||||
printf(" %10s: ", tcg_get_arg_str_ptr(s, buf, sizeof(buf), ts));
|
||||
switch(ts->val_type) {
|
||||
case TEMP_VAL_REG:
|
||||
printf("%s", tcg_target_reg_names[ts->reg]);
|
||||
@ -2336,7 +2335,7 @@ static void tcg_reg_alloc_do_movi(TCGContext *s, TCGTemp *ots,
|
||||
|
||||
static void tcg_reg_alloc_movi(TCGContext *s, const TCGOp *op)
|
||||
{
|
||||
TCGTemp *ots = &s->temps[op->args[0]];
|
||||
TCGTemp *ots = arg_temp(op->args[0]);
|
||||
tcg_target_ulong val = op->args[1];
|
||||
|
||||
tcg_reg_alloc_do_movi(s, ots, val, op->life);
|
||||
@ -2350,8 +2349,8 @@ static void tcg_reg_alloc_mov(TCGContext *s, const TCGOp *op)
|
||||
TCGType otype, itype;
|
||||
|
||||
allocated_regs = s->reserved_regs;
|
||||
ots = &s->temps[op->args[0]];
|
||||
ts = &s->temps[op->args[1]];
|
||||
ots = arg_temp(op->args[0]);
|
||||
ts = arg_temp(op->args[1]);
|
||||
|
||||
/* Note that otype != itype for no-op truncation. */
|
||||
otype = ots->type;
|
||||
@ -2445,7 +2444,7 @@ static void tcg_reg_alloc_op(TCGContext *s, const TCGOp *op)
|
||||
i = def->sorted_args[nb_oargs + k];
|
||||
arg = op->args[i];
|
||||
arg_ct = &def->args_ct[i];
|
||||
ts = &s->temps[arg];
|
||||
ts = arg_temp(arg);
|
||||
|
||||
if (ts->val_type == TEMP_VAL_CONST
|
||||
&& tcg_target_const_match(ts->val, ts->type, arg_ct)) {
|
||||
@ -2502,7 +2501,7 @@ static void tcg_reg_alloc_op(TCGContext *s, const TCGOp *op)
|
||||
/* mark dead temporaries and free the associated registers */
|
||||
for (i = nb_oargs; i < nb_oargs + nb_iargs; i++) {
|
||||
if (IS_DEAD_ARG(i)) {
|
||||
temp_dead(s, &s->temps[op->args[i]]);
|
||||
temp_dead(s, arg_temp(op->args[i]));
|
||||
}
|
||||
}
|
||||
|
||||
@ -2528,7 +2527,7 @@ static void tcg_reg_alloc_op(TCGContext *s, const TCGOp *op)
|
||||
i = def->sorted_args[k];
|
||||
arg = op->args[i];
|
||||
arg_ct = &def->args_ct[i];
|
||||
ts = &s->temps[arg];
|
||||
ts = arg_temp(arg);
|
||||
if ((arg_ct->ct & TCG_CT_ALIAS)
|
||||
&& !const_args[arg_ct->alias_index]) {
|
||||
reg = new_args[arg_ct->alias_index];
|
||||
@ -2569,7 +2568,7 @@ static void tcg_reg_alloc_op(TCGContext *s, const TCGOp *op)
|
||||
|
||||
/* move the outputs in the correct register if needed */
|
||||
for(i = 0; i < nb_oargs; i++) {
|
||||
ts = &s->temps[op->args[i]];
|
||||
ts = arg_temp(op->args[i]);
|
||||
reg = new_args[i];
|
||||
if (ts->fixed_reg && ts->reg != reg) {
|
||||
tcg_out_mov(s, ts->type, ts->reg, reg);
|
||||
@ -2629,7 +2628,7 @@ static void tcg_reg_alloc_call(TCGContext *s, TCGOp *op)
|
||||
stack_offset -= sizeof(tcg_target_long);
|
||||
#endif
|
||||
if (arg != TCG_CALL_DUMMY_ARG) {
|
||||
ts = &s->temps[arg];
|
||||
ts = arg_temp(arg);
|
||||
temp_load(s, ts, tcg_target_available_regs[ts->type],
|
||||
s->reserved_regs);
|
||||
tcg_out_st(s, ts->type, ts->reg, TCG_REG_CALL_STACK, stack_offset);
|
||||
@ -2644,7 +2643,7 @@ static void tcg_reg_alloc_call(TCGContext *s, TCGOp *op)
|
||||
for (i = 0; i < nb_regs; i++) {
|
||||
arg = op->args[nb_oargs + i];
|
||||
if (arg != TCG_CALL_DUMMY_ARG) {
|
||||
ts = &s->temps[arg];
|
||||
ts = arg_temp(arg);
|
||||
reg = tcg_target_call_iarg_regs[i];
|
||||
tcg_reg_free(s, reg, allocated_regs);
|
||||
|
||||
@ -2666,7 +2665,7 @@ static void tcg_reg_alloc_call(TCGContext *s, TCGOp *op)
|
||||
/* mark dead temporaries and free the associated registers */
|
||||
for (i = nb_oargs; i < nb_iargs + nb_oargs; i++) {
|
||||
if (IS_DEAD_ARG(i)) {
|
||||
temp_dead(s, &s->temps[op->args[i]]);
|
||||
temp_dead(s, arg_temp(op->args[i]));
|
||||
}
|
||||
}
|
||||
|
||||
@ -2692,7 +2691,7 @@ static void tcg_reg_alloc_call(TCGContext *s, TCGOp *op)
|
||||
/* assign output registers and emit moves if needed */
|
||||
for(i = 0; i < nb_oargs; i++) {
|
||||
arg = op->args[i];
|
||||
ts = &s->temps[arg];
|
||||
ts = arg_temp(arg);
|
||||
reg = tcg_target_call_oarg_regs[i];
|
||||
tcg_debug_assert(s->reg_to_temp[reg] == NULL);
|
||||
|
||||
@ -2870,7 +2869,7 @@ int tcg_gen_code(TCGContext *s, TranslationBlock *tb)
|
||||
}
|
||||
break;
|
||||
case INDEX_op_discard:
|
||||
temp_dead(s, &s->temps[op->args[0]]);
|
||||
temp_dead(s, arg_temp(op->args[0]));
|
||||
break;
|
||||
case INDEX_op_set_label:
|
||||
tcg_reg_alloc_bb_end(s, s->reserved_regs);
|
||||
|
@ -725,6 +725,11 @@ struct TCGContext {
|
||||
extern TCGContext tcg_ctx;
|
||||
extern bool parallel_cpus;
|
||||
|
||||
static inline TCGTemp *arg_temp(TCGArg a)
|
||||
{
|
||||
return &tcg_ctx.temps[a];
|
||||
}
|
||||
|
||||
static inline void tcg_set_insn_param(int op_idx, int arg, TCGArg v)
|
||||
{
|
||||
tcg_ctx.gen_op_buf[op_idx].args[arg] = v;
|
||||
|
Loading…
Reference in New Issue
Block a user