OpenE2K/qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity

monitor: print message when using 'help' with an unknown command

Browse Source 
When typing 'help' followed by an unknown command, QEMU will
not print anything to the command line to let the user know
they typed a bad command. Let's fix this by printing a message
to the monitor when this happens. For example:

    (qemu) help xyz
    unknown command: 'xyz'

Reported-by: Stefan Zimmermann <stzi@linux.ibm.com>
Signed-off-by: Collin Walling <walling@linux.ibm.com>
Message-Id: <1532115624-27568-1-git-send-email-walling@linux.ibm.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
This commit is contained in:
Collin Walling 2018-07-20 15:40:24 -04:00 committed by Dr. David Alan Gilbert
parent 506e4a00de
commit 43e87b3eaf
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
monitor.c
View File

@ -952,6 +952,7 @@ static void help_cmd_dump(Monitor *mon, const mon_cmd_t *cmds,
char **args, int nb_args, int arg_index) char **args, int nb_args, int arg_index)
{ {
const mon_cmd_t *cmd; const mon_cmd_t *cmd;
size_t i;
/* No valid arg need to compare with, dump all in *cmds */ /* No valid arg need to compare with, dump all in *cmds */
if (arg_index >= nb_args) { if (arg_index >= nb_args) {
@ -973,9 +974,15 @@ static void help_cmd_dump(Monitor *mon, const mon_cmd_t *cmds,
} else { } else {
help_cmd_dump_one(mon, cmd, args, arg_index); help_cmd_dump_one(mon, cmd, args, arg_index);
} }
break; return;
} }
} }
/* Command not found */
monitor_printf(mon, "unknown command: '");
for (i = 0; i <= arg_index; i++) {
monitor_printf(mon, "%s%s", args[i], i == arg_index ? "'\n" : " ");
}
} }
static void help_cmd(Monitor *mon, const char *name) static void help_cmd(Monitor *mon, const char *name)