OpenE2K/qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity

crypto: use error_abort for unexpected failures

Browse Source 
This improves the error diagnosis from the unit test when a cipher
is unexpected not available from

ERROR:../tests/unit/test-crypto-cipher.c:683:test_cipher: assertion failed: (err == NULL)
Bail out! ERROR:../tests/unit/test-crypto-cipher.c:683:test_cipher: assertion failed: (err == NULL)
Aborted (core dumped)

to

Unexpected error in qcrypto_cipher_ctx_new() at ../crypto/cipher-gcrypt.c.inc:262:
./build//tests/unit/test-crypto-cipher: Cannot initialize cipher: Invalid cipher algorithm
Aborted (core dumped)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
This commit is contained in:
Daniel P. Berrangé 2024-03-11 12:11:09 +00:00
parent e503fc55ac
commit 48ca1cabd3
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tests/unit/test-crypto-cipher.c
View File

@ -676,9 +676,8 @@ static void test_cipher(const void *opaque)
cipher = qcrypto_cipher_new( cipher = qcrypto_cipher_new(
data->alg, data->mode, data->alg, data->mode,
key, nkey, key, nkey,
&err); data->plaintext ? &error_abort : &err);
if (data->plaintext) { if (data->plaintext) {
g_assert(err == NULL);
g_assert(cipher != NULL); g_assert(cipher != NULL);
} else { } else {
error_free_or_abort(&err); error_free_or_abort(&err);