migration: Clean up use of g_poll() in socket_writev_buffer()
socket_writev_buffer() writes in a loop, using g_poll() to block. If g_poll() fails, it tries to write more before the file descriptor is ready. In theory, this could go into a tight loop. In practice, errors other than EINTR are really unlikely, and when they happen, we're probably screwed anyway, so we can just as well loop. Clean it up a bit: retry poll on EINTR, keep ignoring other errors. Signed-off-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com> Reviewed-by: Juan Quintela <quintela@redhat.com> Signed-off-by: Juan Quintela <quintela@redhat.com>
This commit is contained in:
parent
cf22132367
commit
4e39f57c00
@ -72,7 +72,8 @@ static ssize_t socket_writev_buffer(void *opaque, struct iovec *iov, int iovcnt,
|
||||
pfd.fd = s->fd;
|
||||
pfd.events = G_IO_OUT | G_IO_ERR;
|
||||
pfd.revents = 0;
|
||||
g_poll(&pfd, 1 /* 1 fd */, -1 /* no timeout */);
|
||||
TFR(err = g_poll(&pfd, 1, -1 /* no timeout */));
|
||||
/* Errors other than EINTR intentionally ignored */
|
||||
}
|
||||
}
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user