OpenE2K/qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity

cris-dis: Clean memory allocation

Browse Source 
The old code used sizeof(const struct cris_opcode **) where it should
have used sizeof(const struct cris_opcode *). As both sizes give the
same value, the resulting binary was ok, but static code analyzers
like coverity and clang complained.

This is fixed here, and the code is also simplified by using g_new0.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Edgar E. Iglesias <edgar.iglesias@gmail.com>
This commit is contained in:
Stefan Weil 2012-01-09 19:23:42 +01:00 committed by Edgar E. Iglesias
parent cd9244e48a
commit 520a02f8b8
1 changed files with 6 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
cris-dis.c
View File

@ -1396,34 +1396,12 @@ get_opcode_entry (unsigned int insn,
/* Allocate and clear the opcode-table. */ /* Allocate and clear the opcode-table. */
if (opc_table == NULL) if (opc_table == NULL)
{ {
opc_table = g_malloc (65536 * sizeof (opc_table[0])); opc_table = g_new0(const struct cris_opcode *, 65536);
dip_prefixes = g_new0(const struct cris_opcode *, 65536);
memset (opc_table, 0, 65536 * sizeof (const struct cris_opcode *)); bdapq_m1_prefixes = g_new0(const struct cris_opcode *, 65536);
bdapq_m2_prefixes = g_new0(const struct cris_opcode *, 65536);
dip_prefixes bdapq_m4_prefixes = g_new0(const struct cris_opcode *, 65536);
= g_malloc (65536 * sizeof (const struct cris_opcode **)); rest_prefixes = g_new0(const struct cris_opcode *, 65536);
memset (dip_prefixes, 0, 65536 * sizeof (dip_prefixes[0]));
bdapq_m1_prefixes
= g_malloc (65536 * sizeof (const struct cris_opcode **));
memset (bdapq_m1_prefixes, 0, 65536 * sizeof (bdapq_m1_prefixes[0]));
bdapq_m2_prefixes
= g_malloc (65536 * sizeof (const struct cris_opcode **));
memset (bdapq_m2_prefixes, 0, 65536 * sizeof (bdapq_m2_prefixes[0]));
bdapq_m4_prefixes
= g_malloc (65536 * sizeof (const struct cris_opcode **));
memset (bdapq_m4_prefixes, 0, 65536 * sizeof (bdapq_m4_prefixes[0]));
rest_prefixes
= g_malloc (65536 * sizeof (const struct cris_opcode **));
memset (rest_prefixes, 0, 65536 * sizeof (rest_prefixes[0]));
} }
/* Get the right table if this is a prefix. /* Get the right table if this is a prefix.