OpenE2K/qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity

smbios: Fix -smbios type=0, release=... for big endian hosts

Browse Source 
Classic endianness bug due to careless dirty coding: assuming reading
a byte from an int variable gets the least significant byte.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Laszlo "ever the optimist" Ersek <lersek@redhat.com>
Message-id: 1370610036-10577-6-git-send-email-armbru@redhat.com
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
This commit is contained in:
Markus Armbruster 2013-06-07 15:00:35 +02:00 committed by Anthony Liguori
parent ebc85e3f72
commit 527cd96f15
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
hw/i386/smbios.c
View File

@ -127,6 +127,7 @@ void smbios_add_field(int type, int offset, const void *data, size_t len)
static void smbios_build_type_0_fields(const char *t) static void smbios_build_type_0_fields(const char *t)
{ {
char buf[1024]; char buf[1024];
unsigned char major, minor;
if (get_param_value(buf, sizeof(buf), "vendor", t)) if (get_param_value(buf, sizeof(buf), "vendor", t))
smbios_add_field(0, offsetof(struct smbios_type_0, vendor_str), smbios_add_field(0, offsetof(struct smbios_type_0, vendor_str),
@ -139,8 +140,7 @@ static void smbios_build_type_0_fields(const char *t)
bios_release_date_str), bios_release_date_str),
buf, strlen(buf) + 1); buf, strlen(buf) + 1);
if (get_param_value(buf, sizeof(buf), "release", t)) { if (get_param_value(buf, sizeof(buf), "release", t)) {
int major, minor; sscanf(buf, "%hhu.%hhu", &major, &minor);
sscanf(buf, "%d.%d", &major, &minor);
smbios_add_field(0, offsetof(struct smbios_type_0, smbios_add_field(0, offsetof(struct smbios_type_0,
system_bios_major_release), system_bios_major_release),
&major, 1); &major, 1);