OpenE2K/qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity

linux-user/elfload: Fully initialize struct target_elf_prpsinfo

Browse Source 
Fixes Coverity CID: 1534962
Fixes: 243c470662 ("linux-user/elfload: Write corefile elf header in one block")
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
This commit is contained in:
Richard Henderson 2024-03-05 10:35:45 -10:00
parent b35348c7e6
commit 52e566b34f
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
linux-user/elfload.c
View File

@ -4204,7 +4204,14 @@ static void fill_prpsinfo_note(void *data, const TaskState *ts)
* may well have higher alignment requirements, fill locally and * may well have higher alignment requirements, fill locally and
* memcpy to the destination afterward. * memcpy to the destination afterward.
*/ */
struct target_elf_prpsinfo psinfo; struct target_elf_prpsinfo psinfo = {
.pr_pid = getpid(),
.pr_ppid = getppid(),
.pr_pgrp = getpgrp(),
.pr_sid = getsid(0),
.pr_uid = getuid(),
.pr_gid = getgid(),
};
char *base_filename; char *base_filename;
size_t len; size_t len;
@ -4217,13 +4224,6 @@ static void fill_prpsinfo_note(void *data, const TaskState *ts)
} }
} }
psinfo.pr_pid = getpid();
psinfo.pr_ppid = getppid();
psinfo.pr_pgrp = getpgrp();
psinfo.pr_sid = getsid(0);
psinfo.pr_uid = getuid();
psinfo.pr_gid = getgid();
base_filename = g_path_get_basename(ts->bprm->filename); base_filename = g_path_get_basename(ts->bprm->filename);
/* /*
* Using strncpy here is fine: at max-length, * Using strncpy here is fine: at max-length,