authz: add QAuthZ object as an authorization base class
The current qemu_acl module provides a simple access control list facility inside QEMU, which is used via a set of monitor commands acl_show, acl_policy, acl_add, acl_remove & acl_reset. Note there is no ability to create ACLs - the network services (eg VNC server) were expected to create ACLs that they want to check. There is also no way to define ACLs on the command line, nor potentially integrate with external authorization systems like polkit, pam, ldap lookup, etc. The QAuthZ object defines a minimal abstract QOM class that can be subclassed for creating different authorization providers. Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
This commit is contained in:
Daniel P. Berrange
Daniel P. Berrangé
parent
47287c27d0
commit
5b76dd132c
@ -2079,6 +2079,13 @@ F: io/
|
||||
F: include/io/
|
||||
F: tests/test-io-*
|
||||
|
||||
User authorization
|
||||
M: Daniel P. Berrange <berrange@redhat.com>
|
||||
S: Maintained
|
||||
F: authz/
|
||||
F: include/authz/
|
||||
F: tests/test-authz-*
|
||||
|
||||
Sockets
|
||||
M: Daniel P. Berrange <berrange@redhat.com>
|
||||
M: Gerd Hoffmann <kraxel@redhat.com>
|
||||
|
||||
10
Makefile
10
Makefile
@ -359,6 +359,7 @@ endif
|
||||
|
||||
dummy := $(call unnest-vars,, \
|
||||
stub-obj-y \
|
||||
authz-obj-y \
|
||||
chardev-obj-y \
|
||||
util-obj-y \
|
||||
qga-obj-y \
|
||||
@ -423,6 +424,7 @@ qemu-options.def: $(SRC_PATH)/qemu-options.hx $(SRC_PATH)/scripts/hxtool
|
||||
SUBDIR_RULES=$(patsubst %,subdir-%, $(TARGET_DIRS))
|
||||
SOFTMMU_SUBDIR_RULES=$(filter %-softmmu,$(SUBDIR_RULES))
|
||||
|
||||
$(SOFTMMU_SUBDIR_RULES): $(authz-obj-y)
|
||||
$(SOFTMMU_SUBDIR_RULES): $(block-obj-y)
|
||||
$(SOFTMMU_SUBDIR_RULES): $(crypto-obj-y)
|
||||
$(SOFTMMU_SUBDIR_RULES): $(io-obj-y)
|
||||
@ -485,9 +487,9 @@ COMMON_LDADDS = libqemuutil.a
|
||||
|
||||
qemu-img.o: qemu-img-cmds.h
|
||||
|
||||
qemu-img$(EXESUF): qemu-img.o $(block-obj-y) $(crypto-obj-y) $(io-obj-y) $(qom-obj-y) $(COMMON_LDADDS)
|
||||
qemu-nbd$(EXESUF): qemu-nbd.o $(block-obj-y) $(crypto-obj-y) $(io-obj-y) $(qom-obj-y) $(COMMON_LDADDS)
|
||||
qemu-io$(EXESUF): qemu-io.o $(block-obj-y) $(crypto-obj-y) $(io-obj-y) $(qom-obj-y) $(COMMON_LDADDS)
|
||||
qemu-img$(EXESUF): qemu-img.o $(authz-obj-y) $(block-obj-y) $(crypto-obj-y) $(io-obj-y) $(qom-obj-y) $(COMMON_LDADDS)
|
||||
qemu-nbd$(EXESUF): qemu-nbd.o $(authz-obj-y) $(block-obj-y) $(crypto-obj-y) $(io-obj-y) $(qom-obj-y) $(COMMON_LDADDS)
|
||||
qemu-io$(EXESUF): qemu-io.o $(authz-obj-y) $(block-obj-y) $(crypto-obj-y) $(io-obj-y) $(qom-obj-y) $(COMMON_LDADDS)
|
||||
|
||||
qemu-bridge-helper$(EXESUF): qemu-bridge-helper.o $(COMMON_LDADDS)
|
||||
|
||||
@ -498,7 +500,7 @@ qemu-edid$(EXESUF): qemu-edid.o hw/display/edid-generate.o $(COMMON_LDADDS)
|
||||
fsdev/virtfs-proxy-helper$(EXESUF): fsdev/virtfs-proxy-helper.o fsdev/9p-marshal.o fsdev/9p-iov-marshal.o $(COMMON_LDADDS)
|
||||
fsdev/virtfs-proxy-helper$(EXESUF): LIBS += -lcap
|
||||
|
||||
scsi/qemu-pr-helper$(EXESUF): scsi/qemu-pr-helper.o scsi/utils.o $(crypto-obj-y) $(io-obj-y) $(qom-obj-y) $(COMMON_LDADDS)
|
||||
scsi/qemu-pr-helper$(EXESUF): scsi/qemu-pr-helper.o scsi/utils.o $(authz-obj-y) $(crypto-obj-y) $(io-obj-y) $(qom-obj-y) $(COMMON_LDADDS)
|
||||
ifdef CONFIG_MPATH
|
||||
scsi/qemu-pr-helper$(EXESUF): LIBS += -ludev -lmultipath -lmpathpersist
|
||||
endif
|
||||
|
||||
@ -6,6 +6,11 @@ util-obj-y = util/ qobject/ qapi/
|
||||
chardev-obj-y = chardev/
|
||||
slirp-obj-$(CONFIG_SLIRP) = slirp/
|
||||
|
||||
#######################################################################
|
||||
# authz-obj-y is code used by both qemu system emulation and qemu-img
|
||||
|
||||
authz-obj-y = authz/
|
||||
|
||||
#######################################################################
|
||||
# block-obj-y is code used by both qemu system emulation and qemu-img
|
||||
|
||||
@ -125,6 +130,7 @@ trace-events-subdirs =
|
||||
trace-events-subdirs += accel/kvm
|
||||
trace-events-subdirs += accel/tcg
|
||||
trace-events-subdirs += audio
|
||||
trace-events-subdirs += authz
|
||||
trace-events-subdirs += block
|
||||
trace-events-subdirs += chardev
|
||||
trace-events-subdirs += crypto
|
||||
|
||||
@ -179,6 +179,7 @@ include $(SRC_PATH)/Makefile.objs
|
||||
dummy := $(call unnest-vars,,target-obj-y)
|
||||
target-obj-y-save := $(target-obj-y)
|
||||
dummy := $(call unnest-vars,.., \
|
||||
authz-obj-y \
|
||||
block-obj-y \
|
||||
block-obj-m \
|
||||
chardev-obj-y \
|
||||
@ -193,6 +194,7 @@ target-obj-y := $(target-obj-y-save)
|
||||
all-obj-y += $(common-obj-y)
|
||||
all-obj-y += $(target-obj-y)
|
||||
all-obj-y += $(qom-obj-y)
|
||||
all-obj-$(CONFIG_SOFTMMU) += $(authz-obj-y)
|
||||
all-obj-$(CONFIG_SOFTMMU) += $(block-obj-y) $(chardev-obj-y)
|
||||
all-obj-$(CONFIG_USER_ONLY) += $(crypto-aes-obj-y)
|
||||
all-obj-$(CONFIG_SOFTMMU) += $(crypto-obj-y)
|
||||
|
||||
1
authz/Makefile.objs
Normal file
1
authz/Makefile.objs
Normal file
@ -0,0 +1 @@
|
||||
authz-obj-y += base.o
|
||||
82
authz/base.c
Normal file
82
authz/base.c
Normal file
@ -0,0 +1,82 @@
|
||||
/*
|
||||
* QEMU authorization framework base class
|
||||
*
|
||||
* Copyright (c) 2018 Red Hat, Inc.
|
||||
*
|
||||
* This library is free software; you can redistribute it and/or
|
||||
* modify it under the terms of the GNU Lesser General Public
|
||||
* License as published by the Free Software Foundation; either
|
||||
* version 2 of the License, or (at your option) any later version.
|
||||
*
|
||||
* This library is distributed in the hope that it will be useful,
|
||||
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
||||
* Lesser General Public License for more details.
|
||||
*
|
||||
* You should have received a copy of the GNU Lesser General Public
|
||||
* License along with this library; if not, see <http://www.gnu.org/licenses/>.
|
||||
*
|
||||
*/
|
||||
|
||||
#include "qemu/osdep.h"
|
||||
#include "authz/base.h"
|
||||
#include "authz/trace.h"
|
||||
|
||||
bool qauthz_is_allowed(QAuthZ *authz,
|
||||
const char *identity,
|
||||
Error **errp)
|
||||
{
|
||||
QAuthZClass *cls = QAUTHZ_GET_CLASS(authz);
|
||||
bool allowed;
|
||||
|
||||
allowed = cls->is_allowed(authz, identity, errp);
|
||||
trace_qauthz_is_allowed(authz, identity, allowed);
|
||||
|
||||
return allowed;
|
||||
}
|
||||
|
||||
|
||||
bool qauthz_is_allowed_by_id(const char *authzid,
|
||||
const char *identity,
|
||||
Error **errp)
|
||||
{
|
||||
QAuthZ *authz;
|
||||
Object *obj;
|
||||
Object *container;
|
||||
|
||||
container = object_get_objects_root();
|
||||
obj = object_resolve_path_component(container,
|
||||
authzid);
|
||||
if (!obj) {
|
||||
error_setg(errp, "Cannot find QAuthZ object ID %s",
|
||||
authzid);
|
||||
return false;
|
||||
}
|
||||
|
||||
if (!object_dynamic_cast(obj, TYPE_QAUTHZ)) {
|
||||
error_setg(errp, "Object '%s' is not a QAuthZ subclass",
|
||||
authzid);
|
||||
return false;
|
||||
}
|
||||
|
||||
authz = QAUTHZ(obj);
|
||||
|
||||
return qauthz_is_allowed(authz, identity, errp);
|
||||
}
|
||||
|
||||
|
||||
static const TypeInfo authz_info = {
|
||||
.parent = TYPE_OBJECT,
|
||||
.name = TYPE_QAUTHZ,
|
||||
.instance_size = sizeof(QAuthZ),
|
||||
.class_size = sizeof(QAuthZClass),
|
||||
.abstract = true,
|
||||
};
|
||||
|
||||
static void qauthz_register_types(void)
|
||||
{
|
||||
type_register_static(&authz_info);
|
||||
}
|
||||
|
||||
type_init(qauthz_register_types)
|
||||
|
||||
4
authz/trace-events
Normal file
4
authz/trace-events
Normal file
@ -0,0 +1,4 @@
|
||||
# See docs/devel/tracing.txt for syntax documentation.
|
||||
|
||||
# authz/base.c
|
||||
qauthz_is_allowed(void *authz, const char *identity, bool allowed) "AuthZ %p check identity=%s allowed=%d"
|
||||
112
include/authz/base.h
Normal file
112
include/authz/base.h
Normal file
@ -0,0 +1,112 @@
|
||||
/*
|
||||
* QEMU authorization framework base class
|
||||
*
|
||||
* Copyright (c) 2018 Red Hat, Inc.
|
||||
*
|
||||
* This library is free software; you can redistribute it and/or
|
||||
* modify it under the terms of the GNU Lesser General Public
|
||||
* License as published by the Free Software Foundation; either
|
||||
* version 2 of the License, or (at your option) any later version.
|
||||
*
|
||||
* This library is distributed in the hope that it will be useful,
|
||||
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
||||
* Lesser General Public License for more details.
|
||||
*
|
||||
* You should have received a copy of the GNU Lesser General Public
|
||||
* License along with this library; if not, see <http://www.gnu.org/licenses/>.
|
||||
*
|
||||
*/
|
||||
|
||||
#ifndef QAUTHZ_BASE_H__
|
||||
#define QAUTHZ_BASE_H__
|
||||
|
||||
#include "qemu-common.h"
|
||||
#include "qapi/error.h"
|
||||
#include "qom/object.h"
|
||||
|
||||
|
||||
#define TYPE_QAUTHZ "authz"
|
||||
|
||||
#define QAUTHZ_CLASS(klass) \
|
||||
OBJECT_CLASS_CHECK(QAuthZClass, (klass), \
|
||||
TYPE_QAUTHZ)
|
||||
#define QAUTHZ_GET_CLASS(obj) \
|
||||
OBJECT_GET_CLASS(QAuthZClass, (obj), \
|
||||
TYPE_QAUTHZ)
|
||||
#define QAUTHZ(obj) \
|
||||
INTERFACE_CHECK(QAuthZ, (obj), \
|
||||
TYPE_QAUTHZ)
|
||||
|
||||
typedef struct QAuthZ QAuthZ;
|
||||
typedef struct QAuthZClass QAuthZClass;
|
||||
|
||||
/**
|
||||
* QAuthZ:
|
||||
*
|
||||
* The QAuthZ class defines an API contract to be used
|
||||
* for providing an authorization driver for services
|
||||
* with user identities.
|
||||
*/
|
||||
|
||||
struct QAuthZ {
|
||||
Object parent_obj;
|
||||
};
|
||||
|
||||
|
||||
struct QAuthZClass {
|
||||
ObjectClass parent_class;
|
||||
|
||||
bool (*is_allowed)(QAuthZ *authz,
|
||||
const char *identity,
|
||||
Error **errp);
|
||||
};
|
||||
|
||||
|
||||
/**
|
||||
* qauthz_is_allowed:
|
||||
* @authz: the authorization object
|
||||
* @identity: the user identity to authorize
|
||||
* @errp: pointer to a NULL initialized error object
|
||||
*
|
||||
* Check if a user @identity is authorized. If an error
|
||||
* occurs this method will return false to indicate
|
||||
* denial, as well as setting @errp to contain the details.
|
||||
* Callers are recommended to treat the denial and error
|
||||
* scenarios identically. Specifically the error info in
|
||||
* @errp should never be fed back to the user being
|
||||
* authorized, it is merely for benefit of administrator
|
||||
* debugging.
|
||||
*
|
||||
* Returns: true if @identity is authorized, false if denied or if
|
||||
* an error occurred.
|
||||
*/
|
||||
bool qauthz_is_allowed(QAuthZ *authz,
|
||||
const char *identity,
|
||||
Error **errp);
|
||||
|
||||
|
||||
/**
|
||||
* qauthz_is_allowed_by_id:
|
||||
* @authzid: ID of the authorization object
|
||||
* @identity: the user identity to authorize
|
||||
* @errp: pointer to a NULL initialized error object
|
||||
*
|
||||
* Check if a user @identity is authorized. If an error
|
||||
* occurs this method will return false to indicate
|
||||
* denial, as well as setting @errp to contain the details.
|
||||
* Callers are recommended to treat the denial and error
|
||||
* scenarios identically. Specifically the error info in
|
||||
* @errp should never be fed back to the user being
|
||||
* authorized, it is merely for benefit of administrator
|
||||
* debugging.
|
||||
*
|
||||
* Returns: true if @identity is authorized, false if denied or if
|
||||
* an error occurred.
|
||||
*/
|
||||
bool qauthz_is_allowed_by_id(const char *authzid,
|
||||
const char *identity,
|
||||
Error **errp);
|
||||
|
||||
#endif /* QAUTHZ_BASE_H__ */
|
||||
|
||||
Loading…
Reference in New Issue
Block a user