OpenE2K/qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity

Avoid thundering herd problem

Browse Source 
Broadcast was used so that the I/O threads would wakeup, reset their
ts values and all but one go to sleep, in other words an optimization
to prevent threads from exiting in presence of continuing I/O
activity. Spurious wakeups make the looping around cond_timedwait with
ever reinitialized ts potentially unsafe and as such ts in no longer
reinitilized inside the loop, hence switch to signal is warranted and
this benefits of this particlaur optimization are lost.

(It's worth noting that timed variants of pthread calls use realtime
clock by default, and therefore can hang "forever" should the host
time be changed. Unfortunatelly not all host systems QEMU runs on
support CLOCK_MONOTONIC and/or pthread_condattr_setclock with this
value)

git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@6632 c046a42c-6fe2-441c-8c8c-71466251a162
This commit is contained in:
malc 2009-02-21 05:48:15 +00:00
parent 30525aff78
commit 5d47e3728b
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
posix-aio-compat.c
View File

@ -61,10 +61,10 @@ static int cond_timedwait(pthread_cond_t *cond, pthread_mutex_t *mutex,
return ret; return ret;
} }
static void cond_broadcast(pthread_cond_t *cond) static void cond_signal(pthread_cond_t *cond)
{ {
int ret = pthread_cond_broadcast(cond); int ret = pthread_cond_signal(cond);
if (ret) die2(ret, "pthread_cond_broadcast"); if (ret) die2(ret, "pthread_cond_signal");
} }
static void thread_create(pthread_t *thread, pthread_attr_t *attr, static void thread_create(pthread_t *thread, pthread_attr_t *attr,
@ -186,7 +186,7 @@ static int qemu_paio_submit(struct qemu_paiocb *aiocb, int is_write)
spawn_thread(); spawn_thread();
TAILQ_INSERT_TAIL(&request_list, aiocb, node); TAILQ_INSERT_TAIL(&request_list, aiocb, node);
mutex_unlock(&lock); mutex_unlock(&lock);
cond_broadcast(&cond); cond_signal(&cond);
return 0; return 0;
} }