OpenE2K/qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity

vnc: fix memory leak

Browse Source 
If vnc's password is configured, it will leak memory
which cipher variable pointed on every vnc connection.

Cc: Daniel P. Berrange <berrange@redhat.com>
Reviewed-by: Daniel P. Berrange <berrange@redhat.com>
Signed-off-by: Gonglei <arei.gonglei@huawei.com>
Message-Id: <1437556133-11268-1-git-send-email-arei.gonglei@huawei.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
This commit is contained in:
Gonglei 2015-07-22 17:08:53 +08:00 committed by Paolo Bonzini
parent 4bf1cb03fb
commit 60928458e5
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
ui/vnc.c
View File

@ -2520,7 +2520,7 @@ static int protocol_client_auth_vnc(VncState *vs, uint8_t *data, size_t len)
size_t i, pwlen; size_t i, pwlen;
unsigned char key[8]; unsigned char key[8];
time_t now = time(NULL); time_t now = time(NULL);
QCryptoCipher *cipher; QCryptoCipher *cipher = NULL;
Error *err = NULL; Error *err = NULL;
if (!vs->vd->password) { if (!vs->vd->password) {
@ -2573,6 +2573,8 @@ static int protocol_client_auth_vnc(VncState *vs, uint8_t *data, size_t len)
start_client_init(vs); start_client_init(vs);
} }
qcrypto_cipher_free(cipher);
return 0; return 0;
reject: reject:
@ -2584,6 +2586,7 @@ reject:
} }
vnc_flush(vs); vnc_flush(vs);
vnc_client_error(vs); vnc_client_error(vs);
qcrypto_cipher_free(cipher);
return 0; return 0;
} }