OpenE2K
/
qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity

qemu-ga: qmp_guest_fsfreeze_*(): get rid of sprintf() + error_set() 

Convert them to error_setg_errno().

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
Reviewed-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
This commit is contained in:
Luiz Capitulino 2012-11-27 11:02:00 -02:00 committed by Michael Roth
parent 261551d1cc
commit 617fbbc132
1 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
qga/commands-posix.c
View File

@ -433,7 +433,6 @@ int64_t qmp_guest_fsfreeze_freeze(Error **err)
struct FsMount *mount;
Error *local_err = NULL;
int fd;
char err_msg[512];
slog("guest-fsfreeze called");
@ -450,9 +449,7 @@ int64_t qmp_guest_fsfreeze_freeze(Error **err)
QTAILQ_FOREACH(mount, &mounts, next) {
fd = qemu_open(mount->dirname, O_RDONLY);
if (fd == -1) {
sprintf(err_msg, "failed to open %s, %s", mount->dirname,
strerror(errno));
error_set(err, QERR_QGA_COMMAND_FAILED, err_msg);
error_setg_errno(err, errno, "failed to open %s", mount->dirname);
goto error;
}
@ -468,9 +465,8 @@ int64_t qmp_guest_fsfreeze_freeze(Error **err)
ret = ioctl(fd, FIFREEZE);
if (ret == -1) {
if (errno != EOPNOTSUPP) {
sprintf(err_msg, "failed to freeze %s, %s",
mount->dirname, strerror(errno));
error_set(err, QERR_QGA_COMMAND_FAILED, err_msg);
error_setg_errno(err, errno, "failed to freeze %s",
mount->dirname);
close(fd);
goto error;
}