hw/intc/arm_gicv3_its: Don't return early in extract_table_params() loop
In extract_table_params() we process each GITS_BASER<n> register. If the register's Valid bit is not set, this means there is no in-guest-memory table and so we should not try to interpret the other fields in the register. This was incorrectly coded as a 'return' rather than a 'break', so instead of looping round to process the next GITS_BASER<n> we would stop entirely, treating any later tables as being not valid also. This has no real guest-visible effects because (since we don't have GITS_TYPER.HCC != 0) the guest must in any case set up all the GITS_BASER<n> to point to valid tables, so this only happens in an odd misbehaving-guest corner case. Fix the check to 'break', so that we leave the case statement and loop back around to the next GITS_BASER<n>. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Alex Bennée <alex.bennee@linaro.org> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
This commit is contained in:
parent
6c1db43de4
commit
62df780e3d
@ -795,7 +795,7 @@ static void extract_table_params(GICv3ITSState *s)
|
||||
s->dt.valid = FIELD_EX64(value, GITS_BASER, VALID);
|
||||
|
||||
if (!s->dt.valid) {
|
||||
return;
|
||||
break;
|
||||
}
|
||||
|
||||
s->dt.page_sz = page_sz;
|
||||
@ -826,7 +826,7 @@ static void extract_table_params(GICv3ITSState *s)
|
||||
* hence writes are discarded if ct.valid is 0
|
||||
*/
|
||||
if (!s->ct.valid) {
|
||||
return;
|
||||
break;
|
||||
}
|
||||
|
||||
s->ct.page_sz = page_sz;
|
||||
|
Loading…
Reference in New Issue
Block a user