OpenE2K/qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity

qom: Assert that objects being destroyed have no parent

Browse Source 
QOM reference counting bugs are often hard to detect, but there's
one kind of bug that's easier: if we are freeing an object but is
still attached to a parent, it means the reference count is wrong
(because the parent always hold a reference to their children).

Add an assertion to make sure we detect those cases.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Message-Id: <20201215224133.3545901-3-ehabkost@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
This commit is contained in:
Eduardo Habkost 2020-12-15 17:41:33 -05:00 committed by Paolo Bonzini
parent 08bdf5d44f
commit 63f957ac96
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
qom/object.c
View File

@ -685,6 +685,7 @@ static void object_finalize(void *data)
object_deinit(obj, ti); object_deinit(obj, ti);
g_assert(obj->ref == 0); g_assert(obj->ref == 0);
g_assert(obj->parent == NULL);
if (obj->free) { if (obj->free) {
obj->free(obj); obj->free(obj);
} }