OpenE2K/qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity

block/quorum: Remove protocol-related fields

Browse Source 
The quorum driver is not a protocol so it should implement bdrv_open
instead of bdrv_file_open and not provide a protocol_name.

Attempts to invoke this driver using protocol syntax
(i.e. quorum:<filename:options:...>) will now fail gracefully:

  $ qemu-img info quorum:foo
  qemu-img: Could not open 'quorum:foo': Unknown protocol 'quorum'

Signed-off-by: Fabiano Rosas <farosas@linux.vnet.ibm.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Alberto Garcia <berto@igalia.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
This commit is contained in:
Fabiano Rosas 2018-03-12 19:07:50 -03:00 committed by Kevin Wolf
parent cb83d2efe1
commit 65d2c3e2f6
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
block/quorum.c
View File

@ -1098,11 +1098,10 @@ static void quorum_refresh_filename(BlockDriverState *bs, QDict *options)
static BlockDriver bdrv_quorum = { static BlockDriver bdrv_quorum = {
.format_name = "quorum", .format_name = "quorum",
.protocol_name = "quorum",
.instance_size = sizeof(BDRVQuorumState), .instance_size = sizeof(BDRVQuorumState),
.bdrv_file_open = quorum_open, .bdrv_open = quorum_open,
.bdrv_close = quorum_close, .bdrv_close = quorum_close,
.bdrv_refresh_filename = quorum_refresh_filename, .bdrv_refresh_filename = quorum_refresh_filename,