From 6669ca13c39a8515cc634695698d3dea5f39be1c Mon Sep 17 00:00:00 2001 From: Sebastian Ottlik Date: Wed, 2 Oct 2013 12:23:13 +0200 Subject: [PATCH] gdbstub: call socket_set_fast_reuse instead of setting SO_REUSEADDR SO_REUSEADDR should be avoided on Windows but is desired on other operating systems. So instead of setting it we call socket_set_fast_reuse that will result in the appropriate behaviour on all operating systems. Signed-off-by: Sebastian Ottlik Reviewed-by: Eric Blake Signed-off-by: Stefan Weil --- gdbstub.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 2b7f22b2d2..0e5a3f5bf9 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1553,7 +1553,7 @@ static void gdb_accept(void) static int gdbserver_open(int port) { struct sockaddr_in sockaddr; - int fd, val, ret; + int fd, ret; fd = socket(PF_INET, SOCK_STREAM, 0); if (fd < 0) { @@ -1564,9 +1564,7 @@ static int gdbserver_open(int port) fcntl(fd, F_SETFD, FD_CLOEXEC); #endif - /* allow fast reuse */ - val = 1; - qemu_setsockopt(fd, SOL_SOCKET, SO_REUSEADDR, &val, sizeof(val)); + socket_set_fast_reuse(fd); sockaddr.sin_family = AF_INET; sockaddr.sin_port = htons(port);