pl050: don't use legacy ps2_kbd_init() function
Instantiate the PS2 keyboard device within PL050KbdState using object_initialize_child() in pl050_kbd_init() and realize it in pl050_kbd_realize() accordingly. Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> Tested-by: Helge Deller <deller@gmx.de> Acked-by: Helge Deller <deller@gmx.de> Reviewed-by: Peter Maydell <peter.maydell@linaro.org> Message-Id: <20220712215251.7944-11-mark.cave-ayland@ilande.co.uk> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
This commit is contained in:
parent
5b0138b314
commit
6a05d0b3d1
@ -160,17 +160,24 @@ static void pl050_realize(DeviceState *dev, Error **errp)
|
||||
static void pl050_kbd_realize(DeviceState *dev, Error **errp)
|
||||
{
|
||||
PL050DeviceClass *pdc = PL050_GET_CLASS(dev);
|
||||
PL050KbdState *s = PL050_KBD_DEVICE(dev);
|
||||
PL050State *ps = PL050(dev);
|
||||
|
||||
ps->ps2dev = ps2_kbd_init();
|
||||
if (!sysbus_realize(SYS_BUS_DEVICE(&s->kbd), errp)) {
|
||||
return;
|
||||
}
|
||||
|
||||
ps->ps2dev = PS2_DEVICE(&s->kbd);
|
||||
pdc->parent_realize(dev, errp);
|
||||
}
|
||||
|
||||
static void pl050_kbd_init(Object *obj)
|
||||
{
|
||||
PL050State *s = PL050(obj);
|
||||
PL050KbdState *s = PL050_KBD_DEVICE(obj);
|
||||
PL050State *ps = PL050(obj);
|
||||
|
||||
s->is_mouse = false;
|
||||
ps->is_mouse = false;
|
||||
object_initialize_child(obj, "kbd", &s->kbd, TYPE_PS2_KBD_DEVICE);
|
||||
}
|
||||
|
||||
static void pl050_mouse_realize(DeviceState *dev, Error **errp)
|
||||
|
@ -43,6 +43,8 @@ OBJECT_DECLARE_SIMPLE_TYPE(PL050KbdState, PL050_KBD_DEVICE)
|
||||
|
||||
struct PL050KbdState {
|
||||
PL050State parent_obj;
|
||||
|
||||
PS2KbdState kbd;
|
||||
};
|
||||
|
||||
#define TYPE_PL050_MOUSE_DEVICE "pl050_mouse"
|
||||
|
Loading…
Reference in New Issue
Block a user