migration/multifd: Fix leaking of Error in TLS error flow
If there is an error in multifd TLS handshake task,
multifd_tls_outgoing_handshake() retrieves the error with
qio_task_propagate_error() but never frees it.
Fix it by freeing the obtained Error.
In addition, the error is not reported at all, so report it with
migrate_set_error().
Fixes: 2964714015
("migration/tls: add support for multifd tls-handshake")
Signed-off-by: Avihai Horon <avihaih@nvidia.com>
Reviewed-by: Fabiano Rosas <farosas@suse.de>
Link: https://lore.kernel.org/r/20231231093016.14204-8-avihaih@nvidia.com
Signed-off-by: Peter Xu <peterx@redhat.com>
This commit is contained in:
parent
a4395f5d3c
commit
6ae208ce96
|
@ -787,6 +787,7 @@ static void multifd_tls_outgoing_handshake(QIOTask *task,
|
||||||
|
|
||||||
trace_multifd_tls_outgoing_handshake_error(ioc, error_get_pretty(err));
|
trace_multifd_tls_outgoing_handshake_error(ioc, error_get_pretty(err));
|
||||||
|
|
||||||
|
migrate_set_error(migrate_get_current(), err);
|
||||||
/*
|
/*
|
||||||
* Error happen, mark multifd_send_thread status as 'quit' although it
|
* Error happen, mark multifd_send_thread status as 'quit' although it
|
||||||
* is not created, and then tell who pay attention to me.
|
* is not created, and then tell who pay attention to me.
|
||||||
|
@ -794,6 +795,7 @@ static void multifd_tls_outgoing_handshake(QIOTask *task,
|
||||||
p->quit = true;
|
p->quit = true;
|
||||||
qemu_sem_post(&multifd_send_state->channels_ready);
|
qemu_sem_post(&multifd_send_state->channels_ready);
|
||||||
qemu_sem_post(&p->sem_sync);
|
qemu_sem_post(&p->sem_sync);
|
||||||
|
error_free(err);
|
||||||
}
|
}
|
||||||
|
|
||||||
static void *multifd_tls_handshake_thread(void *opaque)
|
static void *multifd_tls_handshake_thread(void *opaque)
|
||||||
|
|
Loading…
Reference in New Issue