audio: Add braces for statements/fix braces' position

Fix problems about braces:
-braces are necessary for all arms of if/for/while statements
-else should follow close brace '}'

Signed-off-by: Zhang Han <zhanghan64@huawei.com>
Message-id: 20210115012431.79533-1-zhanghan64@huawei.com
Message-Id: <20210115012431.79533-2-zhanghan64@huawei.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
This commit is contained in:
Zhang Han 2021-01-15 09:24:25 +08:00 committed by Gerd Hoffmann
parent 2d96a00587
commit 6c6886bd01
6 changed files with 29 additions and 48 deletions

View File

@ -278,32 +278,28 @@ static snd_pcm_format_t aud_to_alsafmt (AudioFormat fmt, int endianness)
case AUDIO_FORMAT_S16: case AUDIO_FORMAT_S16:
if (endianness) { if (endianness) {
return SND_PCM_FORMAT_S16_BE; return SND_PCM_FORMAT_S16_BE;
} } else {
else {
return SND_PCM_FORMAT_S16_LE; return SND_PCM_FORMAT_S16_LE;
} }
case AUDIO_FORMAT_U16: case AUDIO_FORMAT_U16:
if (endianness) { if (endianness) {
return SND_PCM_FORMAT_U16_BE; return SND_PCM_FORMAT_U16_BE;
} } else {
else {
return SND_PCM_FORMAT_U16_LE; return SND_PCM_FORMAT_U16_LE;
} }
case AUDIO_FORMAT_S32: case AUDIO_FORMAT_S32:
if (endianness) { if (endianness) {
return SND_PCM_FORMAT_S32_BE; return SND_PCM_FORMAT_S32_BE;
} } else {
else {
return SND_PCM_FORMAT_S32_LE; return SND_PCM_FORMAT_S32_LE;
} }
case AUDIO_FORMAT_U32: case AUDIO_FORMAT_U32:
if (endianness) { if (endianness) {
return SND_PCM_FORMAT_U32_BE; return SND_PCM_FORMAT_U32_BE;
} } else {
else {
return SND_PCM_FORMAT_U32_LE; return SND_PCM_FORMAT_U32_LE;
} }
@ -722,8 +718,7 @@ static int alsa_voice_ctl (snd_pcm_t *handle, const char *typ, int ctl)
alsa_logerr (err, "Could not stop %s\n", typ); alsa_logerr (err, "Could not stop %s\n", typ);
return -1; return -1;
} }
} } else {
else {
err = snd_pcm_prepare (handle); err = snd_pcm_prepare (handle);
if (err < 0) { if (err < 0) {
alsa_logerr (err, "Could not prepare handle for %s\n", typ); alsa_logerr (err, "Could not prepare handle for %s\n", typ);

View File

@ -344,8 +344,7 @@ void audio_pcm_info_clear_buf (struct audio_pcm_info *info, void *buf, int len)
if (info->is_signed || info->is_float) { if (info->is_signed || info->is_float) {
memset(buf, 0x00, len * info->bytes_per_frame); memset(buf, 0x00, len * info->bytes_per_frame);
} } else {
else {
switch (info->bits) { switch (info->bits) {
case 8: case 8:
memset(buf, 0x80, len * info->bytes_per_frame); memset(buf, 0x80, len * info->bytes_per_frame);
@ -584,8 +583,7 @@ static size_t audio_pcm_sw_get_rpos_in(SWVoiceIn *sw)
rpos = hw->conv_buf->pos - live; rpos = hw->conv_buf->pos - live;
if (rpos >= 0) { if (rpos >= 0) {
return rpos; return rpos;
} } else {
else {
return hw->conv_buf->size + rpos; return hw->conv_buf->size + rpos;
} }
} }
@ -788,10 +786,14 @@ static int audio_is_timer_needed(AudioState *s)
HWVoiceOut *hwo = NULL; HWVoiceOut *hwo = NULL;
while ((hwo = audio_pcm_hw_find_any_enabled_out(s, hwo))) { while ((hwo = audio_pcm_hw_find_any_enabled_out(s, hwo))) {
if (!hwo->poll_mode) return 1; if (!hwo->poll_mode) {
return 1;
}
} }
while ((hwi = audio_pcm_hw_find_any_enabled_in(s, hwi))) { while ((hwi = audio_pcm_hw_find_any_enabled_in(s, hwi))) {
if (!hwi->poll_mode) return 1; if (!hwi->poll_mode) {
return 1;
}
} }
return 0; return 0;
} }
@ -908,8 +910,7 @@ void AUD_set_active_out (SWVoiceOut *sw, int on)
audio_reset_timer (s); audio_reset_timer (s);
} }
} }
} } else {
else {
if (hw->enabled) { if (hw->enabled) {
int nb_active = 0; int nb_active = 0;
@ -956,8 +957,7 @@ void AUD_set_active_in (SWVoiceIn *sw, int on)
} }
} }
sw->total_hw_samples_acquired = hw->total_samples_captured; sw->total_hw_samples_acquired = hw->total_samples_captured;
} } else {
else {
if (hw->enabled) { if (hw->enabled) {
int nb_active = 0; int nb_active = 0;
@ -1532,8 +1532,7 @@ static int audio_driver_init(AudioState *s, struct audio_driver *drv,
audio_init_nb_voices_in(s, drv); audio_init_nb_voices_in(s, drv);
s->drv = drv; s->drv = drv;
return 0; return 0;
} } else {
else {
if (msg) { if (msg) {
dolog("Could not init `%s' audio driver\n", drv->name); dolog("Could not init `%s' audio driver\n", drv->name);
} }
@ -1848,8 +1847,7 @@ CaptureVoiceOut *AUD_add_capture(
if (cap) { if (cap) {
QLIST_INSERT_HEAD (&cap->cb_head, cb, entries); QLIST_INSERT_HEAD (&cap->cb_head, cb, entries);
return cap; return cap;
} } else {
else {
HWVoiceOut *hw; HWVoiceOut *hw;
CaptureVoiceOut *cap; CaptureVoiceOut *cap;

View File

@ -47,8 +47,7 @@ static void glue(audio_init_nb_voices_, TYPE)(AudioState *s,
#ifdef DAC #ifdef DAC
dolog ("Driver `%s' does not support " NAME "\n", drv->name); dolog ("Driver `%s' does not support " NAME "\n", drv->name);
#endif #endif
} } else {
else {
dolog ("Driver `%s' does not support %d " NAME " voices, max %d\n", dolog ("Driver `%s' does not support %d " NAME " voices, max %d\n",
drv->name, drv->name,
glue (s->nb_hw_voices_, TYPE), glue (s->nb_hw_voices_, TYPE),
@ -387,8 +386,7 @@ static SW *glue(audio_pcm_create_voice_pair_, TYPE)(
if (pdo->fixed_settings) { if (pdo->fixed_settings) {
hw_as = audiodev_to_audsettings(pdo); hw_as = audiodev_to_audsettings(pdo);
} } else {
else {
hw_as = *as; hw_as = *as;
} }
@ -498,8 +496,7 @@ SW *glue (AUD_open_, TYPE) (
if (glue (audio_pcm_sw_init_, TYPE) (sw, hw, name, as)) { if (glue (audio_pcm_sw_init_, TYPE) (sw, hw, name, as)) {
goto fail; goto fail;
} }
} } else {
else {
sw = glue(audio_pcm_create_voice_pair_, TYPE)(s, name, as); sw = glue(audio_pcm_create_voice_pair_, TYPE)(s, name, as);
if (!sw) { if (!sw) {
dolog ("Failed to create voice `%s'\n", name); dolog ("Failed to create voice `%s'\n", name);
@ -553,8 +550,7 @@ uint64_t glue (AUD_get_elapsed_usec_, TYPE) (SW *sw, QEMUAudioTimeStamp *ts)
if (cur_ts >= old_ts) { if (cur_ts >= old_ts) {
delta = cur_ts - old_ts; delta = cur_ts - old_ts;
} } else {
else {
delta = UINT64_MAX - old_ts + cur_ts; delta = UINT64_MAX - old_ts + cur_ts;
} }

View File

@ -524,8 +524,7 @@ static int coreaudio_init_out(HWVoiceOut *hw, struct audsettings *as,
} else if (frameRange.mMaximum < frames) { } else if (frameRange.mMaximum < frames) {
core->audioDevicePropertyBufferFrameSize = (UInt32) frameRange.mMaximum; core->audioDevicePropertyBufferFrameSize = (UInt32) frameRange.mMaximum;
dolog ("warning: Downsizing Buffer Frames to %f\n", frameRange.mMaximum); dolog ("warning: Downsizing Buffer Frames to %f\n", frameRange.mMaximum);
} } else {
else {
core->audioDevicePropertyBufferFrameSize = frames; core->audioDevicePropertyBufferFrameSize = frames;
} }

View File

@ -404,8 +404,7 @@ static void dsound_enable_out(HWVoiceOut *hw, bool enable)
dsound_logerr (hr, "Could not stop playing buffer\n"); dsound_logerr (hr, "Could not stop playing buffer\n");
return; return;
} }
} } else {
else {
dolog ("warning: Voice is not playing\n"); dolog ("warning: Voice is not playing\n");
} }
} }
@ -509,8 +508,7 @@ static void dsound_enable_in(HWVoiceIn *hw, bool enable)
dsound_logerr (hr, "Could not stop capturing\n"); dsound_logerr (hr, "Could not stop capturing\n");
return; return;
} }
} } else {
else {
dolog ("warning: Voice is not capturing\n"); dolog ("warning: Voice is not capturing\n");
} }
} }
@ -659,8 +657,7 @@ static void *dsound_audio_init(Audiodev *dev)
); );
if (FAILED (hr)) { if (FAILED (hr)) {
dsound_logerr (hr, "Could not create DirectSoundCapture instance\n"); dsound_logerr (hr, "Could not create DirectSoundCapture instance\n");
} } else {
else {
hr = IDirectSoundCapture_Initialize (s->dsound_capture, NULL); hr = IDirectSoundCapture_Initialize (s->dsound_capture, NULL);
if (FAILED (hr)) { if (FAILED (hr)) {
dsound_logerr (hr, "Could not initialize DirectSoundCapture\n"); dsound_logerr (hr, "Could not initialize DirectSoundCapture\n");

View File

@ -142,16 +142,14 @@ static int aud_to_ossfmt (AudioFormat fmt, int endianness)
case AUDIO_FORMAT_S16: case AUDIO_FORMAT_S16:
if (endianness) { if (endianness) {
return AFMT_S16_BE; return AFMT_S16_BE;
} } else {
else {
return AFMT_S16_LE; return AFMT_S16_LE;
} }
case AUDIO_FORMAT_U16: case AUDIO_FORMAT_U16:
if (endianness) { if (endianness) {
return AFMT_U16_BE; return AFMT_U16_BE;
} } else {
else {
return AFMT_U16_LE; return AFMT_U16_LE;
} }
@ -542,16 +540,14 @@ static int oss_init_out(HWVoiceOut *hw, struct audsettings *as,
int trig = 0; int trig = 0;
if (ioctl (fd, SNDCTL_DSP_SETTRIGGER, &trig) < 0) { if (ioctl (fd, SNDCTL_DSP_SETTRIGGER, &trig) < 0) {
oss_logerr (errno, "SNDCTL_DSP_SETTRIGGER 0 failed\n"); oss_logerr (errno, "SNDCTL_DSP_SETTRIGGER 0 failed\n");
} } else {
else {
trig = PCM_ENABLE_OUTPUT; trig = PCM_ENABLE_OUTPUT;
if (ioctl (fd, SNDCTL_DSP_SETTRIGGER, &trig) < 0) { if (ioctl (fd, SNDCTL_DSP_SETTRIGGER, &trig) < 0) {
oss_logerr ( oss_logerr (
errno, errno,
"SNDCTL_DSP_SETTRIGGER PCM_ENABLE_OUTPUT failed\n" "SNDCTL_DSP_SETTRIGGER PCM_ENABLE_OUTPUT failed\n"
); );
} } else {
else {
oss->mmapped = 1; oss->mmapped = 1;
} }
} }