qemu-ga: Plug memory leak in guest_fsfreeze_cleanup()
Neglects to free errors allocated by qmp_guest_fsfreeze_thaw(). Spotted by Coverity. While there, drop the test whether return value is negative (it's never true), and improve logging. Signed-off-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Eric Blake <eblake@redhat.com> Reviewed-by: Luiz Capitulino <lcapitulino@redhat.com> Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
This commit is contained in:
parent
6034fe7bdb
commit
6f6867493c
|
@ -611,13 +611,14 @@ int64_t qmp_guest_fsfreeze_thaw(Error **err)
|
||||||
|
|
||||||
static void guest_fsfreeze_cleanup(void)
|
static void guest_fsfreeze_cleanup(void)
|
||||||
{
|
{
|
||||||
int64_t ret;
|
|
||||||
Error *err = NULL;
|
Error *err = NULL;
|
||||||
|
|
||||||
if (ga_is_frozen(ga_state) == GUEST_FSFREEZE_STATUS_FROZEN) {
|
if (ga_is_frozen(ga_state) == GUEST_FSFREEZE_STATUS_FROZEN) {
|
||||||
ret = qmp_guest_fsfreeze_thaw(&err);
|
qmp_guest_fsfreeze_thaw(&err);
|
||||||
if (ret < 0 || err) {
|
if (err) {
|
||||||
slog("failed to clean up frozen filesystems");
|
slog("failed to clean up frozen filesystems: %s",
|
||||||
|
error_get_pretty(err));
|
||||||
|
error_free(err);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in New Issue