tests/hexloader-test: Don't pass -nographic to the QEMU under test
The hexloader test invokes QEMU with the -nographic argument. This is unnecessary, because the qtest_initf() function will pass it -display none, which suffices to disable the graphical window. It also means that the QEMU process will make the stdin/stdout O_NONBLOCK. Since O_NONBLOCK is not per-file descriptor but per "file description", this non-blocking behaviour is then shared with any other process that's using the stdin/stdout of the 'make check' run, including make itself. This can result in make falling over with "make: write error: stdout" because it got an unexpected EINTR trying to write output messages to the terminal. This is particularly noticable if running 'make check' in a loop with while make check; do true; done (It does not affect single make check runs so much because the shell will remove the O_NONBLOCK status before it reads the terminal for interactive input.) Remove the unwanted -nographic argument. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Thomas Huth <thuth@redhat.com> Signed-off-by: Thomas Huth <thuth@redhat.com>
This commit is contained in:
parent
7be41675f7
commit
739fc38778
@ -23,7 +23,7 @@ static void hex_loader_test(void)
|
||||
const unsigned int base_addr = 0x00010000;
|
||||
|
||||
QTestState *s = qtest_initf(
|
||||
"-M vexpress-a9 -nographic -device loader,file=tests/data/hex-loader/test.hex");
|
||||
"-M vexpress-a9 -device loader,file=tests/data/hex-loader/test.hex");
|
||||
|
||||
for (i = 0; i < 256; ++i) {
|
||||
uint8_t val = qtest_readb(s, base_addr + i);
|
||||
|
Loading…
Reference in New Issue
Block a user