From 7464f0587b2938a3e10e9f995f384df8a5f298ac Mon Sep 17 00:00:00 2001 From: Stefan Weil Date: Fri, 21 Jan 2011 22:50:30 +0100 Subject: [PATCH] check-qdict: Fix possible crash This warning is reported by cppcheck: check-qdict.c:270: warning: scanf without field width limits can crash with huge input data Fix it by limiting the field widths to 127 (both key and value take 127 characters + a terminating '\0' byte). Signed-off-by: Stefan Weil Signed-off-by: Aurelien Jarno --- check-qdict.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/check-qdict.c b/check-qdict.c index 6afce5a5ca..ecc7fd7b90 100644 --- a/check-qdict.c +++ b/check-qdict.c @@ -267,8 +267,9 @@ static QString *read_line(FILE *file, char *key) { char value[128]; - if (fscanf(file, "%s%s", key, value) == EOF) + if (fscanf(file, "%127s%127s", key, value) == EOF) { return NULL; + } remove_dots(key); return qstring_from_str(value); }