OpenE2K/qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity

s390x/tcg: refactor specification checking

Browse Source 
We can fit this nicely into less LOC, without harming readability.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
Message-Id: <20180927130303.12236-10-david@redhat.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
This commit is contained in:
David Hildenbrand 2018-09-27 15:03:03 +02:00 committed by Cornelia Huck
parent eba7170b55
commit 74fbae31cf
1 changed files with 6 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
target/s390x/translate.c
View File

@ -6092,34 +6092,12 @@ static DisasJumpType translate_one(CPUS390XState *env, DisasContext *s)
/* Check for insn specification exceptions. */
if (insn->spec) {
int spec = insn->spec, excp = 0, r;
if (spec & SPEC_r1_even) {
r = get_field(&f, r1);
if (r & 1) {
excp = PGM_SPECIFICATION;
}
}
if (spec & SPEC_r2_even) {
r = get_field(&f, r2);
if (r & 1) {
excp = PGM_SPECIFICATION;
}
}
if (spec & SPEC_r3_even) {
r = get_field(&f, r3);
if (r & 1) {
excp = PGM_SPECIFICATION;
}
}
if (spec & SPEC_r1_f128 && !is_fp_pair(get_field(&f, r1))) {
excp = PGM_SPECIFICATION;
}
if (spec & SPEC_r2_f128 && !is_fp_pair(get_field(&f, r2))) {
excp = PGM_SPECIFICATION;
}
if (excp) {
gen_program_exception(s, excp);
if ((insn->spec & SPEC_r1_even && get_field(&f, r1) & 1) ||
(insn->spec & SPEC_r2_even && get_field(&f, r2) & 1) ||
(insn->spec & SPEC_r3_even && get_field(&f, r3) & 1) ||
(insn->spec & SPEC_r1_f128 && !is_fp_pair(get_field(&f, r1))) ||
(insn->spec & SPEC_r2_f128 && !is_fp_pair(get_field(&f, r2)))) {
gen_program_exception(s, PGM_SPECIFICATION);
return DISAS_NORETURN;
}
}