tests/docker: change tag naming scheme of our images

We've been misusing the tag naming scheme for some time by overloading
the post : section with the image type. Really it should be saved for
the revision of that particular build. Move the details to the other
side so we have:

  qemu/image-name

with the implied :latest version added by the tooling.

Suggested-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Message-Id: <20200701135652.1366-18-alex.bennee@linaro.org>
This commit is contained in:
Alex Bennée 2020-07-01 14:56:29 +01:00
parent 10c927dcc5
commit 767b6bd22b
28 changed files with 34 additions and 34 deletions

View File

@ -29,8 +29,8 @@ build:
pre_ci:
- make docker-image-${IMAGE} V=1
pre_ci_boot:
image_name: qemu
image_tag: ${IMAGE}
image_name: qemu/${IMAGE}
image_tag: latest
pull: false
options: "-e HOME=/root"
ci:

View File

@ -50,12 +50,12 @@ docker-image: ${DOCKER_TARGETS}
ifdef SKIP_DOCKER_BUILD
docker-image-%: $(DOCKER_FILES_DIR)/%.docker
$(call quiet-command, \
$(DOCKER_SCRIPT) check --quiet qemu:$* $<, \
$(DOCKER_SCRIPT) check --quiet qemu/$* $<, \
"CHECK", "$*")
else
docker-image-%: $(DOCKER_FILES_DIR)/%.docker
$(call quiet-command,\
$(DOCKER_SCRIPT) build -t qemu:$* -f $< \
$(DOCKER_SCRIPT) build -t qemu/$* -f $< \
$(if $V,,--quiet) $(if $(NOCACHE),--no-cache) \
$(if $(NOUSER),,--add-current-user) \
$(if $(EXTRA_FILES),--extra-files $(EXTRA_FILES))\
@ -75,14 +75,14 @@ docker-binfmt-image-debian-%: $(DOCKER_FILES_DIR)/debian-bootstrap.docker
DEB_ARCH=$(DEB_ARCH) \
DEB_TYPE=$(DEB_TYPE) \
$(if $(DEB_URL),DEB_URL=$(DEB_URL),) \
$(DOCKER_SCRIPT) build qemu:debian-$* $< \
$(DOCKER_SCRIPT) build qemu/debian-$* $< \
$(if $V,,--quiet) $(if $(NOCACHE),--no-cache) \
$(if $(NOUSER),,--add-current-user) \
$(if $(EXTRA_FILES),--extra-files $(EXTRA_FILES)) \
$(if $(EXECUTABLE),--include-executable=$(EXECUTABLE)), \
"BUILD","binfmt debian-$* (debootstrapped)"), \
$(call quiet-command, \
$(DOCKER_SCRIPT) check --quiet qemu:debian-$* $< || \
$(DOCKER_SCRIPT) check --quiet qemu/debian-$* $< || \
{ echo "You will need to build $(EXECUTABLE)"; exit 1;},\
"CHECK", "debian-$* exists"))
@ -258,7 +258,7 @@ docker-run: docker-qemu-src
docker-run-%: CMD = $(shell echo '$@' | sed -e 's/docker-run-\([^@]*\)@\(.*\)/\1/')
docker-run-%: IMAGE = $(shell echo '$@' | sed -e 's/docker-run-\([^@]*\)@\(.*\)/\2/')
docker-run-%:
@$(MAKE) docker-run TEST=$(CMD) IMAGE=qemu:$(IMAGE)
@$(MAKE) docker-run TEST=$(CMD) IMAGE=qemu/$(IMAGE)
docker-clean:
$(call quiet-command, $(DOCKER_SCRIPT) clean)

View File

@ -204,7 +204,7 @@ def _dockerfile_preprocess(df):
for l in df.splitlines():
if len(l.strip()) == 0 or l.startswith("#"):
continue
from_pref = "FROM qemu:"
from_pref = "FROM qemu/"
if l.startswith(from_pref):
# TODO: Alternatively we could replace this line with "FROM $ID"
# where $ID is the image's hex id obtained with

View File

@ -3,7 +3,7 @@
#
# This docker target builds on the debian Buster base image.
#
FROM qemu:debian10
FROM qemu/debian10
RUN apt update && \
DEBIAN_FRONTEND=noninteractive eatmydata \

View File

@ -4,7 +4,7 @@
# This docker target is used on non-x86_64 machines which need the
# x86_64 cross compilers installed.
#
FROM qemu:debian10
FROM qemu/debian10
MAINTAINER Alex Bennée <alex.bennee@linaro.org>
# Add the foreign architecture we want and install dependencies

View File

@ -4,7 +4,7 @@
# This docker target builds on the debian Stretch base image. Further
# libraries which are not widely available are installed by hand.
#
FROM qemu:debian10
FROM qemu/debian10
MAINTAINER Philippe Mathieu-Daudé <f4bug@amsat.org>
RUN apt update && \

View File

@ -3,7 +3,7 @@
#
# This docker target builds on the debian Buster base image.
#
FROM qemu:debian10
FROM qemu/debian10
# Add the foreign architecture we want and install dependencies
RUN dpkg --add-architecture arm64

View File

@ -3,7 +3,7 @@
#
# This docker target builds on the debian Bullseye base image.
#
FROM qemu:debian11
FROM qemu/debian11
# Add the foreign architecture we want and install dependencies
RUN dpkg --add-architecture arm64

View File

@ -3,7 +3,7 @@
#
# This docker target builds on the debian Stretch base image.
#
FROM qemu:debian10
FROM qemu/debian10
MAINTAINER Philippe Mathieu-Daudé <f4bug@amsat.org>
# Add the foreign architecture we want and install dependencies

View File

@ -3,7 +3,7 @@
#
# This docker target builds on the debian Stretch base image.
#
FROM qemu:debian10
FROM qemu/debian10
# Add the foreign architecture we want and install dependencies
RUN dpkg --add-architecture armhf

View File

@ -3,7 +3,7 @@
#
# This docker target builds on the debian Buster base image.
#
FROM qemu:debian10
FROM qemu/debian10
RUN apt update && \
DEBIAN_FRONTEND=noninteractive eatmydata \

View File

@ -3,7 +3,7 @@
#
# This docker target builds on the debian Buster base image.
#
FROM qemu:debian10
FROM qemu/debian10
RUN apt update && \
DEBIAN_FRONTEND=noninteractive eatmydata \

View File

@ -3,7 +3,7 @@
#
# This docker target builds on the debian Buster base image.
#
FROM qemu:debian10
FROM qemu/debian10
MAINTAINER Philippe Mathieu-Daudé <f4bug@amsat.org>

View File

@ -3,7 +3,7 @@
#
# This docker target builds on the debian Buster base image.
#
FROM qemu:debian10
FROM qemu/debian10
RUN apt update && \
DEBIAN_FRONTEND=noninteractive eatmydata \

View File

@ -4,7 +4,7 @@
# This docker target builds on the debian Stretch base image.
#
FROM qemu:debian10
FROM qemu/debian10
MAINTAINER Philippe Mathieu-Daudé <f4bug@amsat.org>

View File

@ -3,7 +3,7 @@
#
# This docker target builds on the debian Stretch base image.
#
FROM qemu:debian10
FROM qemu/debian10
MAINTAINER Philippe Mathieu-Daudé <f4bug@amsat.org>

View File

@ -3,7 +3,7 @@
#
# This docker target builds on the debian Buster base image.
#
FROM qemu:debian10
FROM qemu/debian10
RUN apt update && \
DEBIAN_FRONTEND=noninteractive eatmydata \

View File

@ -2,7 +2,7 @@
# Docker ppc64 cross-compiler target
#
# This docker target builds on the debian Buster base image.
FROM qemu:debian10
FROM qemu/debian10
RUN apt update && \
DEBIAN_FRONTEND=noninteractive eatmydata \

View File

@ -3,7 +3,7 @@
#
# This docker target builds on the debian Stretch base image.
#
FROM qemu:debian10
FROM qemu/debian10
# Add the foreign architecture we want and install dependencies
RUN dpkg --add-architecture ppc64el && \

View File

@ -3,7 +3,7 @@
#
# This docker target builds on the debian Buster base image.
#
FROM qemu:debian10
FROM qemu/debian10
RUN apt update && \
DEBIAN_FRONTEND=noninteractive eatmydata \

View File

@ -3,7 +3,7 @@
#
# This docker target builds on the debian Stretch base image.
#
FROM qemu:debian10
FROM qemu/debian10
# Add the s390x architecture
RUN dpkg --add-architecture s390x

View File

@ -3,7 +3,7 @@
#
# This docker target builds on the debian Buster base image.
#
FROM qemu:debian10
FROM qemu/debian10
RUN apt update && \
DEBIAN_FRONTEND=noninteractive eatmydata \

View File

@ -3,7 +3,7 @@
#
# This docker target builds on the debian Buster base image.
#
FROM qemu:debian10
FROM qemu/debian10
RUN apt update && \
DEBIAN_FRONTEND=noninteractive eatmydata \

View File

@ -7,7 +7,7 @@
#
# SPDX-License-Identifier: GPL-2.0-or-later
#
FROM qemu:debian9
FROM qemu/debian9
MAINTAINER Philippe Mathieu-Daudé <f4bug@amsat.org>

View File

@ -3,7 +3,7 @@
#
# This docker target builds on the debian Stretch MXE base image.
#
FROM qemu:debian9-mxe
FROM qemu/debian9-mxe
MAINTAINER Philippe Mathieu-Daudé <f4bug@amsat.org>

View File

@ -3,7 +3,7 @@
#
# This docker target builds on the debian Stretch MXE base image.
#
FROM qemu:debian9-mxe
FROM qemu/debian9-mxe
MAINTAINER Philippe Mathieu-Daudé <f4bug@amsat.org>

View File

@ -3,7 +3,7 @@
#
# This docker target builds on the debian Stretch base image.
#
FROM qemu:debian9
FROM qemu/debian9
MAINTAINER Philippe Mathieu-Daudé <f4bug@amsat.org>

View File

@ -47,7 +47,7 @@ ifneq ($(DOCKER_IMAGE),)
DOCKER_COMPILE_CMD="$(DOCKER_SCRIPT) cc \
--cc $(DOCKER_CROSS_CC_GUEST) \
-i qemu:$(DOCKER_IMAGE) \
-i qemu/$(DOCKER_IMAGE) \
-s $(SRC_PATH) -- "
.PHONY: docker-build-guest-tests
@ -57,7 +57,7 @@ docker-build-guest-tests: docker-image-$(DOCKER_IMAGE)
$(MAKE) -f $(TCG_MAKE) TARGET="$(TARGET)" CC=$(DOCKER_COMPILE_CMD) \
SRC_PATH="$(SRC_PATH)" BUILD_STATIC=y \
EXTRA_CFLAGS="$(CROSS_CC_GUEST_CFLAGS)"), \
"BUILD","$(TARGET) guest-tests with docker qemu:$(DOCKER_IMAGE)")
"BUILD","$(TARGET) guest-tests with docker qemu/$(DOCKER_IMAGE)")
GUEST_BUILD=docker-build-guest-tests