OpenE2K/qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity

migration/multifd: Make multifd_channel_connect() return void

Browse Source 
It never fails, drop the retval and also the Error**.

Suggested-by: Avihai Horon <avihaih@nvidia.com>
Reviewed-by: Fabiano Rosas <farosas@suse.de>
Link: https://lore.kernel.org/r/20240222095301.171137-4-peterx@redhat.com
Signed-off-by: Peter Xu <peterx@redhat.com>
This commit is contained in:
Peter Xu 2024-02-22 17:52:59 +08:00
parent 0518b5d8d3
commit 770de49c00
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
migration/multifd.c
View File

@ -943,9 +943,7 @@ static bool multifd_tls_channel_connect(MultiFDSendParams *p,
return true; return true;
} }
static bool multifd_channel_connect(MultiFDSendParams *p, static void multifd_channel_connect(MultiFDSendParams *p, QIOChannel *ioc)
QIOChannel *ioc,
Error **errp)
{ {
qio_channel_set_delay(ioc, false); qio_channel_set_delay(ioc, false);
@ -956,7 +954,6 @@ static bool multifd_channel_connect(MultiFDSendParams *p,
p->thread_created = true; p->thread_created = true;
qemu_thread_create(&p->thread, p->name, multifd_send_thread, p, qemu_thread_create(&p->thread, p->name, multifd_send_thread, p,
QEMU_THREAD_JOINABLE); QEMU_THREAD_JOINABLE);
return true;
} }
/* /*
@ -988,7 +985,8 @@ static void multifd_new_send_channel_async(QIOTask *task, gpointer opaque)
return; return;
} }
} else { } else {
ret = multifd_channel_connect(p, ioc, &local_err); multifd_channel_connect(p, ioc);
ret = true;
} }
out: out: