OpenE2K/qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity

l2tpv3: fix possible double free

Browse Source 
freeaddrinfo(result) does not assign result = NULL, after frees it.
There will be a double free when it goes error case.
It is reported by covertiy.

Reviewed-by: Gonglei <arei.gonglei@huawei.com>
Cc: qemu-stable@nongnu.org
Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
This commit is contained in:
zhanghailiang 2014-11-14 09:39:23 +08:00 committed by Paolo Bonzini
parent 5bbebf6228
commit 77374582ab
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
net/l2tpv3.c
View File

@ -660,7 +660,6 @@ int net_init_l2tpv3(const NetClientOptions *opts,
if (fd == -1) { if (fd == -1) {
fd = -errno; fd = -errno;
error_report("l2tpv3_open : socket creation failed, errno = %d", -fd); error_report("l2tpv3_open : socket creation failed, errno = %d", -fd);
freeaddrinfo(result);
goto outerr; goto outerr;
} }
if (bind(fd, (struct sockaddr *) result->ai_addr, result->ai_addrlen)) { if (bind(fd, (struct sockaddr *) result->ai_addr, result->ai_addrlen)) {