From 7b67b18adf921c77aa8443f3b4cddab87908ee1e Mon Sep 17 00:00:00 2001 From: "Michael S. Tsirkin" Date: Wed, 16 Mar 2011 12:09:09 +0200 Subject: [PATCH] vhost: fix dirty page handling vhost was passing a physical address to cpu_physical_memory_set_dirty, which is wrong: we need to translate to ram address first. Signed-off-by: Michael S. Tsirkin Note: this lead to crashes during migration, so the patch is needed on the stable branch too. --- hw/vhost.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/vhost.c b/hw/vhost.c index 0ca3507f44..14b571d07c 100644 --- a/hw/vhost.c +++ b/hw/vhost.c @@ -47,8 +47,10 @@ static void vhost_dev_sync_region(struct vhost_dev *dev, log = __sync_fetch_and_and(from, 0); while ((bit = sizeof(log) > sizeof(int) ? ffsll(log) : ffs(log))) { + ram_addr_t ram_addr; bit -= 1; - cpu_physical_memory_set_dirty(addr + bit * VHOST_LOG_PAGE); + ram_addr = cpu_get_physical_page_desc(addr + bit * VHOST_LOG_PAGE); + cpu_physical_memory_set_dirty(ram_addr); log &= ~(0x1ull << bit); } addr += VHOST_LOG_CHUNK;