OpenE2K/qemu-e2k
13
4
Fork 0
Code Issues 4 Pull Requests Projects 2 Releases Activity

qdev: Legacy properties are just strings

Browse Source 
prop->info->legacy_name is still used by "-device foo,?".

Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
This commit is contained in:
Paolo Bonzini 2014-02-08 11:01:48 +01:00 committed by Andreas Färber
parent 03ff777048
commit 7ce7ffe027
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
hw/core/qdev.c
View File

@ -590,7 +590,7 @@ static void qdev_get_legacy_property(Object *obj, Visitor *v, void *opaque,
void qdev_property_add_legacy(DeviceState *dev, Property *prop, void qdev_property_add_legacy(DeviceState *dev, Property *prop,
Error **errp) Error **errp)
{ {
gchar *name, *type; gchar *name;
/* Register pointer properties as legacy properties */ /* Register pointer properties as legacy properties */
if (!prop->info->print && prop->info->get) { if (!prop->info->print && prop->info->get) {
@ -598,16 +598,12 @@ void qdev_property_add_legacy(DeviceState *dev, Property *prop,
} }
name = g_strdup_printf("legacy-%s", prop->name); name = g_strdup_printf("legacy-%s", prop->name);
type = g_strdup_printf("legacy<%s>", object_property_add(OBJECT(dev), name, "str",
prop->info->legacy_name ?: prop->info->name);
object_property_add(OBJECT(dev), name, type,
prop->info->print ? qdev_get_legacy_property : prop->info->get, prop->info->print ? qdev_get_legacy_property : prop->info->get,
NULL, NULL,
NULL, NULL,
prop, errp); prop, errp);
g_free(type);
g_free(name); g_free(name);
} }